* [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency
@ 2012-09-14 22:41 Peter Huewe
2012-09-15 18:23 ` Mike Dunn
2012-09-26 9:49 ` Artem Bityutskiy
0 siblings, 2 replies; 3+ messages in thread
From: Peter Huewe @ 2012-09-14 22:41 UTC (permalink / raw)
To: David Woodhouse
Cc: Artem Bityutskiy, Huang Shijie, Arnd Bergmann, Shubhrajyoti D,
linux-mtd, linux-kernel, Peter Huewe
While building an allyesconfig for UML I received this error message(s):
drivers/mtd/nand/docg4.c: In function 'probe_docg4':
drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function
'ioremap' [-Werror=implicit-function-declaration]
drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from
integer without a cast [enabled by default]
drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function
'iounmap' [-Werror=implicit-function-declaration]
which is caused by the missing implementations on UML.
This patch adds this missing HAS_IOMEM dependency and prevents the driver from
being build on platforms with no HAS_IOMEM
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/mtd/nand/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 8ca4176..3e2f75d 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE
config MTD_NAND_DOCG4
tristate "Support for DiskOnChip G4 (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && HAS_IOMEM
select BCH
select BITREVERSE
help
--
1.7.8.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency
2012-09-14 22:41 [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency Peter Huewe
@ 2012-09-15 18:23 ` Mike Dunn
2012-09-26 9:49 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Mike Dunn @ 2012-09-15 18:23 UTC (permalink / raw)
To: Peter Huewe
Cc: David Woodhouse, Arnd Bergmann, Artem Bityutskiy, linux-kernel,
Huang Shijie, linux-mtd, Shubhrajyoti D
Acked-by: Mike Dunn <mikedunn@newsguy.com>
Sorry for the oversight.
Mike
On 09/14/2012 03:41 PM, Peter Huewe wrote:
> While building an allyesconfig for UML I received this error message(s):
> drivers/mtd/nand/docg4.c: In function 'probe_docg4':
> drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function
> 'ioremap' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function
> 'iounmap' [-Werror=implicit-function-declaration]
>
> which is caused by the missing implementations on UML.
>
> This patch adds this missing HAS_IOMEM dependency and prevents the driver from
> being build on platforms with no HAS_IOMEM
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 8ca4176..3e2f75d 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE
>
> config MTD_NAND_DOCG4
> tristate "Support for DiskOnChip G4 (EXPERIMENTAL)"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && HAS_IOMEM
> select BCH
> select BITREVERSE
> help
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency
2012-09-14 22:41 [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency Peter Huewe
2012-09-15 18:23 ` Mike Dunn
@ 2012-09-26 9:49 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-09-26 9:49 UTC (permalink / raw)
To: Peter Huewe
Cc: David Woodhouse, Huang Shijie, Arnd Bergmann, Shubhrajyoti D,
linux-mtd, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On Sat, 2012-09-15 at 00:41 +0200, Peter Huewe wrote:
> While building an allyesconfig for UML I received this error message(s):
> drivers/mtd/nand/docg4.c: In function 'probe_docg4':
> drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function
> 'ioremap' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function
> 'iounmap' [-Werror=implicit-function-declaration]
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-26 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-14 22:41 [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency Peter Huewe
2012-09-15 18:23 ` Mike Dunn
2012-09-26 9:49 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).