linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool
@ 2012-09-21  9:04 Oliver Chick
  2012-09-21 13:36 ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver Chick @ 2012-09-21  9:04 UTC (permalink / raw)
  To: konrad.wilk, xen-devel, linux-kernel; +Cc: Oliver Chick

Changing the type of bdev parameters to be unsigned int :1, rather than bool.
This is more consistent with the types of other features in the block drivers.

Signed-off-by: Oliver Chick <oliver.chick@citrix.com>
---
 drivers/block/xen-blkback/common.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h
index 9ad3b5e..9a54623 100644
--- a/drivers/block/xen-blkback/common.h
+++ b/drivers/block/xen-blkback/common.h
@@ -158,8 +158,8 @@ struct xen_vbd {
 	struct block_device	*bdev;
 	/* Cached size parameter. */
 	sector_t		size;
-	bool			flush_support;
-	bool			discard_secure;
+	unsigned int		flush_support:1;
+	unsigned int		discard_secure:1;
 };
 
 struct backend_info;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool
  2012-09-21  9:04 [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool Oliver Chick
@ 2012-09-21 13:36 ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-09-21 13:36 UTC (permalink / raw)
  To: Oliver Chick; +Cc: xen-devel, linux-kernel

On Fri, Sep 21, 2012 at 10:04:18AM +0100, Oliver Chick wrote:
> Changing the type of bdev parameters to be unsigned int :1, rather than bool.
> This is more consistent with the types of other features in the block drivers.

Thanks. Put in my for-jens branch.
> 
> Signed-off-by: Oliver Chick <oliver.chick@citrix.com>
> ---
>  drivers/block/xen-blkback/common.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h
> index 9ad3b5e..9a54623 100644
> --- a/drivers/block/xen-blkback/common.h
> +++ b/drivers/block/xen-blkback/common.h
> @@ -158,8 +158,8 @@ struct xen_vbd {
>  	struct block_device	*bdev;
>  	/* Cached size parameter. */
>  	sector_t		size;
> -	bool			flush_support;
> -	bool			discard_secure;
> +	unsigned int		flush_support:1;
> +	unsigned int		discard_secure:1;
>  };
>  
>  struct backend_info;
> -- 
> 1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-21 13:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-21  9:04 [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool Oliver Chick
2012-09-21 13:36 ` Konrad Rzeszutek Wilk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).