From: Khalid Aziz <khalid.aziz@hp.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Matthew Garrett <mjg@redhat.com>,
hpa@zytor.com, keescook@chromium.org, tony.luck@intel.com,
Greg KH <gregkh@linuxfoundation.org>,
cbouatmailru@gmail.com, ccross@android.com,
paul.gortmaker@windriver.com, maxin.john@gmail.com,
matt.fleming@intel.com, olof@lixom.net, dhowells@redhat.com,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
khalid@gonehiking.org
Subject: Re: [PATCH -next v2] Shorten constant names for EFI variable attributes
Date: Tue, 25 Sep 2012 17:06:32 -0600 [thread overview]
Message-ID: <1348614392.17507.5.camel@concerto.americas.hpqcorp.net> (raw)
In-Reply-To: <20120926075528.e497436227403ecaf1b845d3@canb.auug.org.au>
On Wed, 2012-09-26 at 07:55 +1000, Stephen Rothwell wrote:
> Hi,
>
> On Tue, 25 Sep 2012 09:41:00 -0600 Khalid Aziz <khalid.aziz@hp.com> wrote:
> >
> > Replace very long constants for EFI variable attributes with
> > shorter and more convenient names. Also create an alias for
> > the current longer names so as to not break compatibility
> > with current API since these constants are used by
> > userspace programs.
>
> Why do this? It just looks like churn for no real gain.
>
This is for code cleanup and does not impact functionality. This is
based upon an earlier discussion -
<https://lkml.org/lkml/2012/7/13/320>. The goal is to make the code more
readable. V1 of this patch was discussed at
<https://lkml.org/lkml/2012/7/20/414>.
--
Khalid Aziz <khalid.aziz@hp.com>
next prev parent reply other threads:[~2012-09-25 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 22:08 [PATCH] Shorten constant names for EFI variable attributes Khalid Aziz
2012-07-20 22:10 ` H. Peter Anvin
2012-07-20 22:30 ` Khalid Aziz
2012-07-20 22:34 ` H. Peter Anvin
2012-07-20 22:46 ` Khalid Aziz
2012-07-23 13:26 ` Matthew Garrett
2012-07-26 17:28 ` Khalid Aziz
2012-07-26 17:33 ` Matthew Garrett
2012-09-25 15:41 ` [PATCH -next v2] " Khalid Aziz
2012-09-25 21:55 ` Stephen Rothwell
2012-09-25 23:06 ` Khalid Aziz [this message]
2012-09-25 23:12 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348614392.17507.5.camel@concerto.americas.hpqcorp.net \
--to=khalid.aziz@hp.com \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=maxin.john@gmail.com \
--cc=mjg@redhat.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).