From: Khalid Aziz <khalid.aziz@hp.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
mikew@google.com, tony.luck@intel.com, keescook@chromium.org,
gong.chen@linux.intel.com, gregkh@suse.de,
paul.gortmaker@windriver.com, maxin.john@gmail.com,
rdunlap@xenotime.net, matt.fleming@intel.com, olof@lixom.net,
dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shorten constant names for EFI variable attributes
Date: Thu, 26 Jul 2012 11:28:32 -0600 [thread overview]
Message-ID: <50117E40.8090904@hp.com> (raw)
In-Reply-To: <20120723132656.GC21495@srcf.ucam.org>
On 07/23/2012 07:26 AM, Matthew Garrett wrote:
> On Fri, Jul 20, 2012 at 03:10:56PM -0700, H. Peter Anvin wrote:
>> On 07/20/2012 03:08 PM, Khalid Aziz wrote:
>>> Replace very long constants for EFI variable attributes
>>> with shorter and more convenient names. Also create an
>>> alias for the current longer names so as to not break
>>> compatibility with current API since these constants
>>> are used by userspace programs. This patch depends on
>>> patch <https://lkml.org/lkml/2012/7/13/313>.
>> I think these some from the EFI specifcation, so NAK IMO.
> From the point of view of making efivars more readable, I'd certainly
> prefer shorter constant names. Keeping an alias is necessary only
> because it's an existing exposed interface. The specification doesn't
> actually require the use of these specific names anywhere, and we've
> taken a more relaxed attitude in other bits of the EFI code.
>
Matthew,
I also do not believe that kernel must use the constant names mentioned
in the specification especially when the name reaches 50 characters. We
can not get away from having to create aliases. Do you think having
aliases in efi.h can cause mixed use of long names and short names in
future code in the kernel? Can we address this by suggesting to future
code authors that they should use the short names in their code? Should
we consider inclusion of this patch in the kernel?
--
Khalid Aziz
khalid.aziz@hp.com
next prev parent reply other threads:[~2012-07-26 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 22:08 [PATCH] Shorten constant names for EFI variable attributes Khalid Aziz
2012-07-20 22:10 ` H. Peter Anvin
2012-07-20 22:30 ` Khalid Aziz
2012-07-20 22:34 ` H. Peter Anvin
2012-07-20 22:46 ` Khalid Aziz
2012-07-23 13:26 ` Matthew Garrett
2012-07-26 17:28 ` Khalid Aziz [this message]
2012-07-26 17:33 ` Matthew Garrett
2012-09-25 15:41 ` [PATCH -next v2] " Khalid Aziz
2012-09-25 21:55 ` Stephen Rothwell
2012-09-25 23:06 ` Khalid Aziz
2012-09-25 23:12 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50117E40.8090904@hp.com \
--to=khalid.aziz@hp.com \
--cc=dhowells@redhat.com \
--cc=gong.chen@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=maxin.john@gmail.com \
--cc=mikew@google.com \
--cc=mjg@redhat.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).