* [PATCH] perf/x86: Fix typo in uncore_pmu_to_box
@ 2012-09-27 1:33 Yan, Zheng
2012-09-27 7:38 ` [tip:perf/urgent] " tip-bot for Yan, Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Yan, Zheng @ 2012-09-27 1:33 UTC (permalink / raw)
To: eranian, a.p.zijlstra, mingo, linux-kernel; +Cc: Yan, Zheng
From: "Yan, Zheng" <zheng.z.yan@intel.com>
the variable box should not be declared as static
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index db917ec..99d96a4 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -1950,7 +1950,7 @@ struct intel_uncore_box *uncore_alloc_box(struct intel_uncore_type *type, int cp
static struct intel_uncore_box *
uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu)
{
- static struct intel_uncore_box *box;
+ struct intel_uncore_box *box;
box = *per_cpu_ptr(pmu->box, cpu);
if (box)
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf/x86: Fix typo in uncore_pmu_to_box
2012-09-27 1:33 [PATCH] perf/x86: Fix typo in uncore_pmu_to_box Yan, Zheng
@ 2012-09-27 7:38 ` tip-bot for Yan, Zheng
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Yan, Zheng @ 2012-09-27 7:38 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, zheng.z.yan, tglx
Commit-ID: 402537fd9f5499d1a50a6f20cdd9031d24ee2e47
Gitweb: http://git.kernel.org/tip/402537fd9f5499d1a50a6f20cdd9031d24ee2e47
Author: Yan, Zheng <zheng.z.yan@intel.com>
AuthorDate: Thu, 27 Sep 2012 09:33:26 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 27 Sep 2012 08:05:13 +0200
perf/x86: Fix typo in uncore_pmu_to_box
The variable box should not be declared as static.
This could probably cause crashes with sufficiently parallel
uncore PMU use.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Cc: eranian@google.com
Cc: a.p.zijlstra@chello.nl
Link: http://lkml.kernel.org/r/1348709606-2759-1-git-send-email-zheng.z.yan@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index 38e4894..c7c55e7 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -1950,7 +1950,7 @@ struct intel_uncore_box *uncore_alloc_box(struct intel_uncore_type *type, int cp
static struct intel_uncore_box *
uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu)
{
- static struct intel_uncore_box *box;
+ struct intel_uncore_box *box;
box = *per_cpu_ptr(pmu->box, cpu);
if (box)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-27 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-27 1:33 [PATCH] perf/x86: Fix typo in uncore_pmu_to_box Yan, Zheng
2012-09-27 7:38 ` [tip:perf/urgent] " tip-bot for Yan, Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).