* [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables
@ 2012-09-27 2:36 Hyeoncheol Lee
2012-09-27 9:08 ` Masami Hiramatsu
2012-09-28 16:39 ` [tip:perf/core] perf probe: Print an enum type variable in " enum " tip-bot for Hyeoncheol Lee
0 siblings, 2 replies; 3+ messages in thread
From: Hyeoncheol Lee @ 2012-09-27 2:36 UTC (permalink / raw)
To: acme; +Cc: LKML, Masami Hiramatsu
When showing accessible variables, an enum type variable was
printed in "variable-name" format. Change this format into
"enum variable-name".
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
---
tools/perf/util/dwarf-aux.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
index ee51e9b..3e5f543 100644
--- a/tools/perf/util/dwarf-aux.c
+++ b/tools/perf/util/dwarf-aux.c
@@ -804,6 +804,8 @@ int die_get_typename(Dwarf_Die *vr_die, char *buf, int len)
tmp = "union ";
else if (tag == DW_TAG_structure_type)
tmp = "struct ";
+ else if (tag == DW_TAG_enumeration_type)
+ tmp = "enum ";
/* Write a base name */
ret = snprintf(buf, len, "%s%s", tmp, dwarf_diename(&type));
return (ret >= len) ? -E2BIG : ret;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables
2012-09-27 2:36 [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables Hyeoncheol Lee
@ 2012-09-27 9:08 ` Masami Hiramatsu
2012-09-28 16:39 ` [tip:perf/core] perf probe: Print an enum type variable in " enum " tip-bot for Hyeoncheol Lee
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2012-09-27 9:08 UTC (permalink / raw)
To: Hyeoncheol Lee; +Cc: acme, LKML, yrl.pp-manager.tt
(2012/09/27 11:36), Hyeoncheol Lee wrote:
> When showing accessible variables, an enum type variable was
> printed in "variable-name" format. Change this format into
> "enum variable-name".
Right, and even if the enum has a type name, it shows
only "type-name variable-name", this should show
"enum type-name variable-name".
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thank you!
>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
> ---
> tools/perf/util/dwarf-aux.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
> index ee51e9b..3e5f543 100644
> --- a/tools/perf/util/dwarf-aux.c
> +++ b/tools/perf/util/dwarf-aux.c
> @@ -804,6 +804,8 @@ int die_get_typename(Dwarf_Die *vr_die, char *buf, int len)
> tmp = "union ";
> else if (tag == DW_TAG_structure_type)
> tmp = "struct ";
> + else if (tag == DW_TAG_enumeration_type)
> + tmp = "enum ";
> /* Write a base name */
> ret = snprintf(buf, len, "%s%s", tmp, dwarf_diename(&type));
> return (ret >= len) ? -E2BIG : ret;
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf probe: Print an enum type variable in " enum variable-name" format when showing accessible variables
2012-09-27 2:36 [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables Hyeoncheol Lee
2012-09-27 9:08 ` Masami Hiramatsu
@ 2012-09-28 16:39 ` tip-bot for Hyeoncheol Lee
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Hyeoncheol Lee @ 2012-09-28 16:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, hpa, mingo, masami.hiramatsu.pt, hyc.lee, tglx
Commit-ID: bb2d17a014914b628df42b0c76c85fa8a8c57e79
Gitweb: http://git.kernel.org/tip/bb2d17a014914b628df42b0c76c85fa8a8c57e79
Author: Hyeoncheol Lee <hyc.lee@gmail.com>
AuthorDate: Thu, 27 Sep 2012 11:36:39 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 27 Sep 2012 10:58:57 -0300
perf probe: Print an enum type variable in "enum variable-name" format when showing accessible variables
When showing accessible variables, an enum type variable was printed in
"variable-name" format. Change this format into "enum variable-name".
Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/1348713399-4541-1-git-send-email-hyc.lee@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/dwarf-aux.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
index ee51e9b..3e5f543 100644
--- a/tools/perf/util/dwarf-aux.c
+++ b/tools/perf/util/dwarf-aux.c
@@ -804,6 +804,8 @@ int die_get_typename(Dwarf_Die *vr_die, char *buf, int len)
tmp = "union ";
else if (tag == DW_TAG_structure_type)
tmp = "struct ";
+ else if (tag == DW_TAG_enumeration_type)
+ tmp = "enum ";
/* Write a base name */
ret = snprintf(buf, len, "%s%s", tmp, dwarf_diename(&type));
return (ret >= len) ? -E2BIG : ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-28 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-27 2:36 [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables Hyeoncheol Lee
2012-09-27 9:08 ` Masami Hiramatsu
2012-09-28 16:39 ` [tip:perf/core] perf probe: Print an enum type variable in " enum " tip-bot for Hyeoncheol Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).