linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jerome Oufella <jerome.oufella@savoirfairelinux.com>
Subject: Re: [PATCH] gpio: add TS-5500 DIO headers support
Date: Thu, 04 Oct 2012 19:18:29 -0400	[thread overview]
Message-ID: <1349392709.5198.2.camel@trivette> (raw)
In-Reply-To: <1348673827.2566.17.camel@trivette>

Hi,

Grant, Linus, any feedback?

Thanks,
Vivien

On Wed, 2012-09-26 at 11:37 -0400, Vivien Didelot wrote:
> > +config GPIO_TS5500
> > +     tristate "TS-5500 DIO Headers"
> > +     depends on TS5500
> > +     help
> > +       This driver supports the 3 Digital I/O headers of the
> Technologic
> > +       Systems TS-5500 platform: DIO1, DIO2, and the LCD port which
> may be
> > +       used as a DIO header.
> 
> I moved the GPIO_TS5500 entry at the good place in the "Memory mapped
> GPIO drivers" section. But I'm still worried about select/depends on.
> I removed the TS5500 symbol dependency, which is not defined yet (will
> be done in the future board support patch). Does the following entry
> seem good?
> 
>     config GPIO_TS5500
>             tristate "TS-5500 DIO Headers support"
>             help
>               This driver supports the 3 Digital I/O headers of the
>               Technologic Systems TS-5500 platform: DIO1, DIO2, and
> the
>               LCD port which may be used as a DIO header.
> 
> Regards,
> Vivien 


  reply	other threads:[~2012-10-04 23:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  0:42 [PATCH] gpio: add TS-5500 DIO headers support Vivien Didelot
2012-09-26 15:37 ` Vivien Didelot
2012-10-04 23:18   ` Vivien Didelot [this message]
2012-10-08  6:24     ` Linus Walleij
2012-10-08 10:38 ` Linus Walleij
2012-10-08 18:20   ` Vivien Didelot
2012-10-12 20:53     ` Linus Walleij
2012-10-12 22:04       ` Vivien Didelot
2012-10-12 22:17         ` Linus Walleij
2012-12-06  3:49       ` Vivien Didelot
2012-12-06 19:25         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349392709.5198.2.camel@trivette \
    --to=vivien.didelot@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jerome.oufella@savoirfairelinux.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).