From: Linus Walleij <linus.walleij@linaro.org>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Jerome Oufella <jerome.oufella@savoirfairelinux.com>
Subject: Re: [PATCH] gpio: add TS-5500 DIO headers support
Date: Thu, 6 Dec 2012 20:25:04 +0100 [thread overview]
Message-ID: <CACRpkdYZXvjwcu3=7=KY6gd8b7dY7hPE=KGPMXpPELLym3A_gw@mail.gmail.com> (raw)
In-Reply-To: <1354765784.12428.3.camel@trivette.home.lan>
On Thu, Dec 6, 2012 at 4:49 AM, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:
> I looked at some drivers and if I'm not mistaken, this case is
> different. Technologic Systems platforms (such as the TS-5500) have
> several pin blocks. Each block has input-only, input-output or
> output-only pins. Only one pin per block is connected to an interrupt
> line. But sadly, these interrupt-connected lines are input only.
> Here are the details about the TS-5500 pin block "DIO1":
>
> http://wiki.embeddedarm.com/wiki/TS-5500#DIO1_Header
Aha I get it now. How odd ... OK we need to support this too.
> That's why I previously used a dio1_irq platform data field, to return
> the interrupt connected to the IRQ-able pin for any GPIO on DIO1, in the
> gpio_to_irq() implementation.
OK I get it.
> A Linux IRQ per pin doesn't seem to be possible because the
> irq_create_mapping() documentation says that "Only one mapping per
> hardware interrupt is permitted." Should I still implement the
> irq_chip/irqdomain for a single IRQ per block? For each pin?
> What do you think about this implementation?
So basically there are in total three pins and yeah this is too
little and too strange to warrant an irqdomain so go ahead
with it as it looks and fix the other comments. I'm happy with
keeping this now.
Linus Walleij
prev parent reply other threads:[~2012-12-06 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 0:42 [PATCH] gpio: add TS-5500 DIO headers support Vivien Didelot
2012-09-26 15:37 ` Vivien Didelot
2012-10-04 23:18 ` Vivien Didelot
2012-10-08 6:24 ` Linus Walleij
2012-10-08 10:38 ` Linus Walleij
2012-10-08 18:20 ` Vivien Didelot
2012-10-12 20:53 ` Linus Walleij
2012-10-12 22:04 ` Vivien Didelot
2012-10-12 22:17 ` Linus Walleij
2012-12-06 3:49 ` Vivien Didelot
2012-12-06 19:25 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYZXvjwcu3=7=KY6gd8b7dY7hPE=KGPMXpPELLym3A_gw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jerome.oufella@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).