* [PATCH] time/jiffies: Make clocksource_jiffies static
@ 2012-10-18 9:34 Lars-Peter Clausen
2012-11-13 19:06 ` John Stultz
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2012-10-18 9:34 UTC (permalink / raw)
To: John Stultz, Thomas Gleixner; +Cc: linux-kernel, Lars-Peter Clausen
Commit f1b8274 ("clocksource: Cleanup clocksource selection") removed all
external references to clocksource_jiffies so there is no need to have the
symbol globally visible.
Fixes the following sparse warning:
CHECK kernel/time/jiffies.c kernel/time/jiffies.c:61:20: warning: symbol 'clocksource_jiffies' was not declared. Should it be static?
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
kernel/time/jiffies.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index 6629bf7..25f5b26 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -58,7 +58,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
return (cycle_t) jiffies;
}
-struct clocksource clocksource_jiffies = {
+static struct clocksource clocksource_jiffies = {
.name = "jiffies",
.rating = 1, /* lowest valid rating*/
.read = jiffies_read,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] time/jiffies: Make clocksource_jiffies static
2012-10-18 9:34 [PATCH] time/jiffies: Make clocksource_jiffies static Lars-Peter Clausen
@ 2012-11-13 19:06 ` John Stultz
0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2012-11-13 19:06 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Thomas Gleixner, linux-kernel
On 10/18/2012 02:34 AM, Lars-Peter Clausen wrote:
> Commit f1b8274 ("clocksource: Cleanup clocksource selection") removed all
> external references to clocksource_jiffies so there is no need to have the
> symbol globally visible.
>
> Fixes the following sparse warning:
> CHECK kernel/time/jiffies.c kernel/time/jiffies.c:61:20: warning: symbol 'clocksource_jiffies' was not declared. Should it be static?
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied. Thanks!
-john
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-13 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-18 9:34 [PATCH] time/jiffies: Make clocksource_jiffies static Lars-Peter Clausen
2012-11-13 19:06 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).