* [PATCH] linux/kernel.h: remove duplicate trace_printk declaration
@ 2012-10-25 13:41 Michal Hocko
2012-11-14 6:51 ` [tip:perf/core] linux/kernel.h: Remove " tip-bot for Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Michal Hocko @ 2012-10-25 13:41 UTC (permalink / raw)
To: linux-kernel
Cc: Steven Rostedt, Frederic Weisbecker, Ingo Molnar, Joe Perches
!CONFIG_TRACING both declares and defines (empty) trace_printk.
The first one is not redundant so it can be removed.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
---
include/linux/kernel.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 594b419..c56e425 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -535,9 +535,6 @@ __ftrace_vprintk(unsigned long ip, const char *fmt, va_list ap);
extern void ftrace_dump(enum ftrace_dump_mode oops_dump_mode);
#else
-static inline __printf(1, 2)
-int trace_printk(const char *fmt, ...);
-
static inline void tracing_start(void) { }
static inline void tracing_stop(void) { }
static inline void ftrace_off_permanent(void) { }
@@ -547,8 +544,8 @@ static inline void tracing_on(void) { }
static inline void tracing_off(void) { }
static inline int tracing_is_on(void) { return 0; }
-static inline int
-trace_printk(const char *fmt, ...)
+static inline __printf(1, 2)
+int trace_printk(const char *fmt, ...)
{
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/core] linux/kernel.h: Remove duplicate trace_printk declaration
2012-10-25 13:41 [PATCH] linux/kernel.h: remove duplicate trace_printk declaration Michal Hocko
@ 2012-11-14 6:51 ` tip-bot for Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Michal Hocko @ 2012-11-14 6:51 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rostedt, tglx, mhocko
Commit-ID: 60efc15ae96c7aace8060411b0d5add20e1ab21e
Gitweb: http://git.kernel.org/tip/60efc15ae96c7aace8060411b0d5add20e1ab21e
Author: Michal Hocko <mhocko@suse.cz>
AuthorDate: Thu, 25 Oct 2012 15:41:51 +0200
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Wed, 31 Oct 2012 16:46:37 -0400
linux/kernel.h: Remove duplicate trace_printk declaration
!CONFIG_TRACING both declares and defines (empty) trace_printk.
The first one is not redundant so it can be removed.
Link: http://lkml.kernel.org/r/1351172511-18125-1-git-send-email-mhocko@suse.cz
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/linux/kernel.h | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index a123b13..7785d5d 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -527,9 +527,6 @@ __ftrace_vprintk(unsigned long ip, const char *fmt, va_list ap);
extern void ftrace_dump(enum ftrace_dump_mode oops_dump_mode);
#else
-static inline __printf(1, 2)
-int trace_printk(const char *fmt, ...);
-
static inline void tracing_start(void) { }
static inline void tracing_stop(void) { }
static inline void ftrace_off_permanent(void) { }
@@ -539,8 +536,8 @@ static inline void tracing_on(void) { }
static inline void tracing_off(void) { }
static inline int tracing_is_on(void) { return 0; }
-static inline int
-trace_printk(const char *fmt, ...)
+static inline __printf(1, 2)
+int trace_printk(const char *fmt, ...)
{
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-14 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-25 13:41 [PATCH] linux/kernel.h: remove duplicate trace_printk declaration Michal Hocko
2012-11-14 6:51 ` [tip:perf/core] linux/kernel.h: Remove " tip-bot for Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).