From: Jeff Moyer <jmoyer@redhat.com>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: Bart Van Assche <bvanassche@acm.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node
Date: Fri, 9 Nov 2012 14:18:01 -0500 [thread overview]
Message-ID: <1352488687-19935-5-git-send-email-jmoyer@redhat.com> (raw)
In-Reply-To: <1352488687-19935-1-git-send-email-jmoyer@redhat.com>
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
---
drivers/scsi/scsi.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 2936b44..1750702 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -173,16 +173,19 @@ static DEFINE_MUTEX(host_cmd_pool_mutex);
* NULL on failure
*/
static struct scsi_cmnd *
-scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask)
+scsi_pool_alloc_command(struct scsi_host_cmd_pool *pool, gfp_t gfp_mask,
+ int node)
{
struct scsi_cmnd *cmd;
- cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask);
+ cmd = kmem_cache_alloc_node(pool->cmd_slab,
+ gfp_mask | pool->gfp_mask | __GFP_ZERO,
+ node);
if (!cmd)
return NULL;
- cmd->sense_buffer = kmem_cache_alloc(pool->sense_slab,
- gfp_mask | pool->gfp_mask);
+ cmd->sense_buffer = kmem_cache_alloc_node(pool->sense_slab,
+ gfp_mask | pool->gfp_mask, node);
if (!cmd->sense_buffer) {
kmem_cache_free(pool->cmd_slab, cmd);
return NULL;
@@ -223,7 +226,8 @@ scsi_host_alloc_command(struct Scsi_Host *shost, gfp_t gfp_mask)
{
struct scsi_cmnd *cmd;
- cmd = scsi_pool_alloc_command(shost->cmd_pool, gfp_mask);
+ cmd = scsi_pool_alloc_command(shost->cmd_pool, gfp_mask,
+ scsi_host_get_numa_node(shost));
if (!cmd)
return NULL;
@@ -435,7 +439,7 @@ struct scsi_cmnd *scsi_allocate_command(gfp_t gfp_mask)
if (!pool)
return NULL;
- return scsi_pool_alloc_command(pool, gfp_mask);
+ return scsi_pool_alloc_command(pool, gfp_mask, NUMA_NO_NODE);
}
EXPORT_SYMBOL(scsi_allocate_command);
--
1.7.1
next prev parent reply other threads:[~2012-11-09 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 19:17 [patch,v3 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-11-09 19:17 ` [patch,v3 01/10] scsi: add scsi_host_alloc_node Jeff Moyer
2012-11-09 19:17 ` [patch,v3 02/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-09 19:18 ` [patch,v3 03/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-11-09 19:18 ` Jeff Moyer [this message]
2012-11-10 8:59 ` [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node Bart Van Assche
2012-11-12 14:25 ` Jeff Moyer
2012-11-09 19:18 ` [patch,v3 05/10] sd: use alloc_disk_node Jeff Moyer
2012-11-09 19:18 ` [patch,v3 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-11-16 4:33 ` Jeff Garzik
2012-11-09 19:18 ` [patch,v3 07/10] megaraid_sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 08/10] mpt2sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 09/10] lpfc: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 10/10] cciss: use blk_init_queue_node Jeff Moyer
2012-11-16 8:08 ` [patch,v3 00/10] make I/O path allocations more numa-friendly Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352488687-19935-5-git-send-email-jmoyer@redhat.com \
--to=jmoyer@redhat.com \
--cc=JBottomley@parallels.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).