From: Jeff Moyer <jmoyer@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node
Date: Mon, 12 Nov 2012 09:25:05 -0500 [thread overview]
Message-ID: <x49zk2mkif2.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <509E178B.6090601@acm.org> (Bart Van Assche's message of "Sat, 10 Nov 2012 09:59:55 +0100")
Bart Van Assche <bvanassche@acm.org> writes:
> On 11/09/12 20:18, Jeff Moyer wrote:
>> - cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask);
>> + cmd = kmem_cache_alloc_node(pool->cmd_slab,
>> + gfp_mask | pool->gfp_mask | __GFP_ZERO,
>> + node);
>
> Hello Jeff,
>
> Is it necessary to add __GFP_ZERO here ? And if so, why ?
Hi, Bart,
The code used to do zeroing, so I just kept that aspect the same. There
is no kmem_cache_zalloc_node, and it didn't seem worth adding one.
Cheers,
Jeff
next prev parent reply other threads:[~2012-11-12 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 19:17 [patch,v3 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-11-09 19:17 ` [patch,v3 01/10] scsi: add scsi_host_alloc_node Jeff Moyer
2012-11-09 19:17 ` [patch,v3 02/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-09 19:18 ` [patch,v3 03/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-11-09 19:18 ` [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node Jeff Moyer
2012-11-10 8:59 ` Bart Van Assche
2012-11-12 14:25 ` Jeff Moyer [this message]
2012-11-09 19:18 ` [patch,v3 05/10] sd: use alloc_disk_node Jeff Moyer
2012-11-09 19:18 ` [patch,v3 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-11-16 4:33 ` Jeff Garzik
2012-11-09 19:18 ` [patch,v3 07/10] megaraid_sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 08/10] mpt2sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 09/10] lpfc: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 10/10] cciss: use blk_init_queue_node Jeff Moyer
2012-11-16 8:08 ` [patch,v3 00/10] make I/O path allocations more numa-friendly Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zk2mkif2.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=JBottomley@parallels.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).