linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: "Philip, Avinash" <avinashphilip@ti.com>, ivan.djelic@parrot.com
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	"Mohammed, Afzal" <afzal@ti.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"broonie@opensource.wolfsonmicro.com" 
	<broonie@opensource.wolfsonmicro.com>,
	"rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org" 
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Nori, Sekhar" <nsekhar@ti.com>,
	"Hebbar, Gururaja" <gururaja.hebbar@ti.com>,
	"ivan.djelic@parrot.com" <ivan.djelic@parrot.com>
Subject: Re: [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc
Date: Thu, 22 Nov 2012 12:43:52 +0200	[thread overview]
Message-ID: <1353581032.2701.34.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <518397C60809E147AF5323E0420B992E3E9EC70D@DBDE01.ent.ti.com>

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Wed, 2012-11-21 at 07:01 +0000, Philip, Avinash wrote:
> > I am not sure how this dependency has to be handled for this series,
> > let me know whether you still want it to be made over l2-mtd?
> 
> Artem,
> 
> Is it possible for you to give ack for these patches so that these patches
> can go in Tony's tree where Omap-gpmc changes are present?

I would prefer if people like Ivan could take a look at this first.

Also, I am not sure this is a good idea. Or at least we should agree on
some common strategy for bit-flips in the erased areas:

"+ * 1. If page is erased, check with standard ecc vector (ecc vector
+ * for erased page to find any bit flip). If check fails, bit flip
+ * is present in erased page. Count the bit flips in erased page and
+ * if it falls under correctable level, report page with 0xFF and
+ * update the correctable bit information."

Basically, you are working-around JFFS2 limitations.

Do you suggest we do this in all the drivers?

If we want to do this, may be we better do this in higher level, common
to all drivers?

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-11-22 19:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31  7:08 [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Philip, Avinash
2012-10-31  7:08 ` [PATCH v2 1/3] mtd: nand: omap2: Update nerrors using ecc.strength Philip, Avinash
2012-10-31  7:08 ` [PATCH v2 2/3] mtd: devices: elm: Add support for ELM error correction Philip, Avinash
2012-10-31  7:08 ` [PATCH v2 3/3] mtd: nand: omap2: Support for hardware BCH " Philip, Avinash
2012-11-30 12:28   ` Artem Bityutskiy
2012-12-04 13:16     ` Philip, Avinash
2012-11-15 11:22 ` [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Artem Bityutskiy
2012-11-19 12:44   ` Philip, Avinash
2012-11-21  7:01   ` Philip, Avinash
2012-11-22 10:43     ` Artem Bityutskiy [this message]
2012-11-22 14:37       ` Philip, Avinash
2012-11-30 12:28         ` Artem Bityutskiy
2012-12-04 13:20           ` Philip, Avinash
2012-11-27  9:07       ` Philip, Avinash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353581032.2701.34.camel@sauron.fi.intel.com \
    --to=artem.bityutskiy@linux.intel.com \
    --cc=afzal@ti.com \
    --cc=avinashphilip@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gururaja.hebbar@ti.com \
    --cc=ivan.djelic@parrot.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nsekhar@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).