From: "Philip, Avinash" <avinashphilip@ti.com>
To: "artem.bityutskiy@linux.intel.com" <artem.bityutskiy@linux.intel.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"Mohammed, Afzal" <afzal@ti.com>,
"tony@atomide.com" <tony@atomide.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Nori, Sekhar" <nsekhar@ti.com>,
"Hebbar, Gururaja" <gururaja.hebbar@ti.com>,
"ivan.djelic@parrot.com" <ivan.djelic@parrot.com>
Subject: RE: [PATCH v2 3/3] mtd: nand: omap2: Support for hardware BCH error correction
Date: Tue, 4 Dec 2012 13:16:27 +0000 [thread overview]
Message-ID: <518397C60809E147AF5323E0420B992E3EA108A9@DBDE01.ent.ti.com> (raw)
In-Reply-To: <1354278480.30168.116.camel@sauron.fi.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1149 bytes --]
On Fri, Nov 30, 2012 at 17:58:00, Artem Bityutskiy wrote:
> On Wed, 2012-10-31 at 12:38 +0530, Philip, Avinash wrote:
> > +static int erased_sector_bitflips(u_char *data, u_char *oob,
> > + struct omap_nand_info *info)
> > +{
> > + int flip_bits = 0, i;
> > +
> > + for (i = 0; i < info->nand.ecc.size; i++) {
> > + flip_bits += hweight8(~data[i]);
> > + if (flip_bits > info->nand.ecc.strength)
> > + return 0;
> > + }
> > +
> > + for (i = 0; i < info->nand.ecc.bytes - 1; i++) {
> > + flip_bits += hweight8(~oob[i]);
> > + if (flip_bits > info->nand.ecc.strength)
> > + return 0;
> > + }
>
> Why do you need the second for loop?
BCH ecc is self protected & can correct bit flips in ecc bytes.
So here checking bit flips in read_ecc. I will rename variable
"oob" to "read_ecc"
Thanks
Avinash
>
> --
> Best Regards,
> Artem Bityutskiy
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2012-12-04 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 7:08 [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Philip, Avinash
2012-10-31 7:08 ` [PATCH v2 1/3] mtd: nand: omap2: Update nerrors using ecc.strength Philip, Avinash
2012-10-31 7:08 ` [PATCH v2 2/3] mtd: devices: elm: Add support for ELM error correction Philip, Avinash
2012-10-31 7:08 ` [PATCH v2 3/3] mtd: nand: omap2: Support for hardware BCH " Philip, Avinash
2012-11-30 12:28 ` Artem Bityutskiy
2012-12-04 13:16 ` Philip, Avinash [this message]
2012-11-15 11:22 ` [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Artem Bityutskiy
2012-11-19 12:44 ` Philip, Avinash
2012-11-21 7:01 ` Philip, Avinash
2012-11-22 10:43 ` Artem Bityutskiy
2012-11-22 14:37 ` Philip, Avinash
2012-11-30 12:28 ` Artem Bityutskiy
2012-12-04 13:20 ` Philip, Avinash
2012-11-27 9:07 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518397C60809E147AF5323E0420B992E3EA108A9@DBDE01.ent.ti.com \
--to=avinashphilip@ti.com \
--cc=afzal@ti.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=gururaja.hebbar@ti.com \
--cc=ivan.djelic@parrot.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nsekhar@ti.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).