* [PATCH] irqdomain: document the simple domain first_irq
@ 2013-01-07 0:18 Linus Walleij
2013-01-14 13:50 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2013-01-07 0:18 UTC (permalink / raw)
To: linux-kernel, Grant Likely, Rob Herring, Thomas Gleixner
Cc: Anmar Oueja, Linus Walleij
From: Linus Walleij <linus.walleij@linaro.org>
The first_irq needs to be zero to get a linear domain and that
comes with special semantics. We want to simplify this going
forward but some documentation never hurts.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
kernel/irq/irqdomain.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 96f3a1d..059a280 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -143,7 +143,10 @@ static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain,
* irq_domain_add_simple() - Allocate and register a simple irq_domain.
* @of_node: pointer to interrupt controller's device tree node.
* @size: total number of irqs in mapping
- * @first_irq: first number of irq block assigned to the domain
+ * @first_irq: first number of irq block assigned to the domain,
+ * pass zero to assign irqs on-the-fly. This will result in a
+ * linear IRQ domain so it is important to use irq_create_mapping()
+ * for each used IRQ, especially when SPARSE_IRQ is enabled.
* @ops: map/unmap domain callbacks
* @host_data: Controller private data pointer
*
--
1.7.11.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] irqdomain: document the simple domain first_irq
2013-01-07 0:18 [PATCH] irqdomain: document the simple domain first_irq Linus Walleij
@ 2013-01-14 13:50 ` Grant Likely
0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2013-01-14 13:50 UTC (permalink / raw)
To: Linus Walleij, linux-kernel, Rob Herring, Thomas Gleixner
Cc: Anmar Oueja, Linus Walleij
On Mon, 7 Jan 2013 01:18:32 +0100, Linus Walleij <linus.walleij@stericsson.com> wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The first_irq needs to be zero to get a linear domain and that
> comes with special semantics. We want to simplify this going
> forward but some documentation never hurts.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 96f3a1d..059a280 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -143,7 +143,10 @@ static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain,
> * irq_domain_add_simple() - Allocate and register a simple irq_domain.
> * @of_node: pointer to interrupt controller's device tree node.
> * @size: total number of irqs in mapping
> - * @first_irq: first number of irq block assigned to the domain
> + * @first_irq: first number of irq block assigned to the domain,
> + * pass zero to assign irqs on-the-fly. This will result in a
> + * linear IRQ domain so it is important to use irq_create_mapping()
> + * for each used IRQ, especially when SPARSE_IRQ is enabled.
> * @ops: map/unmap domain callbacks
> * @host_data: Controller private data pointer
> *
> --
> 1.7.11.3
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] irqdomain: document the simple domain first_irq
@ 2013-02-28 9:07 Linus Walleij
2013-05-13 7:43 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2013-02-28 9:07 UTC (permalink / raw)
To: linux-kernel, Grant Likely, Rob Herring, Thomas Gleixner
Cc: Anmar Oueja, Linus Walleij
From: Linus Walleij <linus.walleij@linaro.org>
The first_irq needs to be zero to get a linear domain and that
comes with special semantics. We want to simplify this going
forward but some documentation never hurts.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
kernel/irq/irqdomain.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 96f3a1d..059a280 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -143,7 +143,10 @@ static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain,
* irq_domain_add_simple() - Allocate and register a simple irq_domain.
* @of_node: pointer to interrupt controller's device tree node.
* @size: total number of irqs in mapping
- * @first_irq: first number of irq block assigned to the domain
+ * @first_irq: first number of irq block assigned to the domain,
+ * pass zero to assign irqs on-the-fly. This will result in a
+ * linear IRQ domain so it is important to use irq_create_mapping()
+ * for each used IRQ, especially when SPARSE_IRQ is enabled.
* @ops: map/unmap domain callbacks
* @host_data: Controller private data pointer
*
--
1.7.11.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] irqdomain: document the simple domain first_irq
2013-02-28 9:07 Linus Walleij
@ 2013-05-13 7:43 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-05-13 7:43 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel, Grant Likely, Rob Herring, Thomas Gleixner, Anmar Oueja
On Thu, Feb 28, 2013 at 10:07 AM, Linus Walleij
<linus.walleij@stericsson.com> wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The first_irq needs to be zero to get a linear domain and that
> comes with special semantics. We want to simplify this going
> forward but some documentation never hurts.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Ping on this, seems to have been missed for ~2 months,
should go cleanly into -rc fixes so I do not need to keep this
patch in my tree...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-13 7:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07 0:18 [PATCH] irqdomain: document the simple domain first_irq Linus Walleij
2013-01-14 13:50 ` Grant Likely
2013-02-28 9:07 Linus Walleij
2013-05-13 7:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).