* [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry()
@ 2013-01-22 1:11 Sedat Dilek
0 siblings, 0 replies; only message in thread
From: Sedat Dilek @ 2013-01-22 1:11 UTC (permalink / raw)
To: Dave Kleikamp, Zach Brown, Maxim V. Patlasov, linux-kernel
Cc: Sedat Dilek, Jeff Moyer, Alexander Viro, linux-fsdevel
Dave confirmed Jeff's suspicion in [1]:
> That wants to be rw_op = do_aio_write in the else clause. How did you
> test this patch set?
Yep, that's certainly a bug. I concentrated on testing on loop mounts,
running some fio and ltp testcases, but I'm at a loss to explain how
things seem to work as well as they do. Let's see how where fixing this
leads.
This is a fixup to commit daf0f6142dd5 ("fs: use read_iter and write_iter
rather than aio_read and aio_write") from Dave Kleiklamp's GIT tree in [2].
[1] http://www.spinics.net/lists/linux-fsdevel/msg61587.html
[2] https://github.com/kleikamp/linux-shaggy/commits/loop_2013_01_04
Cc: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index 08f550a..9635e7a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1320,7 +1320,7 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
rw_op = do_aio_read;
opcode = IOCB_CMD_PREADV;
} else {
- rw_op = do_aio_read;
+ rw_op = do_aio_write;
opcode = IOCB_CMD_PWRITEV;
}
--
1.8.1.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-01-22 1:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-22 1:11 [PATCH loop_2013_01_04] fs: Fix a typo in aio_rw_vect_retry() Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).