* [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy
@ 2013-01-22 15:31 Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Vivek Gautam @ 2013-01-22 15:31 UTC (permalink / raw)
To: linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, kgene.kim,
grant.likely, dianders, balbi, thomas.abraham,
sylvester.nawrocki, tomasz.figa, p.paneri
Changes from v1:
- Putting separate device nodes for usb 2.0 phy and usb 3.0 phy
based on separate driver for samsung usb 3.0 phy and
samsung usb 2.0 phy:
[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250
[PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250
- Aligning as per the patch:
usb: phy: samsung: Add support to set pmu isolation
- Replaced phy-handle approach for PHY CONTROL registers
to child nodes.
- Removing AUX data entry from exynos5250 dt file.
Vivek Gautam (2):
ARM: Exynos5250: Enabling samsung-usbphy driver
ARM: Exynos5250: Enabling samsung-usb3-phy driver
arch/arm/boot/dts/exynos5250.dtsi | 28 ++++++++++++++++++++++++++++
1 files changed, 28 insertions(+), 0 deletions(-)
--
1.7.6.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
2013-01-22 15:31 [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
@ 2013-01-22 15:31 ` Vivek Gautam
2013-01-30 5:06 ` Kukjin Kim
2013-01-22 15:31 ` [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver Vivek Gautam
2013-01-29 12:10 ` [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2 siblings, 1 reply; 7+ messages in thread
From: Vivek Gautam @ 2013-01-22 15:31 UTC (permalink / raw)
To: linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, kgene.kim,
grant.likely, dianders, balbi, thomas.abraham,
sylvester.nawrocki, tomasz.figa, p.paneri
Adding usbphy node for Exynos5250 along with the
necessary device data to be parsed.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 30485de..610e338 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -275,6 +275,21 @@
#size-cells = <0>;
};
+ usbphy@12130000 {
+ compatible = "samsung,exynos5250-usbphy";
+ reg = <0x12130000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ usbphy-sys {
+ /* USB device and host PHY_CONTROL registers */
+ reg = <0x10040704 0x8>,
+ /* USB2.0 PHY configuration register */
+ <0x10050230 0x4>;
+ };
+ };
+
amba {
#address-cells = <1>;
#size-cells = <1>;
--
1.7.6.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver
2013-01-22 15:31 [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
@ 2013-01-22 15:31 ` Vivek Gautam
2013-01-30 5:12 ` Kukjin Kim
2013-01-29 12:10 ` [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2 siblings, 1 reply; 7+ messages in thread
From: Vivek Gautam @ 2013-01-22 15:31 UTC (permalink / raw)
To: linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, kgene.kim,
grant.likely, dianders, balbi, thomas.abraham,
sylvester.nawrocki, tomasz.figa, p.paneri
Adding usb3.0 phy node for Exynos5250 along with the
necessary device data to be parsed.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 13 +++++++++++++
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 610e338..018a70d 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -275,6 +275,19 @@
#size-cells = <0>;
};
+ usbphy@12100000 {
+ compatible = "samsung,exynos5250-usb3-phy";
+ reg = <0x12100000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ usbphy-sys {
+ /* USB device and host PHY_CONTROL registers */
+ reg = <0x10040704 0x8>;
+ };
+ };
+
usbphy@12130000 {
compatible = "samsung,exynos5250-usbphy";
reg = <0x12130000 0x100>;
--
1.7.6.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy
2013-01-22 15:31 [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver Vivek Gautam
@ 2013-01-29 12:10 ` Vivek Gautam
2 siblings, 0 replies; 7+ messages in thread
From: Vivek Gautam @ 2013-01-29 12:10 UTC (permalink / raw)
To: linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, kgene.kim,
grant.likely, dianders, balbi, thomas.abraham,
sylvester.nawrocki, tomasz.figa, Vivek Gautam
On Tue, Jan 22, 2013 at 9:01 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Changes from v1:
> - Putting separate device nodes for usb 2.0 phy and usb 3.0 phy
> based on separate driver for samsung usb 3.0 phy and
> samsung usb 2.0 phy:
> [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250
> [PATCH v8 0/4] Adding usb2.0 host-phy support for exynos5250
> - Aligning as per the patch:
> usb: phy: samsung: Add support to set pmu isolation
> - Replaced phy-handle approach for PHY CONTROL registers
> to child nodes.
> - Removing AUX data entry from exynos5250 dt file.
>
> Vivek Gautam (2):
> ARM: Exynos5250: Enabling samsung-usbphy driver
> ARM: Exynos5250: Enabling samsung-usb3-phy driver
>
any comments on this patch-series please ?
> arch/arm/boot/dts/exynos5250.dtsi | 28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
>
> --
> 1.7.6.5
>
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
2013-01-22 15:31 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
@ 2013-01-30 5:06 ` Kukjin Kim
2013-01-30 8:19 ` Vivek Gautam
0 siblings, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2013-01-30 5:06 UTC (permalink / raw)
To: 'Vivek Gautam', linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, grant.likely,
dianders, balbi, thomas.abraham, sylvester.nawrocki, tomasz.figa,
p.paneri
Vivek Gautam wrote:
>
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 30485de..610e338 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,21 @@
> #size-cells = <0>;
> };
>
> + usbphy@12130000 {
Please put above node by order of address.
> + compatible = "samsung,exynos5250-usbphy";
> + reg = <0x12130000 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers
*/
Please add the binding documentation instead of comment here.
> + reg = <0x10040704 0x8>,
> + /* USB2.0 PHY configuration register */
> + <0x10050230 0x4>;
> + };
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 1.7.6.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver
2013-01-22 15:31 ` [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver Vivek Gautam
@ 2013-01-30 5:12 ` Kukjin Kim
0 siblings, 0 replies; 7+ messages in thread
From: Kukjin Kim @ 2013-01-30 5:12 UTC (permalink / raw)
To: 'Vivek Gautam', linux-samsung-soc
Cc: devicetree-discuss, linux-kernel, linux-usb, grant.likely,
dianders, balbi, thomas.abraham, sylvester.nawrocki, tomasz.figa,
p.paneri
Vivek Gautam wrote:
>
> Adding usb3.0 phy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 610e338..018a70d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,19 @@
> #size-cells = <0>;
> };
>
> + usbphy@12100000 {
> + compatible = "samsung,exynos5250-usb3-phy";
> + reg = <0x12100000 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers
*/
> + reg = <0x10040704 0x8>;
> + };
> + };
> +
> usbphy@12130000 {
> compatible = "samsung,exynos5250-usbphy";
> reg = <0x12130000 0x100>;
> --
> 1.7.6.5
Same as previous comments.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
2013-01-30 5:06 ` Kukjin Kim
@ 2013-01-30 8:19 ` Vivek Gautam
0 siblings, 0 replies; 7+ messages in thread
From: Vivek Gautam @ 2013-01-30 8:19 UTC (permalink / raw)
To: Kukjin Kim
Cc: Vivek Gautam, linux-samsung-soc, p.paneri, devicetree-discuss,
linux-usb, linux-kernel, balbi, sylvester.nawrocki, tomasz.figa
Hi Kukjin,
On Wed, Jan 30, 2013 at 10:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Vivek Gautam wrote:
>>
>> Adding usbphy node for Exynos5250 along with the
>> necessary device data to be parsed.
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++++++
>> 1 files changed, 15 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 30485de..610e338 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -275,6 +275,21 @@
>> #size-cells = <0>;
>> };
>>
>> + usbphy@12130000 {
>
> Please put above node by order of address.
>
Sure will do that. Actually thought the listing was as per IPs.
>> + compatible = "samsung,exynos5250-usbphy";
>> + reg = <0x12130000 0x100>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + usbphy-sys {
>> + /* USB device and host PHY_CONTROL registers
> */
>
> Please add the binding documentation instead of comment here.
>
Bindings documentation already added at
"Documentation/devicetree/bindings/usb/samsung-usbphy.txt"
merged in 'usb-next'.
>> + reg = <0x10040704 0x8>,
>> + /* USB2.0 PHY configuration register */
>> + <0x10050230 0x4>;
>> + };
>> + };
>> +
>> amba {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> --
>> 1.7.6.5
>
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-30 8:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-22 15:31 [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver Vivek Gautam
2013-01-30 5:06 ` Kukjin Kim
2013-01-30 8:19 ` Vivek Gautam
2013-01-22 15:31 ` [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver Vivek Gautam
2013-01-30 5:12 ` Kukjin Kim
2013-01-29 12:10 ` [PATCH v2 0/2] ARM: Exynos5250: Enabling samsung usb phy Vivek Gautam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).