* [PATCH] w1-gpio: fix section mismatch
@ 2013-01-27 20:07 Hauke Mehrtens
2013-01-28 15:31 ` Evgeniy Polyakov
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2013-01-27 20:07 UTC (permalink / raw)
To: gregkh; +Cc: zbr, panto, linux-kernel, devicetree-discuss, Hauke Mehrtens
This fixes the following section mismatch:
WARNING: drivers/w1/masters/w1-gpio.o(.data+0x188): Section mismatch in
reference from the variable w1_gpio_driver to the function
.init.text:w1_gpio_probe()
The variable w1_gpio_driver references
the function __init w1_gpio_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
This patch is based on 3.8-rc5.
drivers/w1/masters/w1-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index 85b363a..d39dfa4 100644
--- a/drivers/w1/masters/w1-gpio.c
+++ b/drivers/w1/masters/w1-gpio.c
@@ -72,7 +72,7 @@ static int w1_gpio_probe_dt(struct platform_device *pdev)
return 0;
}
-static int __init w1_gpio_probe(struct platform_device *pdev)
+static int w1_gpio_probe(struct platform_device *pdev)
{
struct w1_bus_master *master;
struct w1_gpio_platform_data *pdata;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] w1-gpio: fix section mismatch
2013-01-27 20:07 [PATCH] w1-gpio: fix section mismatch Hauke Mehrtens
@ 2013-01-28 15:31 ` Evgeniy Polyakov
0 siblings, 0 replies; 2+ messages in thread
From: Evgeniy Polyakov @ 2013-01-28 15:31 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: gregkh, panto, linux-kernel, devicetree-discuss
Hi
On Sun, Jan 27, 2013 at 09:07:57PM +0100, Hauke Mehrtens (hauke@hauke-m.de) wrote:
> This fixes the following section mismatch:
>
> WARNING: drivers/w1/masters/w1-gpio.o(.data+0x188): Section mismatch in
> reference from the variable w1_gpio_driver to the function
> .init.text:w1_gpio_probe()
> The variable w1_gpio_driver references
> the function __init w1_gpio_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Looks good to me
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-28 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-27 20:07 [PATCH] w1-gpio: fix section mismatch Hauke Mehrtens
2013-01-28 15:31 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).