linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Urlichs <smurf@smurf.noris.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: option: add support for Telit LE920
Date: Tue, 29 Jan 2013 11:19:18 -0600	[thread overview]
Message-ID: <1359479958.1635.8.camel@dcbw.foobar.com> (raw)
In-Reply-To: <1359388030-2821-1-git-send-email-dnlplm@gmail.com>

On Mon, 2013-01-28 at 16:47 +0100, Daniele Palmas wrote:
> From: danielepa <danielepa@L2011.(none)>
> 
> Add PID and special handling for Telit LE920

Any idea what interfaces 1 and 5 are?  Is one perhaps a pseudo-ethernet
interface that could be used instead of PPP?  What's the lsusb -v output
for the device?

Dan

> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> ---
>  drivers/usb/serial/option.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 0d9dac9..384bb92 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -242,6 +242,7 @@ static void option_instat_callback(struct urb *urb);
>  #define TELIT_PRODUCT_CC864_DUAL		0x1005
>  #define TELIT_PRODUCT_CC864_SINGLE		0x1006
>  #define TELIT_PRODUCT_DE910_DUAL		0x1010
> +#define TELIT_PRODUCT_LE920			0x1200
>  
>  /* ZTE PRODUCTS */
>  #define ZTE_VENDOR_ID				0x19d2
> @@ -534,6 +535,11 @@ static const struct option_blacklist_info zte_1255_blacklist = {
>  	.reserved = BIT(3) | BIT(4),
>  };
>  
> +static const struct option_blacklist_info telit_le920_blacklist = {
> +	.sendsetup = BIT(0),
> +	.reserved = BIT(1) | BIT(5),
> +};
> +
>  static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
>  	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
> @@ -784,6 +790,8 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_CC864_DUAL) },
>  	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_CC864_SINGLE) },
>  	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_DE910_DUAL) },
> +	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE920),
> +		.driver_info = (kernel_ulong_t)&telit_le920_blacklist },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MF622, 0xff, 0xff, 0xff) }, /* ZTE WCDMA products */
>  	{ USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0002, 0xff, 0xff, 0xff),
>  		.driver_info = (kernel_ulong_t)&net_intf1_blacklist },



  parent reply	other threads:[~2013-01-29 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 15:47 [PATCH 1/1] USB: option: add support for Telit LE920 Daniele Palmas
2013-01-29 12:00 ` Sergei Shtylyov
2013-01-29 17:19 ` Dan Williams [this message]
2013-01-29 17:26   ` Bjørn Mork
2013-01-30  7:13     ` Daniele Palmas
2013-01-30  8:23       ` Bjørn Mork
2013-01-30  9:23         ` Daniele Palmas
2013-01-29 17:48   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359479958.1635.8.camel@dcbw.foobar.com \
    --to=dcbw@redhat.com \
    --cc=dnlplm@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).