linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: Dan Williams <dcbw@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Urlichs <smurf@smurf.noris.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USB: option: add support for Telit LE920
Date: Wed, 30 Jan 2013 09:23:43 +0100	[thread overview]
Message-ID: <87txpznkog.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAGRyCJFxe4sg_GhimQjTG+jSb8CYJRP3wGcJDEJSq6Uek0Y_iQ@mail.gmail.com> (Daniele Palmas's message of "Wed, 30 Jan 2013 08:13:28 +0100")

Daniele Palmas <dnlplm@gmail.com> writes:

> The output of lsusb for interface #1 is the following:
>
> Interface Descriptor:
>       bLength                 9
>       bDescriptorType         4
>       bInterfaceNumber        1
>       bAlternateSetting       0
>       bNumEndpoints           2
>       bInterfaceClass       255 Vendor Specific Class
>       bInterfaceSubClass     66
>       bInterfaceProtocol      1
>       iInterface              0
>
> It should be an adb device, so probably it is not needed to blacklist
> it. Should I resend a new patch with only interface #5 reserved?

You could have used USB_DEVICE_AND_INTERFACE_INFO() matching on all
ff/ff/ff to avoid blacklisting the adb interface, but IMHO the patch is
fine as it is.

This being an Android device raises another question though: Are these
interface numbers static?  I assume you can e.g. disable adb?  What
happens to the descriptors then?  Does the device change pid, or are the
interfaces renumbered?


Bjørn

  reply	other threads:[~2013-01-30  8:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 15:47 [PATCH 1/1] USB: option: add support for Telit LE920 Daniele Palmas
2013-01-29 12:00 ` Sergei Shtylyov
2013-01-29 17:19 ` Dan Williams
2013-01-29 17:26   ` Bjørn Mork
2013-01-30  7:13     ` Daniele Palmas
2013-01-30  8:23       ` Bjørn Mork [this message]
2013-01-30  9:23         ` Daniele Palmas
2013-01-29 17:48   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txpznkog.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=dcbw@redhat.com \
    --cc=dnlplm@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).