* [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch
@ 2013-02-01 15:43 Greg Kroah-Hartman
2013-02-01 15:48 ` Joe Perches
2013-02-02 10:26 ` Andrew Morton
0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2013-02-01 15:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Konrad Rzeszutek Wilk
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Maintainers have to hand-edit patches (body of patches and changelog
entries) all the time. There needs to be some kind of penalty put into
place to keep developers from abusing maintainers.
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c379a2a..d1bec01 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -93,7 +93,9 @@ includes updates for subsystem X. Please apply."
The maintainer will thank you if you write your patch description in a
form which can be easily pulled into Linux's source code management
-system, git, as a "commit log". See #15, below.
+system, git, as a "commit log". See #15, below. If the maintainer has
+to hand-edit your patch, you owe them the beverage of their choice the
+next time you see them.
If your description starts to get long, that's a sign that you probably
need to split up your patch. See #3, next.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch
2013-02-01 15:43 [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch Greg Kroah-Hartman
@ 2013-02-01 15:48 ` Joe Perches
2013-02-01 21:07 ` Anca Emanuel
2013-02-02 10:26 ` Andrew Morton
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-02-01 15:48 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Konrad Rzeszutek Wilk
On Fri, 2013-02-01 at 16:43 +0100, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Maintainers have to hand-edit patches (body of patches and changelog
> entries) all the time. There needs to be some kind of penalty put into
> place to keep developers from abusing maintainers.
No, there doesn't.
It's funny as a joke, it's not as an actual patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch
2013-02-01 15:48 ` Joe Perches
@ 2013-02-01 21:07 ` Anca Emanuel
2013-02-01 22:10 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Anca Emanuel @ 2013-02-01 21:07 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg Kroah-Hartman, LKML, Konrad Rzeszutek Wilk
Joe, read lkml and decide after that.
I fully apove the pathch.
Reviewed-by: Anca Emanuel <anca.emanuel@gmail.com>
Review-requested-by: Joe Perches <joe@perches.com>
Comments:
You have 3 kernels to maintain as stable, plus drivers, plus etc.
If somebody post something without reading the docs, and you have to
repeat to them the same, again and more, then you MUST give an beer.
On Fri, Feb 1, 2013 at 5:48 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2013-02-01 at 16:43 +0100, Greg Kroah-Hartman wrote:
>> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> Maintainers have to hand-edit patches (body of patches and changelog
>> entries) all the time. There needs to be some kind of penalty put into
>> place to keep developers from abusing maintainers.
>
> No, there doesn't.
>
> It's funny as a joke, it's not as an actual patch.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch
2013-02-01 21:07 ` Anca Emanuel
@ 2013-02-01 22:10 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2013-02-01 22:10 UTC (permalink / raw)
To: Anca Emanuel; +Cc: Joe Perches, Greg Kroah-Hartman, LKML, Konrad Rzeszutek Wilk
On 02/01/13 13:07, Anca Emanuel wrote:
> Joe, read lkml and decide after that.
> I fully apove the pathch.
>
> Reviewed-by: Anca Emanuel <anca.emanuel@gmail.com>
>
> Review-requested-by: Joe Perches <joe@perches.com>
>
>
> Comments:
> You have 3 kernels to maintain as stable, plus drivers, plus etc.
> If somebody post something without reading the docs, and you have to
> repeat to them the same, again and more, then you MUST give an beer.
If someone is a repeat-repeat offender, they should just learn
how to submit patches correctly. I.e., the maintainer should just
keep saying to them, Sorry, please submit your patch correctly
so that I can apply it.
> On Fri, Feb 1, 2013 at 5:48 PM, Joe Perches <joe@perches.com> wrote:
>> On Fri, 2013-02-01 at 16:43 +0100, Greg Kroah-Hartman wrote:
>>> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>> Maintainers have to hand-edit patches (body of patches and changelog
>>> entries) all the time. There needs to be some kind of penalty put into
>>> place to keep developers from abusing maintainers.
>>
>> No, there doesn't.
>>
>> It's funny as a joke, it's not as an actual patch.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch
2013-02-01 15:43 [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch Greg Kroah-Hartman
2013-02-01 15:48 ` Joe Perches
@ 2013-02-02 10:26 ` Andrew Morton
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2013-02-02 10:26 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Konrad Rzeszutek Wilk
On Fri, 1 Feb 2013 16:43:06 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> +to hand-edit your patch, you owe them the beverage of their choice the
"a beverage".
Pilsener, please.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-02 10:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-01 15:43 [PATCH] SubmittingPatches: add penalty for forcing a maintainer to edit a patch Greg Kroah-Hartman
2013-02-01 15:48 ` Joe Perches
2013-02-01 21:07 ` Anca Emanuel
2013-02-01 22:10 ` Randy Dunlap
2013-02-02 10:26 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).