[PATCH] drm/amd/display: Remove the unused variable dppclk_delay_subtotal

[PATCH] drm/amd/display: Remove the unused variable dppclk_delay_subtotal

[Jiapeng Chong]

Variable dppclk_delay_subtotal is not effectively used, so delete it.

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:1004:15: warning: variable 'dppclk_delay_subtotal' set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4584
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 .../display/dc/dml/dcn314/display_rq_dlg_calc_314.c    | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
index 6576b897a512..d1c2693a2e28 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
@@ -1001,7 +1001,6 @@ static void dml_rq_dlg_get_dlg_params(
 	unsigned int vupdate_width;
 	unsigned int vready_offset;
 
-	unsigned int dppclk_delay_subtotal;
 	unsigned int dispclk_delay_subtotal;
 
 	unsigned int vstartup_start;
@@ -1130,17 +1129,8 @@ static void dml_rq_dlg_get_dlg_params(
 	vupdate_offset = dst->vupdate_offset;
 	vupdate_width = dst->vupdate_width;
 	vready_offset = dst->vready_offset;
-
-	dppclk_delay_subtotal = mode_lib->ip.dppclk_delay_subtotal;
 	dispclk_delay_subtotal = mode_lib->ip.dispclk_delay_subtotal;
 
-	if (scl_enable)
-		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl;
-	else
-		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl_lb_only;
-
-	dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_cnvc_formatter + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor;
-
 	if (dout->dsc_enable) {
 		double dsc_delay = get_dsc_delay(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA
 
-- 
2.20.1.7.g153144c

Re: [PATCH] drm/amd/display: Remove the unused variable dppclk_delay_subtotal

[Hamza Mahfooz]

On 3/21/23 21:59, Jiapeng Chong wrote:
> Variable dppclk_delay_subtotal is not effectively used, so delete it.
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:1004:15: warning: variable 'dppclk_delay_subtotal' set but not used.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4584
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks!

> ---
>   .../display/dc/dml/dcn314/display_rq_dlg_calc_314.c    | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index 6576b897a512..d1c2693a2e28 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -1001,7 +1001,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	unsigned int vupdate_width;
>   	unsigned int vready_offset;
>   
> -	unsigned int dppclk_delay_subtotal;
>   	unsigned int dispclk_delay_subtotal;
>   
>   	unsigned int vstartup_start;
> @@ -1130,17 +1129,8 @@ static void dml_rq_dlg_get_dlg_params(
>   	vupdate_offset = dst->vupdate_offset;
>   	vupdate_width = dst->vupdate_width;
>   	vready_offset = dst->vready_offset;
> -
> -	dppclk_delay_subtotal = mode_lib->ip.dppclk_delay_subtotal;
>   	dispclk_delay_subtotal = mode_lib->ip.dispclk_delay_subtotal;
>   
> -	if (scl_enable)
> -		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl;
> -	else
> -		dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_scl_lb_only;
> -
> -	dppclk_delay_subtotal += mode_lib->ip.dppclk_delay_cnvc_formatter + src->num_cursors * mode_lib->ip.dppclk_delay_cnvc_cursor;
> -
>   	if (dout->dsc_enable) {
>   		double dsc_delay = get_dsc_delay(mode_lib, e2e_pipe_param, num_pipes, pipe_idx); // FROM VBA
>   

-- 
Hamza