* [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
@ 2013-02-11 17:51 Stephen Warren
2013-02-11 17:56 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Warren @ 2013-02-11 17:51 UTC (permalink / raw)
To: arm
Cc: linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren, Joe Perches
From: Stephen Warren <swarren@nvidia.com>
The intent is to ensure that all Tegra-related patches are sent to the
linux-tegra@ mailing list, so people can keep up-to-date on all misc
driver changes.
Doing this with a keyword is far simpler and more compact than listing
all Tegra-related drivers, even if wildcards were used.
Words such as integrate or integrator are common. Ensure the character
right before "tegra" isn't a-z (case-insensitive), to make sure the
keyword doesn't match those.
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b98c89b..10e9b31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7829,9 +7829,7 @@ L: linux-tegra@vger.kernel.org
Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
S: Supported
-F: arch/arm/mach-tegra
-F: arch/arm/boot/dts/tegra*
-F: arch/arm/configs/tegra_defconfig
+K: (?i)[^a-z]tegra
TEHUTI ETHERNET DRIVER
M: Andy Gospodarek <andy@greyhouse.net>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 17:51 [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section Stephen Warren
@ 2013-02-11 17:56 ` Joe Perches
2013-02-11 18:01 ` Stephen Warren
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2013-02-11 17:56 UTC (permalink / raw)
To: Stephen Warren
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The intent is to ensure that all Tegra-related patches are sent to the
> linux-tegra@ mailing list, so people can keep up-to-date on all misc
> driver changes.
>
> Doing this with a keyword is far simpler and more compact than listing
> all Tegra-related drivers, even if wildcards were used.
>
> Words such as integrate or integrator are common. Ensure the character
> right before "tegra" isn't a-z (case-insensitive), to make sure the
> keyword doesn't match those.
>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> MAINTAINERS | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b98c89b..10e9b31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7829,9 +7829,7 @@ L: linux-tegra@vger.kernel.org
> Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
> S: Supported
> -F: arch/arm/mach-tegra
> -F: arch/arm/boot/dts/tegra*
> -F: arch/arm/configs/tegra_defconfig
> +K: (?i)[^a-z]tegra
>
> TEHUTI ETHERNET DRIVER
> M: Andy Gospodarek <andy@greyhouse.net>
It's probably not a good idea to remove
any of the F: lines as there are files
that could get modified in those paths
without any tegra word in the patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 17:56 ` Joe Perches
@ 2013-02-11 18:01 ` Stephen Warren
2013-02-11 18:04 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Warren @ 2013-02-11 18:01 UTC (permalink / raw)
To: Joe Perches
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On 02/11/2013 10:56 AM, Joe Perches wrote:
> On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> The intent is to ensure that all Tegra-related patches are sent to the
>> linux-tegra@ mailing list, so people can keep up-to-date on all misc
>> driver changes.
>>
>> Doing this with a keyword is far simpler and more compact than listing
>> all Tegra-related drivers, even if wildcards were used.
>>
>> Words such as integrate or integrator are common. Ensure the character
>> right before "tegra" isn't a-z (case-insensitive), to make sure the
>> keyword doesn't match those.
>>
>> Cc: Joe Perches <joe@perches.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> MAINTAINERS | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b98c89b..10e9b31 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7829,9 +7829,7 @@ L: linux-tegra@vger.kernel.org
>> Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
>> S: Supported
>> -F: arch/arm/mach-tegra
>> -F: arch/arm/boot/dts/tegra*
>> -F: arch/arm/configs/tegra_defconfig
>> +K: (?i)[^a-z]tegra
>>
>> TEHUTI ETHERNET DRIVER
>> M: Andy Gospodarek <andy@greyhouse.net>
>
> It's probably not a good idea to remove
> any of the F: lines as there are files
> that could get modified in those paths
> without any tegra word in the patch.
At least for those F: lines that exist already and are removed above,
the keyword will match their filename, so there's no issue here.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 18:01 ` Stephen Warren
@ 2013-02-11 18:04 ` Joe Perches
2013-02-11 18:12 ` Stephen Warren
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2013-02-11 18:04 UTC (permalink / raw)
To: Stephen Warren
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On Mon, 2013-02-11 at 11:01 -0700, Stephen Warren wrote:
> On 02/11/2013 10:56 AM, Joe Perches wrote:
> > On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> The intent is to ensure that all Tegra-related patches are sent to the
> >> linux-tegra@ mailing list, so people can keep up-to-date on all misc
> >> driver changes.
> >>
> >> Doing this with a keyword is far simpler and more compact than listing
> >> all Tegra-related drivers, even if wildcards were used.
> >>
> >> Words such as integrate or integrator are common. Ensure the character
> >> right before "tegra" isn't a-z (case-insensitive), to make sure the
> >> keyword doesn't match those.
> >>
> >> Cc: Joe Perches <joe@perches.com>
> >> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >> ---
> >> MAINTAINERS | 4 +---
> >> 1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index b98c89b..10e9b31 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -7829,9 +7829,7 @@ L: linux-tegra@vger.kernel.org
> >> Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
> >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
> >> S: Supported
> >> -F: arch/arm/mach-tegra
> >> -F: arch/arm/boot/dts/tegra*
> >> -F: arch/arm/configs/tegra_defconfig
> >> +K: (?i)[^a-z]tegra
> >>
> >> TEHUTI ETHERNET DRIVER
> >> M: Andy Gospodarek <andy@greyhouse.net>
> >
> > It's probably not a good idea to remove
> > any of the F: lines as there are files
> > that could get modified in those paths
> > without any tegra word in the patch.
>
> At least for those F: lines that exist already and are removed above,
> the keyword will match their filename, so there's no issue here.
>
Not every use of get_maintainers is by patch.
./scripts/get_maintainer.pl -f arch/arm/mach-tegra
wouldn't match anything.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 18:04 ` Joe Perches
@ 2013-02-11 18:12 ` Stephen Warren
2013-02-11 18:19 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Warren @ 2013-02-11 18:12 UTC (permalink / raw)
To: Joe Perches
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On 02/11/2013 11:04 AM, Joe Perches wrote:
> On Mon, 2013-02-11 at 11:01 -0700, Stephen Warren wrote:
>> On 02/11/2013 10:56 AM, Joe Perches wrote:
>>> On Mon, 2013-02-11 at 10:51 -0700, Stephen Warren wrote:
>>>> From: Stephen Warren <swarren@nvidia.com>
>>>>
>>>> The intent is to ensure that all Tegra-related patches are sent to the
>>>> linux-tegra@ mailing list, so people can keep up-to-date on all misc
>>>> driver changes.
>>>>
>>>> Doing this with a keyword is far simpler and more compact than listing
>>>> all Tegra-related drivers, even if wildcards were used.
>>>>
>>>> Words such as integrate or integrator are common. Ensure the character
>>>> right before "tegra" isn't a-z (case-insensitive), to make sure the
>>>> keyword doesn't match those.
>>>>
>>>> Cc: Joe Perches <joe@perches.com>
>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>>> ---
>>>> MAINTAINERS | 4 +---
>>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index b98c89b..10e9b31 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -7829,9 +7829,7 @@ L: linux-tegra@vger.kernel.org
>>>> Q: http://patchwork.ozlabs.org/project/linux-tegra/list/
>>>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
>>>> S: Supported
>>>> -F: arch/arm/mach-tegra
>>>> -F: arch/arm/boot/dts/tegra*
>>>> -F: arch/arm/configs/tegra_defconfig
>>>> +K: (?i)[^a-z]tegra
>>>>
>>>> TEHUTI ETHERNET DRIVER
>>>> M: Andy Gospodarek <andy@greyhouse.net>
>>>
>>> It's probably not a good idea to remove
>>> any of the F: lines as there are files
>>> that could get modified in those paths
>>> without any tegra word in the patch.
>>
>> At least for those F: lines that exist already and are removed above,
>> the keyword will match their filename, so there's no issue here.
>>
>
> Not every use of get_maintainers is by patch.
>
> ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
>
> wouldn't match anything.
That's annoying; it kinda defeats the whole purpose of this patch then.
The way this patch works out with a patch is because the file-names are
matched against the keywords since they appear in the patch. A solution
to the issue you raise would be to do the same in -f mode, by adding an
explicit pass to check the filenames that are found against MAINTAINERS
too. Do you have any objection to that?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 18:12 ` Stephen Warren
@ 2013-02-11 18:19 ` Joe Perches
2013-02-11 18:30 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2013-02-11 18:19 UTC (permalink / raw)
To: Stephen Warren
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On Mon, 2013-02-11 at 11:12 -0700, Stephen Warren wrote:
> On 02/11/2013 11:04 AM, Joe Perches wrote:
> > ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
> > wouldn't match anything.
>
> That's annoying; it kinda defeats the whole purpose of this patch then.
>
> The way this patch works out with a patch is because the file-names are
> matched against the keywords since they appear in the patch. A solution
> to the issue you raise would be to do the same in -f mode, by adding an
> explicit pass to check the filenames that are found against MAINTAINERS
> too. Do you have any objection to that?
Knock yourself out.
Are there any tegra related files that would not
have tegra in the path?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section
2013-02-11 18:19 ` Joe Perches
@ 2013-02-11 18:30 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2013-02-11 18:30 UTC (permalink / raw)
To: Stephen Warren
Cc: arm, linux-tegra, linux-arm-kernel, linux-kernel, Stephen Warren
On Mon, 2013-02-11 at 10:19 -0800, Joe Perches wrote:
> On Mon, 2013-02-11 at 11:12 -0700, Stephen Warren wrote:
> > On 02/11/2013 11:04 AM, Joe Perches wrote:
> > > ./scripts/get_maintainer.pl -f arch/arm/mach-tegra
> > > wouldn't match anything.
> >
> > That's annoying; it kinda defeats the whole purpose of this patch then.
> >
> > The way this patch works out with a patch is because the file-names are
> > matched against the keywords since they appear in the patch. A solution
> > to the issue you raise would be to do the same in -f mode, by adding an
> > explicit pass to check the filenames that are found against MAINTAINERS
> > too. Do you have any objection to that?
>
> Knock yourself out.
>
> Are there any tegra related files that would not
> have tegra in the path?
To answer my own question:
$ git ls-files | grep -v tegra | xargs grep -Pl "(?i)[^a-z]tegra"
...
Several. Most are Kconfig and Makefiles.
Most except staging/nvec don't seem to be very important.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-11 18:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-11 17:51 [PATCH V2] MAINTAINERS: add keyword "tegra" to Tegra section Stephen Warren
2013-02-11 17:56 ` Joe Perches
2013-02-11 18:01 ` Stephen Warren
2013-02-11 18:04 ` Joe Perches
2013-02-11 18:12 ` Stephen Warren
2013-02-11 18:19 ` Joe Perches
2013-02-11 18:30 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).