* WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
@ 2013-01-02 15:37 Dave Jones
2013-01-18 20:53 ` Dave Jones
0 siblings, 1 reply; 12+ messages in thread
From: Dave Jones @ 2013-01-02 15:37 UTC (permalink / raw)
To: Linux Kernel; +Cc: Alan Cox, Jiri Slaby, Greg Kroah-Hartman
This happened a few times to my test boxes I left running over the holidays..
[ 8419.797533] ------------[ cut here ]------------
[ 8419.798341] WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc+0x1de/0x1f0()
[ 8419.800313] Hardware name: GA-MA78GM-S2H
[ 8419.800887] tty is NULL
[ 8419.801857] Modules linked in: fuse binfmt_misc bnep rfcomm hidp scsi_transport_iscsi can_raw can_bcm ipt_ULOG nfnetlink l2tp_ppp l2tp_core can caif_socket rose nfc caif ipx phonet irda p8023 p8022 netrom rds ax25 atm af_rxrpc crc_ccitt appletalk psnap llc2 af_key decnet llc pppoe pppox ppp_generic x25 slhc lockd sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_conntrack nf_conntrack ip6table_filter ip6_tables btusb bluetooth snd_hda_codec_realtek usb_debug rfkill snd_hda_intel snd_hda_codec microcode snd_pcm serio_raw snd_page_alloc pcspkr edac_core snd_timer snd soundcore r8169 mii vhost_net tun macvtap macvlan kvm_amd kvm
[ 8419.811268] Pid: 4980, comm: kworker/0:1 Not tainted 3.8.0-rc1+ #43
[ 8419.812159] Call Trace:
[ 8419.812586] [<ffffffff81044aef>] warn_slowpath_common+0x7f/0xc0
[ 8419.813504] [<ffffffff81044be6>] warn_slowpath_fmt+0x46/0x50
[ 8419.814353] [<ffffffff8132b59a>] ? ___ratelimit+0x9a/0x120
[ 8419.815146] [<ffffffff813e5a8e>] flush_to_ldisc+0x1de/0x1f0
[ 8419.815982] [<ffffffff81068a77>] process_one_work+0x207/0x750
[ 8419.816844] [<ffffffff81068a07>] ? process_one_work+0x197/0x750
[ 8419.817731] [<ffffffff810b2342>] ? get_lock_stats+0x22/0x70
[ 8419.818605] [<ffffffff813e58b0>] ? tty_insert_flip_string_fixed_flag+0x110/0x110
[ 8419.819725] [<ffffffff81069396>] worker_thread+0x156/0x440
[ 8419.820575] [<ffffffff81069240>] ? rescuer_thread+0x240/0x240
[ 8419.821463] [<ffffffff8106fd8d>] kthread+0xed/0x100
[ 8419.822174] [<ffffffff810b27ae>] ? put_lock_stats.isra.23+0xe/0x40
[ 8419.823125] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
[ 8419.824114] [<ffffffff816a49dc>] ret_from_fork+0x7c/0xb0
[ 8419.824943] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
[ 8419.845167] ---[ end trace 0c3565bace6c005f ]---
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-01-02 15:37 WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL) Dave Jones
@ 2013-01-18 20:53 ` Dave Jones
2013-01-18 21:07 ` Greg Kroah-Hartman
0 siblings, 1 reply; 12+ messages in thread
From: Dave Jones @ 2013-01-18 20:53 UTC (permalink / raw)
To: Linux Kernel, Alan Cox, Jiri Slaby, Greg Kroah-Hartman
On Wed, Jan 02, 2013 at 10:37:44AM -0500, Dave Jones wrote:
> This happened a few times to my test boxes I left running over the holidays..
>
> [ 8419.797533] ------------[ cut here ]------------
> [ 8419.798341] WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc+0x1de/0x1f0()
> [ 8419.800313] Hardware name: GA-MA78GM-S2H
> [ 8419.800887] tty is NULL
> [ 8419.801857] Modules linked in: fuse binfmt_misc bnep rfcomm hidp scsi_transport_iscsi can_raw can_bcm ipt_ULOG nfnetlink l2tp_ppp l2tp_core can caif_socket rose nfc caif ipx phonet irda p8023 p8022 netrom rds ax25 atm af_rxrpc crc_ccitt appletalk psnap llc2 af_key decnet llc pppoe pppox ppp_generic x25 slhc lockd sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_conntrack nf_conntrack ip6table_filter ip6_tables btusb bluetooth snd_hda_codec_realtek usb_debug rfkill snd_hda_intel snd_hda_codec microcode snd_pcm serio_raw snd_page_alloc pcspkr edac_core snd_timer snd soundcore r8169 mii vhost_net tun macvtap macvlan kvm_amd kvm
> [ 8419.811268] Pid: 4980, comm: kworker/0:1 Not tainted 3.8.0-rc1+ #43
> [ 8419.812159] Call Trace:
> [ 8419.812586] [<ffffffff81044aef>] warn_slowpath_common+0x7f/0xc0
> [ 8419.813504] [<ffffffff81044be6>] warn_slowpath_fmt+0x46/0x50
> [ 8419.814353] [<ffffffff8132b59a>] ? ___ratelimit+0x9a/0x120
> [ 8419.815146] [<ffffffff813e5a8e>] flush_to_ldisc+0x1de/0x1f0
> [ 8419.815982] [<ffffffff81068a77>] process_one_work+0x207/0x750
> [ 8419.816844] [<ffffffff81068a07>] ? process_one_work+0x197/0x750
> [ 8419.817731] [<ffffffff810b2342>] ? get_lock_stats+0x22/0x70
> [ 8419.818605] [<ffffffff813e58b0>] ? tty_insert_flip_string_fixed_flag+0x110/0x110
> [ 8419.819725] [<ffffffff81069396>] worker_thread+0x156/0x440
> [ 8419.820575] [<ffffffff81069240>] ? rescuer_thread+0x240/0x240
> [ 8419.821463] [<ffffffff8106fd8d>] kthread+0xed/0x100
> [ 8419.822174] [<ffffffff810b27ae>] ? put_lock_stats.isra.23+0xe/0x40
> [ 8419.823125] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
> [ 8419.824114] [<ffffffff816a49dc>] ret_from_fork+0x7c/0xb0
> [ 8419.824943] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
> [ 8419.845167] ---[ end trace 0c3565bace6c005f ]---
Still seeing this in rc4
Dave
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-01-18 20:53 ` Dave Jones
@ 2013-01-18 21:07 ` Greg Kroah-Hartman
2013-01-19 21:00 ` Jiri Slaby
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2013-01-18 21:07 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, Alan Cox, Jiri Slaby
On Fri, Jan 18, 2013 at 03:53:58PM -0500, Dave Jones wrote:
> On Wed, Jan 02, 2013 at 10:37:44AM -0500, Dave Jones wrote:
> > This happened a few times to my test boxes I left running over the holidays..
> >
> > [ 8419.797533] ------------[ cut here ]------------
> > [ 8419.798341] WARNING: at drivers/tty/tty_buffer.c:476 flush_to_ldisc+0x1de/0x1f0()
> > [ 8419.800313] Hardware name: GA-MA78GM-S2H
> > [ 8419.800887] tty is NULL
> > [ 8419.801857] Modules linked in: fuse binfmt_misc bnep rfcomm hidp scsi_transport_iscsi can_raw can_bcm ipt_ULOG nfnetlink l2tp_ppp l2tp_core can caif_socket rose nfc caif ipx phonet irda p8023 p8022 netrom rds ax25 atm af_rxrpc crc_ccitt appletalk psnap llc2 af_key decnet llc pppoe pppox ppp_generic x25 slhc lockd sunrpc ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_conntrack nf_conntrack ip6table_filter ip6_tables btusb bluetooth snd_hda_codec_realtek usb_debug rfkill snd_hda_intel snd_hda_codec microcode snd_pcm serio_raw snd_page_alloc pcspkr edac_core snd_timer snd soundcore r8169 mii vhost_net tun macvtap macvlan kvm_amd kvm
> > [ 8419.811268] Pid: 4980, comm: kworker/0:1 Not tainted 3.8.0-rc1+ #43
> > [ 8419.812159] Call Trace:
> > [ 8419.812586] [<ffffffff81044aef>] warn_slowpath_common+0x7f/0xc0
> > [ 8419.813504] [<ffffffff81044be6>] warn_slowpath_fmt+0x46/0x50
> > [ 8419.814353] [<ffffffff8132b59a>] ? ___ratelimit+0x9a/0x120
> > [ 8419.815146] [<ffffffff813e5a8e>] flush_to_ldisc+0x1de/0x1f0
> > [ 8419.815982] [<ffffffff81068a77>] process_one_work+0x207/0x750
> > [ 8419.816844] [<ffffffff81068a07>] ? process_one_work+0x197/0x750
> > [ 8419.817731] [<ffffffff810b2342>] ? get_lock_stats+0x22/0x70
> > [ 8419.818605] [<ffffffff813e58b0>] ? tty_insert_flip_string_fixed_flag+0x110/0x110
> > [ 8419.819725] [<ffffffff81069396>] worker_thread+0x156/0x440
> > [ 8419.820575] [<ffffffff81069240>] ? rescuer_thread+0x240/0x240
> > [ 8419.821463] [<ffffffff8106fd8d>] kthread+0xed/0x100
> > [ 8419.822174] [<ffffffff810b27ae>] ? put_lock_stats.isra.23+0xe/0x40
> > [ 8419.823125] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
> > [ 8419.824114] [<ffffffff816a49dc>] ret_from_fork+0x7c/0xb0
> > [ 8419.824943] [<ffffffff8106fca0>] ? kthread_create_on_node+0x160/0x160
> > [ 8419.845167] ---[ end trace 0c3565bace6c005f ]---
>
>
> Still seeing this in rc4
Jiri, was there anything on the mailing list that I missed that should
have resolved this issue? I thought it was being worked on, but I can't
seem to find any resolution at the moment.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-01-18 21:07 ` Greg Kroah-Hartman
@ 2013-01-19 21:00 ` Jiri Slaby
2013-01-30 18:33 ` Peter Hurley
0 siblings, 1 reply; 12+ messages in thread
From: Jiri Slaby @ 2013-01-19 21:00 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Dave Jones, Linux Kernel, Alan Cox, Peter Hurley
On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> Jiri, was there anything on the mailing list that I missed that should
> have resolved this issue? I thought it was being worked on, but I can't
> seem to find any resolution at the moment.
Somebody had a patchset and promised to repost IIRC. I forgot his name
though.
/me back from digging in the mail history.
Peter Hurley is the name.
Peter, what happened with your patches in the end, please?
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-01-19 21:00 ` Jiri Slaby
@ 2013-01-30 18:33 ` Peter Hurley
2013-02-11 2:44 ` Michael Ellerman
0 siblings, 1 reply; 12+ messages in thread
From: Peter Hurley @ 2013-01-30 18:33 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote:
> On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> > Jiri, was there anything on the mailing list that I missed that should
> > have resolved this issue? I thought it was being worked on, but I can't
> > seem to find any resolution at the moment.
>
> Somebody had a patchset and promised to repost IIRC. I forgot his name
> though.
>
> /me back from digging in the mail history.
>
> Peter Hurley is the name.
>
> Peter, what happened with your patches in the end, please?
The tty subsystem is very resilient to fixing :)
The thing I'm working on right now -- which hopefully is the last issue
with the line discipline logic -- occurs with parallel __tty_hangup()
and tty_release().
At the moment, I'm trying to narrow the conditions when this happens.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-01-30 18:33 ` Peter Hurley
@ 2013-02-11 2:44 ` Michael Ellerman
2013-02-11 14:42 ` Peter Hurley
0 siblings, 1 reply; 12+ messages in thread
From: Michael Ellerman @ 2013-02-11 2:44 UTC (permalink / raw)
To: Peter Hurley
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Wed, Jan 30, 2013 at 01:33:57PM -0500, Peter Hurley wrote:
> On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote:
> > On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> > > Jiri, was there anything on the mailing list that I missed that should
> > > have resolved this issue? I thought it was being worked on, but I can't
> > > seem to find any resolution at the moment.
> >
> > Somebody had a patchset and promised to repost IIRC. I forgot his name
> > though.
> >
> > /me back from digging in the mail history.
> >
> > Peter Hurley is the name.
> >
> > Peter, what happened with your patches in the end, please?
>
> The tty subsystem is very resilient to fixing :)
>
> The thing I'm working on right now -- which hopefully is the last issue
> with the line discipline logic -- occurs with parallel __tty_hangup()
> and tty_release().
>
> At the moment, I'm trying to narrow the conditions when this happens.
If it helps I seem to be able to reproduce this in just a few seconds by
running trinity and hitting Ctrl-C to quit the watchdog.
cheers
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-11 2:44 ` Michael Ellerman
@ 2013-02-11 14:42 ` Peter Hurley
2013-02-12 2:00 ` Michael Ellerman
2013-02-17 6:26 ` Shawn Guo
0 siblings, 2 replies; 12+ messages in thread
From: Peter Hurley @ 2013-02-11 14:42 UTC (permalink / raw)
To: Michael Ellerman
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
Hi Michael,
On Mon, 2013-02-11 at 13:44 +1100, Michael Ellerman wrote:
> On Wed, Jan 30, 2013 at 01:33:57PM -0500, Peter Hurley wrote:
> > On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote:
> > > On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> > > > Jiri, was there anything on the mailing list that I missed that should
> > > > have resolved this issue? I thought it was being worked on, but I can't
> > > > seem to find any resolution at the moment.
> > >
> > > Somebody had a patchset and promised to repost IIRC. I forgot his name
> > > though.
> > >
> > > /me back from digging in the mail history.
> > >
> > > Peter Hurley is the name.
> > >
> > > Peter, what happened with your patches in the end, please?
> >
> > The tty subsystem is very resilient to fixing :)
> >
> > The thing I'm working on right now -- which hopefully is the last issue
> > with the line discipline logic -- occurs with parallel __tty_hangup()
> > and tty_release().
> >
> > At the moment, I'm trying to narrow the conditions when this happens.
>
> If it helps I seem to be able to reproduce this in just a few seconds by
^^^^^^^^^^^^^^
you get this WARNING from a parallel __tty_hangup?
Or do you mean simply that you get this WARNING?
> running trinity and hitting Ctrl-C to quit the watchdog.
Can you reproduce after using the following patch series?
[PATCH v3 00/23] ldisc fixes
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-11 14:42 ` Peter Hurley
@ 2013-02-12 2:00 ` Michael Ellerman
2013-02-12 2:53 ` Peter Hurley
2013-02-17 6:26 ` Shawn Guo
1 sibling, 1 reply; 12+ messages in thread
From: Michael Ellerman @ 2013-02-12 2:00 UTC (permalink / raw)
To: Peter Hurley
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Mon, Feb 11, 2013 at 09:42:30AM -0500, Peter Hurley wrote:
> Hi Michael,
>
> On Mon, 2013-02-11 at 13:44 +1100, Michael Ellerman wrote:
> > On Wed, Jan 30, 2013 at 01:33:57PM -0500, Peter Hurley wrote:
> > > On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote:
> > > > On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote:
> > > > > Jiri, was there anything on the mailing list that I missed that should
> > > > > have resolved this issue? I thought it was being worked on, but I can't
> > > > > seem to find any resolution at the moment.
> > > >
> > > > Somebody had a patchset and promised to repost IIRC. I forgot his name
> > > > though.
> > > >
> > > > /me back from digging in the mail history.
> > > >
> > > > Peter Hurley is the name.
> > > >
> > > > Peter, what happened with your patches in the end, please?
> > >
> > > The tty subsystem is very resilient to fixing :)
> > >
> > > The thing I'm working on right now -- which hopefully is the last issue
> > > with the line discipline logic -- occurs with parallel __tty_hangup()
> > > and tty_release().
> > >
> > > At the moment, I'm trying to narrow the conditions when this happens.
> >
> > If it helps I seem to be able to reproduce this in just a few seconds by
> ^^^^^^^^^^^^^^
> you get this WARNING from a parallel __tty_hangup?
>
> Or do you mean simply that you get this WARNING?
Sorry I just mean I'm seeing the warning, I have no idea how.
> > running trinity and hitting Ctrl-C to quit the watchdog.
>
> Can you reproduce after using the following patch series?
> [PATCH v3 00/23] ldisc fixes
What are they against? I tried Linus' tree and linux-next but they
didn't apply cleanly against either.
cheers
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-12 2:00 ` Michael Ellerman
@ 2013-02-12 2:53 ` Peter Hurley
2013-02-12 6:41 ` Michael Ellerman
0 siblings, 1 reply; 12+ messages in thread
From: Peter Hurley @ 2013-02-12 2:53 UTC (permalink / raw)
To: Michael Ellerman
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Tue, 2013-02-12 at 13:00 +1100, Michael Ellerman wrote:
> Sorry I just mean I'm seeing the warning, I have no idea how.
Ok, no problem. I just got a little excited because that area of code
was hard to test adequately.
> > Can you reproduce after using the following patch series?
> > [PATCH v3 00/23] ldisc fixes
>
> What are they against? I tried Linus' tree and linux-next but they
> didn't apply cleanly against either.
The series was generated against next-20130204. 13/23 doesn't apply
cleanly at next-20130211 because of changes since. Rebases fine
though :)
The series is currently in mid-review, so a new series won't be out
until that completes. (Besides, next-20130211 doesn't even boot for
me.)
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-12 2:53 ` Peter Hurley
@ 2013-02-12 6:41 ` Michael Ellerman
2013-02-12 11:34 ` Peter Hurley
0 siblings, 1 reply; 12+ messages in thread
From: Michael Ellerman @ 2013-02-12 6:41 UTC (permalink / raw)
To: Peter Hurley
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Mon, Feb 11, 2013 at 09:53:58PM -0500, Peter Hurley wrote:
> On Tue, 2013-02-12 at 13:00 +1100, Michael Ellerman wrote:
> > > Can you reproduce after using the following patch series?
> > > [PATCH v3 00/23] ldisc fixes
> >
> > What are they against? I tried Linus' tree and linux-next but they
> > didn't apply cleanly against either.
>
> The series was generated against next-20130204. 13/23 doesn't apply
> cleanly at next-20130211 because of changes since. Rebases fine
> though :)
Should have tried harder against next, git-am is very picky.
So running next-20130211, 20 runs of trinity followed by ctrl-c, I saw
the warning 12 times. Back trace is basically always:
Call Trace:
[c00000027a1efb20] [c000000000467b74] .flush_to_ldisc+0x244/0x250 (unreliable)
[c00000027a1efbd0] [c00000000009ea7c] .process_one_work+0x1bc/0x4f0
[c00000027a1efc70] [c00000000009f2e0] .worker_thread+0x180/0x4b0
[c00000027a1efd30] [c0000000000a6c3c] .kthread+0xec/0x100
[c00000027a1efe30] [c000000000009f64] .ret_from_kernel_thread+0x64/0x80
Running next-20130211 + "ldisc fixes", 20 runs of trinity followed by ctrl-c,
I saw the warning _0_ times.
Insert standard comment about testing only proving the presence of bugs not
their absence :)
So it looks promising.
cheers
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-12 6:41 ` Michael Ellerman
@ 2013-02-12 11:34 ` Peter Hurley
0 siblings, 0 replies; 12+ messages in thread
From: Peter Hurley @ 2013-02-12 11:34 UTC (permalink / raw)
To: Michael Ellerman
Cc: Jiri Slaby, Greg Kroah-Hartman, Dave Jones, Linux Kernel, Alan Cox
On Tue, 2013-02-12 at 17:41 +1100, Michael Ellerman wrote:
> On Mon, Feb 11, 2013 at 09:53:58PM -0500, Peter Hurley wrote:
> > On Tue, 2013-02-12 at 13:00 +1100, Michael Ellerman wrote:
> > > > Can you reproduce after using the following patch series?
> > > > [PATCH v3 00/23] ldisc fixes
> > >
> > > What are they against? I tried Linus' tree and linux-next but they
> > > didn't apply cleanly against either.
> >
> > The series was generated against next-20130204. 13/23 doesn't apply
> > cleanly at next-20130211 because of changes since. Rebases fine
> > though :)
>
> Should have tried harder against next, git-am is very picky.
>
> So running next-20130211, 20 runs of trinity followed by ctrl-c, I saw
> the warning 12 times. Back trace is basically always:
>
> Call Trace:
> [c00000027a1efb20] [c000000000467b74] .flush_to_ldisc+0x244/0x250 (unreliable)
> [c00000027a1efbd0] [c00000000009ea7c] .process_one_work+0x1bc/0x4f0
> [c00000027a1efc70] [c00000000009f2e0] .worker_thread+0x180/0x4b0
> [c00000027a1efd30] [c0000000000a6c3c] .kthread+0xec/0x100
> [c00000027a1efe30] [c000000000009f64] .ret_from_kernel_thread+0x64/0x80
>
>
> Running next-20130211 + "ldisc fixes", 20 runs of trinity followed by ctrl-c,
> I saw the warning _0_ times.
>
> Insert standard comment about testing only proving the presence of bugs not
> their absence :)
Thanks for testing.
Also, as I noted in 00/23:
Changes in v3:
- Because of new changes to the way drivers interact with tty flip
buffers, this series no longer purports to prevent the flush_to_ldisc()
warning.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL)
2013-02-11 14:42 ` Peter Hurley
2013-02-12 2:00 ` Michael Ellerman
@ 2013-02-17 6:26 ` Shawn Guo
1 sibling, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2013-02-17 6:26 UTC (permalink / raw)
To: Peter Hurley
Cc: Michael Ellerman, Jiri Slaby, Greg Kroah-Hartman, Dave Jones,
Linux Kernel, Alan Cox, linux-arm-kernel
Hi Peter,
On Mon, Feb 11, 2013 at 09:42:30AM -0500, Peter Hurley wrote:
> Can you reproduce after using the following patch series?
> [PATCH v3 00/23] ldisc fixes
>
I'm constantly seeing this warning on my board (imx6q - ARM Cortex-A9
Quad) with -next kernel, while I believe v3.8-rc kernel works just
fine for me.
The warning can be seen during both boot and suspend/resume (in a
couple of iterations). The bad thing is "[PATCH v3 00/23] ldisc
fixes" does not help my case at all.
Shawn
Booting Linux on physical CPU 0x0
Linux version 3.8.0-rc7-next-20130215+ (r65073@S2101-09) (gcc version
4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #330 SMP Sun Feb 17 13:59:44 CST
2013
CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c53c7d
CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
Machine: Freescale i.MX6 Quad (Device Tree), model: Freescale i.MX6Q
SABRE Smart Device Board
Memory policy: ECC disabled, Data cache writealloc
On node 0 totalpages: 262144
free_area_init_node: node 0, pgdat 80746180, node_mem_map 8079f000
Normal zone: 2048 pages used for memmap
Normal zone: 0 pages reserved
Normal zone: 262144 pages, LIFO batch:31
PERCPU: Embedded 7 pages/cpu @80fad000 s6656 r8192 d13824 u32768
pcpu-alloc: s6656 r8192 d13824 u32768 alloc=8*4096
pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3
Built 1 zonelists in Zone order, mobility grouping on. Total pages:
260096
Kernel command line: console=ttymxc0,115200 debug earlyprintk
no_console_suspend root=/dev/nfs ip=dhcp
nfsroot=192.168.1.100:/home/r65073/nfs/rfs-imx6q,v3,tcp
PID hash table entries: 4096 (order: 2, 16384 bytes)
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
__ex_table already sorted, skipping sort
Memory: 1024MB = 1024MB total
Memory: 1031576k/1031576k available, 17000k reserved, 0K highmem
Virtual kernel memory layout:
vector : 0xffff0000 - 0xffff1000 ( 4 kB)
fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB)
vmalloc : 0xc0800000 - 0xff000000 (1000 MB)
lowmem : 0x80000000 - 0xc0000000 (1024 MB)
modules : 0x7f000000 - 0x80000000 ( 16 MB)
.text : 0x80008000 - 0x806aff04 (6816 kB)
.init : 0x806b0000 - 0x806faa00 ( 299 kB)
.data : 0x806fc000 - 0x80746ae0 ( 299 kB)
.bss : 0x80746ae0 - 0x8079ef54 ( 354 kB)
SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
Hierarchical RCU implementation.
NR_IRQS:16 nr_irqs:16 16
L310 cache controller enabled
l2x0: 16 ways, CACHE_ID 0x000000c0, AUX_CTRL 0x02070000, Cache size:
1048576 B
sched_clock: 32 bits at 66MHz, resolution 15ns, wraps every 65075ms
smp_twd: clock not found -2
CPU identified as i.MX6Q, silicon rev 1.2
Console: colour dummy device 80x30
Calibrating delay loop... 1581.05 BogoMIPS (lpj=7905280)
pid_max: default: 32768 minimum: 301
Mount-cache hash table entries: 512
CPU: Testing write buffer coherency: ok
CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
Calibrating local timer... 396.17MHz.
Setting up static identity map for 0x8051f678 - 0x8051f6e8
CPU1: Booted secondary processor
CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
CPU2: Booted secondary processor
CPU2: thread -1, cpu 2, socket 0, mpidr 80000002
CPU3: Booted secondary processor
CPU3: thread -1, cpu 3, socket 0, mpidr 80000003
Brought up 4 CPUs
SMP: Total of 4 processors activated (6324.22 BogoMIPS).
CPU: All CPU(s) started in SVC mode.
devtmpfs: initialized
pinctrl core: initialized pinctrl subsystem
regulator-dummy: no parameters
NET: Registered protocol family 16
DMA: preallocated 256 KiB pool for atomic coherent allocations
syscon 20c8000.anatop: syscon regmap start 0x20c8000 end 0x20c8fff
registered
vdd1p1: 800 <--> 1375 mV at 1100 mV
vdd3p0: 2800 <--> 3150 mV at 3000 mV
vdd2p5: 2000 <--> 2750 mV at 2400 mV
cpu: 725 <--> 1450 mV at 1100 mV
vddpu: 725 <--> 1450 mV at 1100 mV
vddsoc: 725 <--> 1450 mV at 1200 mV
syscon 20e0000.iomuxc-gpr: syscon regmap start 0x20e0000 end 0x20e0037
registered
imx6q-pinctrl 20e0000.iomuxc: initialized IMX pinctrl driver
bio: create slab <bio-0> at 0
mxs-dma 110000.dma-apbh: initialized
SCSI subsystem initialized
libata version 3.00 loaded.
usbcore: registered new interface driver usbfs
usbcore: registered new interface driver hub
usbcore: registered new device driver usb
Linux video capture interface: v2.00
pps_core: LinuxPPS API ver. 1 registered
pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti
<giometti@linux.it>
PTP clock support registered
Advanced Linux Sound Architecture Driver Initialized.
Switching to clocksource mxc_timer1
NET: Registered protocol family 2
TCP established hash table entries: 8192 (order: 4, 65536 bytes)
TCP bind hash table entries: 8192 (order: 4, 65536 bytes)
TCP: Hash tables configured (established 8192 bind 8192)
TCP: reno registered
UDP hash table entries: 512 (order: 2, 16384 bytes)
UDP-Lite hash table entries: 512 (order: 2, 16384 bytes)
NET: Registered protocol family 1
RPC: Registered named UNIX socket transport module.
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
RPC: Registered tcp NFSv4.1 backchannel transport module.
VFS: Disk quotas dquot_6.5.2
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
NFS: Registering the id_resolver key type
Key type id_resolver registered
Key type id_legacy registered
jffs2: version 2.2. (NAND) © 2001-2006 Red Hat, Inc.
fuse init (API version 7.21)
msgmni has been set to 2014
io scheduler noop registered
io scheduler deadline registered
io scheduler cfq registered (default)
imx-sdma 20ec000.sdma: initialized
Serial: IMX driver
2020000.serial: ttymxc0 at MMIO 0x2020000 (irq = 58) is a IMX
console [ttymxc0] enabled
[drm] Initialized drm 1.1.0 20060810
brd: module loaded
loop: module loaded
registered PHC device on eth%d
libphy: fec_enet_mii_bus: probed
ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
ehci-mxc: Freescale On-Chip EHCI Host driver
Initializing USB Mass Storage driver...
usbcore: registered new interface driver usb-storage
USB Mass Storage support registered.
mousedev: PS/2 mouse device common for all mice
snvs_rtc 20cc034.snvs-rtc-lp: rtc core: registered 20cc034.snvs-rtc-lp
as rtc0
i2c /dev entries driver
imx2-wdt 20bc000.wdog: IMX2+ Watchdog Timer enabled. timeout=60s
(nowayout=0)
sdhci: Secure Digital Host Controller Interface driver
sdhci: Copyright(c) Pierre Ossman
sdhci-pltfm: SDHCI platform and OF driver helper
mmc0: no vqmmc regulator found
mmc0: no vmmc regulator found
mmc0: SDHCI controller on 2194000.usdhc [2194000.usdhc] using ADMA
mmc1: no vqmmc regulator found
mmc1: no vmmc regulator found
mmc1: SDHCI controller on 2198000.usdhc [2198000.usdhc] using ADMA
usbcore: registered new interface driver usbhid
usbhid: USB HID core driver
[drm] Supports vblank timestamp caching Rev 1 (10.10.2010).
[drm] No driver support for vblank timestamp query.
[drm] Initialized imx-drm 1.0.0 20120507 on minor 0
imx-ipuv3 2400000.ipu: IPUv3H probed
imx-ipuv3 2800000.ipu: IPUv3H probed
TCP: cubic registered
NET: Registered protocol family 10
sit: IPv6 over IPv4 tunneling driver
NET: Registered protocol family 17
Key type dns_resolver registered
VFP support v0.3: implementor 41 architecture 3 part 30 variant 9 rev 4
input: gpio-keys.8 as /devices/gpio-keys.8/input/input0
------------[ cut here ]------------
WARNING: at
/home/r65073/repos/next/linux-next/drivers/tty/tty_buffer.c:428
flush_to_ldisc+0x18c/0x1a0()
snvs_rtc 20cc034.snvs-rtc-lp: setting system clock to 1970-01-01
04:16:21 UTC (15381)
tty is NULL
Modules linked in:
Backtrace:
[<8001199c>] (dump_backtrace+0x0/0x10c) from [<805195c8>]
(dump_stack+0x18/0x1c)
r6:000001ac r5:8029a8e8 r4:bfa89e98 r3:00000000
[<805195b0>] (dump_stack+0x0/0x1c) from [<80021004>]
(warn_slowpath_common+0x54/0x70)
[<80020fb0>] (warn_slowpath_common+0x0/0x70) from [<800210c4>]
(warn_slowpath_fmt+0x38/0x40)
r8:00000000 r7:bf804000 r6:80fb1000 r5:00000000 r4:bf804000
r3:00000009
[<8002108c>] (warn_slowpath_fmt+0x0/0x40) from [<8029a8e8>]
(flush_to_ldisc+0x18c/0x1a0)
r3:00000000 r2:80642ac0
[<8029a75c>] (flush_to_ldisc+0x0/0x1a0) from [<80038f48>]
(process_one_work+0x114/0x378)
[<80038e34>] (process_one_work+0x0/0x378) from [<80039540>]
(worker_thread+0x12c/0x3f0)
[<80039414>] (worker_thread+0x0/0x3f0) from [<8003e8f0>]
(kthread+0xac/0xb8)
[<8003e844>] (kthread+0x0/0xb8) from [<8000e618>]
(ret_from_fork+0x14/0x3c)
r7:00000000 r6:00000000 r5:8003e844 r4:bf879e64
---[ end trace df46cda12ac3bc25 ]---
eth0: Freescale FEC PHY driver [Generic PHY]
(mii_bus:phy_addr=2188000.ethernet:01, irq=-1)
IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
libphy: 2188000.ethernet:01 - Link is Up - 100/Full
IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Sending DHCP requests ., OK
IP-Config: Got DHCP answer from 192.168.1.1, my address is 192.168.1.103
IP-Config: Complete:
device=eth0, hwaddr=00:04:9f:01:1b:63, ipaddr=192.168.1.103,
mask=255.255.255.0, gw=192.168.1.1
host=192.168.1.103, domain=domain, nis-domain=(none)
bootserver=0.0.0.0, rootserver=192.168.1.100, rootpath=, mtu=576
nameserver0=61.177.7.1, nameserver1=221.228.255.1
ALSA device list:
No soundcards found.
VFS: Mounted root (nfs filesystem) readonly on device 0:11.
devtmpfs: mounted
Freeing init memory: 296K
starting pid 52, tty '': '/etc/rc.d/rcS'
Mounting /proc and /sys
Starting the hotplug events dispatcher udevd
udevd (62): /proc/62/oom_adj is deprecated, please use
/proc/62/oom_score_adj instead.
Synthesizing initial hotplug events
imx-sdma 20ec000.sdma: firmware not found
Setting the hostname to freescale
Mounting filesystems
mount: mounting usbfs on /proc/bus/usb failed: No such file or directory
Starting the dropbear ssh server:
D-Bus per-session daemon address is:
unix:abstract=/tmp/dbus-gBTWuUASn1,guid=4a5fbed482fe86f57671852a00003c1f
gtk: creating gdk-pixbuf.loaders
pango: creating module list
starting pid 682, tty '': '/etc/rc.d/rc_gpu.S'
starting pid 688, tty '': '/etc/rc.d/rc_mxc.S'
Error opening framebuffer /dev/fb0: No such file or directory
Fatal server error:
no screens found
arm-none-linux-gnueabi-gcc (Freescale MAD -- Linaro 2011.07 -- Built at
2011/08/10 09:20) 4.6.2 20110630 (prerelease)
root filesystem built on Wed, 26 Dec 2012 15:44:10 -0600
Freescale Semiconductor, Inc.
freescale login: matchbox-panel: failed to open displaymatchbox-desktop:
unable to open display !
matchbox: can't open display! check your DISPLAY variable.
root
login[690]: root login on 'ttymxc0'
BusyBox v1.20.2 () built-in shell (ash)
Enter 'help' for a list of built-in commands.
root@freescale ~$ ./rtcwakeup.sh
rtcwakeup.out: wakeup from "mem" using rtc0 at Fri Jan 2 04:18:12 1970
PM: Syncing filesystems ... done.
PM: Preparing system for mem sleep
Freezing user space processes ... (elapsed 0.01 seconds) done.
Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
PM: Entering mem sleep
PM: suspend of devices complete after 0.699 msecs
PM: suspend devices took 0.010 seconds
PM: late suspend of devices complete after 0.220 msecs
PM: noirq suspend of devices complete after 0.691 msecs
Disabling non-boot CPUs ...
CPU1: shutdown
CPU2: shutdown
CPU3: shutdown
Enabling non-boot CPUs ...
CPU1: Booted secondary processor
CPU1 is up
CPU2: Booted secondary processor
CPU2 is up
CPU3: Booted secondary processor
CPU3 is up
PM: noirq resume of devices complete after 0.180 msecs
PM: early resume of devices complete after 0.258 msecs
PM: resume of devices complete after 2.687 msecs
PM: resume devices took 0.010 seconds
PM: Finishing wakeup.
Restarting tasks ... done.
Pass 2 times!!!!!!!!!!
rtcwakeup.out: wakeup from "mem" using rtc0 at Fri Jan 2 04:18:16 1970
PM: Syncing filesystems ... done.
PM: Preparing system for mem sleep
Freezing user space processes ... (elapsed 0.01 seconds) done.
Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
PM: Entering mem sleep
PM: suspend of devices complete after 0.689 msecs
PM: suspend devices took 0.010 seconds
PM: late suspend of devices complete after 0.223 msecs
PM: noirq suspend of devices complete after 0.725 msecs
Disabling non-boot CPUs ...
CPU1: shutdown
CPU2: shutdown
CPU3: shutdown
Enabling non-boot CPUs ...
CPU1: Booted secondary processor
CPU1 is up
CPU2: Booted secondary processor
CPU2 is up
CPU3: Booted secondary processor
CPU3 is up
PM: noirq resume of devices complete after 0.182 msecs
PM: early resume of devices complete after 0.273 msecs
------------[ cut here ]------------
WARNING: at
/home/r65073/repos/next/linux-next/drivers/tty/tty_buffer.c:428
flush_to_ldisc+0x18c/0x1a0()
tty is NULL
Modules linked in:
Backtrace: PM: resume of devices complete after 17.922 msecs
PM: resume devices took 0.020 seconds
PM: Finishing wakeup.
Restarting tasks ... done.
[<8001199c>] (dump_backtrace+0x0/0x10c) from [<805195c8>]
(dump_stack+0x18/0x1c)
r6:000001ac r5:8029a8e8 r4:bfa89e98 r3:00000000
[<805195b0>] (dump_stack+0x0/0x1c) from [<80021004>]
(warn_slowpath_common+0x54/0x70)
[<80020fb0>] (warn_slowpath_common+0x0/0x70) from [<800210c4>]
(warn_slowpath_fmt+0x38/0x40)
r8:00000000 r7:bf0d2600 r6:80fb1000 r5:00000000 r4:bf0d2600
r3:00000009
[<8002108c>] (warn_slowpath_fmt+0x0/0x40) from [<8029a8e8>]
(flush_to_ldisc+0x18c/0x1a0)
r3:00000000 r2:80642ac0
[<8029a75c>] (flush_to_ldisc+0x0/0x1a0) from [<80038f48>]
(process_one_work+0x114/0x378)
[<80038e34>] (process_one_work+0x0/0x378) from [<80039540>]
(worker_thread+0x12c/0x3f0)
[<80039414>] (worker_thread+0x0/0x3f0) from [<8003e8f0>]
(kthread+0xac/0xb8)
[<8003e844>] (kthread+0x0/0xb8) from [<8000e618>]
(ret_from_fork+0x14/0x3c)
r7:00000000 r6:00000000 r5:8003e844 r4:bf879e64
---[ end trace df46cda12ac3bc26 ]---
Pass 3 times!!!!!!!!!!
rtcwakeup.out: wakeup from "mem" using rtc0 at Fri Jan 2 04:18:20 1970
PM: Syncing filesystems ... done.
PM: Preparing system for mem sleep
Freezing user space processes ... (elapsed 0.01 seconds) done.
Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
PM: Entering mem sleep
PM: suspend of devices complete after 0.687 msecs
PM: suspend devices took 0.010 seconds
PM: late suspend of devices complete after 0.210 msecs
PM: noirq suspend of devices complete after 0.721 msecs
Disabling non-boot CPUs ...
CPU1: shutdown
CPU2: shutdown
CPU3: shutdown
Enabling non-boot CPUs ...
CPU1: Booted secondary processor
CPU1 is up
CPU2: Booted secondary processor
CPU2 is up
CPU3: Booted secondary processor
CPU3 is up
PM: noirq resume of devices complete after 0.179 msecs
PM: early resume of devices complete after 0.261 msecs
------------[ cut here ]------------
WARNING: at
/home/r65073/repos/next/linux-next/drivers/tty/tty_buffer.c:428
flush_to_ldisc+0x18c/0x1a0()
tty is NULL
Modules linked in:
Backtrace: PM: resume of devices complete after 17.891 msecs
PM: resume devices took 0.010 seconds
PM: Finishing wakeup.
Restarting tasks ... done.
[<8001199c>] (dump_backtrace+0x0/0x10c) from [<805195c8>]
(dump_stack+0x18/0x1c)
r6:000001ac r5:8029a8e8 r4:bf2bbe98 r3:00000000
[<805195b0>] (dump_stack+0x0/0x1c) from [<80021004>]
(warn_slowpath_common+0x54/0x70)
[<80020fb0>] (warn_slowpath_common+0x0/0x70) from [<800210c4>]
(warn_slowpath_fmt+0x38/0x40)
r8:00000000 r7:bf0d2600 r6:80fb1000 r5:00000000 r4:bf0d2600
r3:00000009
[<8002108c>] (warn_slowpath_fmt+0x0/0x40) from [<8029a8e8>]
(flush_to_ldisc+0x18c/0x1a0)
r3:00000000 r2:80642ac0
[<8029a75c>] (flush_to_ldisc+0x0/0x1a0) from [<80038f48>]
(process_one_work+0x114/0x378)
[<80038e34>] (process_one_work+0x0/0x378) from [<80039540>]
(worker_thread+0x12c/0x3f0)
[<80039414>] (worker_thread+0x0/0x3f0) from [<8003e8f0>]
(kthread+0xac/0xb8)
[<8003e844>] (kthread+0x0/0xb8) from [<8000e618>]
(ret_from_fork+0x14/0x3c)
r7:00000000 r6:00000000 r5:8003e844 r4:bf879e64
---[ end trace df46cda12ac3bc27 ]---
root@freescale ~$
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-17 6:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-02 15:37 WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL) Dave Jones
2013-01-18 20:53 ` Dave Jones
2013-01-18 21:07 ` Greg Kroah-Hartman
2013-01-19 21:00 ` Jiri Slaby
2013-01-30 18:33 ` Peter Hurley
2013-02-11 2:44 ` Michael Ellerman
2013-02-11 14:42 ` Peter Hurley
2013-02-12 2:00 ` Michael Ellerman
2013-02-12 2:53 ` Peter Hurley
2013-02-12 6:41 ` Michael Ellerman
2013-02-12 11:34 ` Peter Hurley
2013-02-17 6:26 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).