* [PATCH] regmap: debugfs: Simplify calculation of `c->max_reg'
@ 2013-02-14 11:33 Dimitris Papastamos
2013-02-14 12:09 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dimitris Papastamos @ 2013-02-14 11:33 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, patches
We don't need to use any of the file position information
to calculate the base and max register of each block. Just
use the counter directly.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
drivers/base/regmap/regmap-debugfs.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 78d5f20..5fb23cb 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -95,9 +95,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
regmap_precious(map, i)) {
if (c) {
c->max = p - 1;
- fpos_offset = c->max - c->min;
- reg_offset = fpos_offset / map->debugfs_tot_len;
- c->max_reg = c->base_reg + reg_offset;
+ c->max_reg = i - 1;
list_add_tail(&c->list,
&map->debugfs_off_cache);
c = NULL;
@@ -124,9 +122,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
/* Close the last entry off if we didn't scan beyond it */
if (c) {
c->max = p - 1;
- fpos_offset = c->max - c->min;
- reg_offset = fpos_offset / map->debugfs_tot_len;
- c->max_reg = c->base_reg + reg_offset;
+ c->max_reg = i - 1;
list_add_tail(&c->list,
&map->debugfs_off_cache);
}
--
1.8.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap: debugfs: Simplify calculation of `c->max_reg'
2013-02-14 11:33 [PATCH] regmap: debugfs: Simplify calculation of `c->max_reg' Dimitris Papastamos
@ 2013-02-14 12:09 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-02-14 12:09 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Thu, Feb 14, 2013 at 11:33:28AM +0000, Dimitris Papastamos wrote:
> We don't need to use any of the file position information
> to calculate the base and max register of each block. Just
> use the counter directly.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-14 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-14 11:33 [PATCH] regmap: debugfs: Simplify calculation of `c->max_reg' Dimitris Papastamos
2013-02-14 12:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).