linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND 1/2] clocksource: dbx500-prcmu: use relaxed readl variant
@ 2013-02-28 10:01 Fabio Baltieri
  2013-02-28 10:01 ` [PATCH RESEND 2/2] clocksource: dbx500-prcmu: comment cleanup Fabio Baltieri
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Baltieri @ 2013-02-28 10:01 UTC (permalink / raw)
  To: John Stultz
  Cc: linux-arm-kernel, linux-kernel, Linus Walleij, Thomas Gleixner,
	Rabin Vincent, Fabio Baltieri

From: Rabin Vincent <rabin.vincent@stericsson.com>

Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
This speeds up calls to the function by about 40%.

Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index c26c369..159f54a 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -33,15 +33,14 @@
 
 static void __iomem *clksrc_dbx500_timer_base;
 
-static cycle_t clksrc_dbx500_prcmu_read(struct clocksource *cs)
+static cycle_t notrace clksrc_dbx500_prcmu_read(struct clocksource *cs)
 {
+	void __iomem *base = clksrc_dbx500_timer_base;
 	u32 count, count2;
 
 	do {
-		count = readl(clksrc_dbx500_timer_base +
-			      PRCMU_TIMER_DOWNCOUNT);
-		count2 = readl(clksrc_dbx500_timer_base +
-			       PRCMU_TIMER_DOWNCOUNT);
+		count = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
+		count2 = readl_relaxed(base + PRCMU_TIMER_DOWNCOUNT);
 	} while (count2 != count);
 
 	/* Negate because the timer is a decrementing counter */
-- 
1.7.12.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH RESEND 2/2] clocksource: dbx500-prcmu: comment cleanup
  2013-02-28 10:01 [PATCH RESEND 1/2] clocksource: dbx500-prcmu: use relaxed readl variant Fabio Baltieri
@ 2013-02-28 10:01 ` Fabio Baltieri
  2013-03-04  7:03   ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Baltieri @ 2013-02-28 10:01 UTC (permalink / raw)
  To: John Stultz
  Cc: linux-arm-kernel, linux-kernel, Linus Walleij, Thomas Gleixner,
	Fabio Baltieri

Remove references to the deprecated DB5500 platform.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>
---
 drivers/clocksource/clksrc-dbx500-prcmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c b/drivers/clocksource/clksrc-dbx500-prcmu.c
index 159f54a..6879a74 100644
--- a/drivers/clocksource/clksrc-dbx500-prcmu.c
+++ b/drivers/clocksource/clksrc-dbx500-prcmu.c
@@ -10,7 +10,7 @@
  * DBx500-PRCMU Timer
  * The PRCMU has 5 timers which are available in a always-on
  * power domain.  We use the Timer 4 for our always-on clock
- * source on DB8500 and Timer 3 on DB5500.
+ * source on DB8500.
  */
 #include <linux/clockchips.h>
 #include <linux/clksrc-dbx500-prcmu.h>
-- 
1.7.12.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND 2/2] clocksource: dbx500-prcmu: comment cleanup
  2013-02-28 10:01 ` [PATCH RESEND 2/2] clocksource: dbx500-prcmu: comment cleanup Fabio Baltieri
@ 2013-03-04  7:03   ` Linus Walleij
  0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-03-04  7:03 UTC (permalink / raw)
  To: Fabio Baltieri
  Cc: John Stultz, linux-arm-kernel, linux-kernel, Thomas Gleixner

On Thu, Feb 28, 2013 at 11:01 AM, Fabio Baltieri
<fabio.baltieri@linaro.org> wrote:

> Remove references to the deprecated DB5500 platform.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org>

I've taken this and the other patch into the ux500 tree,
as per discussion with John changes to these drivers should
go through someone who can test it on the actual hardware.

Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-04  7:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-28 10:01 [PATCH RESEND 1/2] clocksource: dbx500-prcmu: use relaxed readl variant Fabio Baltieri
2013-02-28 10:01 ` [PATCH RESEND 2/2] clocksource: dbx500-prcmu: comment cleanup Fabio Baltieri
2013-03-04  7:03   ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).