* [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
@ 2013-03-05 12:21 Axel Lin
2013-03-06 10:38 ` Lars Poeschel
2013-03-27 8:13 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-03-05 12:21 UTC (permalink / raw)
To: Grant Likely; +Cc: Lars Poeschel, Linus Walleij, linux-kernel
Set it once is enough, and it's done in vprbrd_gpiob_set() which is called by
vprbrd_gpiob_direction_output().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-viperboard.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c
index 59d7239..095ab14 100644
--- a/drivers/gpio/gpio-viperboard.c
+++ b/drivers/gpio/gpio-viperboard.c
@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip,
struct vprbrd *vb = gpio->vb;
gpio->gpiob_out |= (1 << offset);
- if (value)
- gpio->gpiob_val |= (1 << offset);
- else
- gpio->gpiob_val &= ~(1 << offset);
mutex_lock(&vb->lock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
2013-03-05 12:21 [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val Axel Lin
@ 2013-03-06 10:38 ` Lars Poeschel
2013-03-27 8:13 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Lars Poeschel @ 2013-03-06 10:38 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Linus Walleij, linux-kernel
On Tuesday 05 March 2013 at 13:21:56, Axel Lin wrote:
> Set it once is enough, and it's done in vprbrd_gpiob_set() which is called
> by vprbrd_gpiob_direction_output().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thank you!
Tested-and-Acked-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> drivers/gpio/gpio-viperboard.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-viperboard.c
> b/drivers/gpio/gpio-viperboard.c index 59d7239..095ab14 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct
> gpio_chip *chip, struct vprbrd *vb = gpio->vb;
>
> gpio->gpiob_out |= (1 << offset);
> - if (value)
> - gpio->gpiob_val |= (1 << offset);
> - else
> - gpio->gpiob_val &= ~(1 << offset);
>
> mutex_lock(&vb->lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
2013-03-05 12:21 [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val Axel Lin
2013-03-06 10:38 ` Lars Poeschel
@ 2013-03-27 8:13 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-03-27 8:13 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Lars Poeschel, linux-kernel
On Tue, Mar 5, 2013 at 1:21 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Set it once is enough, and it's done in vprbrd_gpiob_set() which is called by
> vprbrd_gpiob_direction_output().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied with Lars' Tested/Acked-by.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-27 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-05 12:21 [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val Axel Lin
2013-03-06 10:38 ` Lars Poeschel
2013-03-27 8:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).