[PATCH 0/3] Davinci support for EHRPWM & ECAP

[PATCH 0/3] Davinci support for EHRPWM & ECAP

[Philip Avinash]

This patch series enables EHRPWM & ECAP driver support for da850
platforms.

This patch series based on [1] and is available at [2]. This has been tested
backlight support using EHRPWM in da850-evm.

[1] https://gitorious.org/linux-pwm/linux-pwm/trees/for-next
[2] https://github.com/avinashphilip/am335x_linux/tree/davinci-for-v3.9_soc_pwm

Philip Avinash (3):
  pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices
  pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
  pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC

 .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
 .../devicetree/bindings/pwm/pwm-tiehrpwm.txt       |    2 +-
 drivers/pwm/Kconfig                                |    8 +++-----
 drivers/pwm/pwm-tiecap.c                           |    1 +
 drivers/pwm/pwm-tiehrpwm.c                         |    1 +
 drivers/pwm/pwm-tipwmss.h                          |    2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

-- 
1.7.9.5

[PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices

[Philip Avinash]

Add EHRPWM and ECAP support build support for DAVINCI_DA850 platforms.

Also, since DAVINCI platforms doesn't support TI-PWM-Subsystem module,
remove the select option for CONFIG_PWM_TIPWMSS.

Also, update CONFIG_PWM_TIPWMSS compiler directive appropriately in
pwm-tipwmss.h to fix the below compiler error upon removal of
CONFIG_PWM_TIPWMSS for Davinci platforms.

	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_probe':
	drivers/pwm/pwm-tiecap.c:263:4: error: 'PWMSS_ECAPCLK_EN' undeclared
	(first use in this function)
	drivers/pwm/pwm-tiecap.c:263:4: note: each undeclared identifier
	is reported only once for each function it appears in
	drivers/pwm/pwm-tiecap.c:264:17: error: 'PWMSS_ECAPCLK_EN_ACK'
	undeclared (first use in this function)
	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_remove':
	drivers/pwm/pwm-tiecap.c:291:49: error: 'PWMSS_ECAPCLK_STOP_REQ'
	undeclared (first use in this function)
	make[2]: *** [drivers/pwm/pwm-tiecap.o] Error 1
	make[1]: *** [drivers/pwm] Error 2
	make: *** [drivers] Error 2

Signed-off-by: Philip Avinash <avinashphilip@ti.com>
---
:100644 100644 0e0bfa0... 897b53c... M	drivers/pwm/Kconfig
:100644 100644 11f76a1... 10ad804... M	drivers/pwm/pwm-tipwmss.h
 drivers/pwm/Kconfig       |    8 +++-----
 drivers/pwm/pwm-tipwmss.h |    2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index 0e0bfa0..897b53c 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -147,8 +147,7 @@ config PWM_TEGRA
 
 config  PWM_TIECAP
 	tristate "ECAP PWM support"
-	depends on SOC_AM33XX
-	select PWM_TIPWMSS
+	depends on SOC_AM33XX || ARCH_DAVINCI_DA850
 	help
 	  PWM driver support for the ECAP APWM controller found on AM33XX
 	  TI SOC
@@ -158,8 +157,7 @@ config  PWM_TIECAP
 
 config  PWM_TIEHRPWM
 	tristate "EHRPWM PWM support"
-	depends on SOC_AM33XX
-	select PWM_TIPWMSS
+	depends on SOC_AM33XX || ARCH_DAVINCI_DA850
 	help
 	  PWM driver support for the EHRPWM controller found on AM33XX
 	  TI SOC
@@ -169,7 +167,7 @@ config  PWM_TIEHRPWM
 
 config  PWM_TIPWMSS
 	bool
-	depends on SOC_AM33XX && (PWM_TIEHRPWM || PWM_TIECAP)
+	default y if SOC_AM33XX && (PWM_TIECAP || PWM_TIEHRPWM)
 	help
 	  PWM Subsystem driver support for AM33xx SOC.
 
diff --git a/drivers/pwm/pwm-tipwmss.h b/drivers/pwm/pwm-tipwmss.h
index 11f76a1..10ad804 100644
--- a/drivers/pwm/pwm-tipwmss.h
+++ b/drivers/pwm/pwm-tipwmss.h
@@ -18,7 +18,6 @@
 #ifndef __TIPWMSS_H
 #define __TIPWMSS_H
 
-#ifdef CONFIG_PWM_TIPWMSS
 /* PWM substem clock gating */
 #define PWMSS_ECAPCLK_EN	BIT(0)
 #define PWMSS_ECAPCLK_STOP_REQ	BIT(1)
@@ -28,6 +27,7 @@
 #define PWMSS_ECAPCLK_EN_ACK	BIT(0)
 #define PWMSS_EPWMCLK_EN_ACK	BIT(8)
 
+#ifdef CONFIG_PWM_TIPWMSS
 extern u16 pwmss_submodule_state_change(struct device *dev, int set);
 #else
 static inline u16 pwmss_submodule_state_change(struct device *dev, int set)
-- 
1.7.9.5

[PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

[Philip Avinash]

ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
support for da850.

Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Rob Landley <rob@landley.net>
Signed-off-by: Philip Avinash <avinashphilip@ti.com>
---
:100644 100644 131e8c1... fcbd3c1... M	Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
:100644 100644 22e96e2... e0d96c8... M	drivers/pwm/pwm-tiecap.c
 .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
 drivers/pwm/pwm-tiecap.c                           |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
index 131e8c1..fcbd3c1 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
@@ -1,7 +1,7 @@
 TI SOC ECAP based APWM controller
 
 Required properties:
-- compatible: Must be "ti,am33xx-ecap"
+- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
 - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
   First cell specifies the per-chip index of the PWM to use, the second
   cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 22e96e2..e0d96c8 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
 
 static const struct of_device_id ecap_of_match[] = {
 	{ .compatible	= "ti,am33xx-ecap" },
+	{ .compatible	= "ti,da850-ecap" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, ecap_of_match);
-- 
1.7.9.5

[PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC

[Philip Avinash]

EHRPWM IP is used in da850 SOC's also. Hence adds EHRPWM device tree
binding support for da850.

Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Rob Landley <rob@landley.net>
Signed-off-by: Philip Avinash <avinashphilip@ti.com>
---
:100644 100644 4fc7079... 0442d65... M	Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
:100644 100644 8b4c86f... 6561ec2... M	drivers/pwm/pwm-tiehrpwm.c
 .../devicetree/bindings/pwm/pwm-tiehrpwm.txt       |    2 +-
 drivers/pwm/pwm-tiehrpwm.c                         |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
index 4fc7079..0442d65 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
@@ -1,7 +1,7 @@
 TI SOC EHRPWM based PWM controller
 
 Required properties:
-- compatible : Must be "ti,am33xx-ehrpwm"
+- compatible : Must be "ti,am33xx-ehrpwm" or "ti,da850-ehrpwm"
 - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
   First cell specifies the per-chip index of the PWM to use, the second
   cell is the period in nanoseconds and bit 0 in the third cell is used to
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index 8b4c86f..6561ec2 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -428,6 +428,7 @@ static const struct pwm_ops ehrpwm_pwm_ops = {
 
 static const struct of_device_id ehrpwm_of_match[] = {
 	{ .compatible	= "ti,am33xx-ehrpwm" },
+	{ .compatible	= "ti,da850-ehrpwm" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, ehrpwm_of_match);
-- 
1.7.9.5

Re: [PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices

[Sekhar Nori]

On 3/14/2013 4:02 PM, Philip Avinash wrote:
> Add EHRPWM and ECAP support build support for DAVINCI_DA850 platforms.
> 
> Also, since DAVINCI platforms doesn't support TI-PWM-Subsystem module,
> remove the select option for CONFIG_PWM_TIPWMSS.
> 
> Also, update CONFIG_PWM_TIPWMSS compiler directive appropriately in
> pwm-tipwmss.h to fix the below compiler error upon removal of
> CONFIG_PWM_TIPWMSS for Davinci platforms.
> 
> 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_probe':
> 	drivers/pwm/pwm-tiecap.c:263:4: error: 'PWMSS_ECAPCLK_EN' undeclared
> 	(first use in this function)
> 	drivers/pwm/pwm-tiecap.c:263:4: note: each undeclared identifier
> 	is reported only once for each function it appears in
> 	drivers/pwm/pwm-tiecap.c:264:17: error: 'PWMSS_ECAPCLK_EN_ACK'
> 	undeclared (first use in this function)
> 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_remove':
> 	drivers/pwm/pwm-tiecap.c:291:49: error: 'PWMSS_ECAPCLK_STOP_REQ'
> 	undeclared (first use in this function)
> 	make[2]: *** [drivers/pwm/pwm-tiecap.o] Error 1
> 	make[1]: *** [drivers/pwm] Error 2
> 	make: *** [drivers] Error 2
> 
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>

>  config  PWM_TIECAP
>  	tristate "ECAP PWM support"
> -	depends on SOC_AM33XX
> -	select PWM_TIPWMSS
> +	depends on SOC_AM33XX || ARCH_DAVINCI_DA850

Having such narrow dependencies is wrong. The same device is present on
DaVinci DA830 too. A depends on should not be required at all since the
driver should build on all architectures. But I have seen resistance to
doing that since users don't like to see configuration options totally
irrelevant for the architecture they are building for. So may be take a
middle path and do 'depends on ARCH_ARM'?

Thanks,
Sekhar

Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

[Sekhar Nori]

On 3/14/2013 4:02 PM, Philip Avinash wrote:
> ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> support for da850.
> 
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> :100644 100644 131e8c1... fcbd3c1... M	Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> :100644 100644 22e96e2... e0d96c8... M	drivers/pwm/pwm-tiecap.c
>  .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
>  drivers/pwm/pwm-tiecap.c                           |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> index 131e8c1..fcbd3c1 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> @@ -1,7 +1,7 @@
>  TI SOC ECAP based APWM controller
>  
>  Required properties:
> -- compatible: Must be "ti,am33xx-ecap"
> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
>  - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
>    First cell specifies the per-chip index of the PWM to use, the second
>    cell is the period in nanoseconds and bit 0 in the third cell is used to
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 22e96e2..e0d96c8 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
>  
>  static const struct of_device_id ecap_of_match[] = {
>  	{ .compatible	= "ti,am33xx-ecap" },
> +	{ .compatible	= "ti,da850-ecap" },
>  	{},

You add a new compatible, but don't really show any changes in driver in
this series. So why can't we simply use ti,am33xx-ecap on DA850 too?

Thanks,
Sekhar

RE: [PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices

[Philip, Avinash]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2129 bytes --]

On Thu, Mar 14, 2013 at 17:09:04, Nori, Sekhar wrote:
> On 3/14/2013 4:02 PM, Philip Avinash wrote:
> > Add EHRPWM and ECAP support build support for DAVINCI_DA850 platforms.
> > 
> > Also, since DAVINCI platforms doesn't support TI-PWM-Subsystem module,
> > remove the select option for CONFIG_PWM_TIPWMSS.
> > 
> > Also, update CONFIG_PWM_TIPWMSS compiler directive appropriately in
> > pwm-tipwmss.h to fix the below compiler error upon removal of
> > CONFIG_PWM_TIPWMSS for Davinci platforms.
> > 
> > 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_probe':
> > 	drivers/pwm/pwm-tiecap.c:263:4: error: 'PWMSS_ECAPCLK_EN' undeclared
> > 	(first use in this function)
> > 	drivers/pwm/pwm-tiecap.c:263:4: note: each undeclared identifier
> > 	is reported only once for each function it appears in
> > 	drivers/pwm/pwm-tiecap.c:264:17: error: 'PWMSS_ECAPCLK_EN_ACK'
> > 	undeclared (first use in this function)
> > 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_remove':
> > 	drivers/pwm/pwm-tiecap.c:291:49: error: 'PWMSS_ECAPCLK_STOP_REQ'
> > 	undeclared (first use in this function)
> > 	make[2]: *** [drivers/pwm/pwm-tiecap.o] Error 1
> > 	make[1]: *** [drivers/pwm] Error 2
> > 	make: *** [drivers] Error 2
> > 
> > Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> 
> >  config  PWM_TIECAP
> >  	tristate "ECAP PWM support"
> > -	depends on SOC_AM33XX
> > -	select PWM_TIPWMSS
> > +	depends on SOC_AM33XX || ARCH_DAVINCI_DA850
> 
> Having such narrow dependencies is wrong. The same device is present on
> DaVinci DA830 too. A depends on should not be required at all since the
> driver should build on all architectures. But I have seen resistance to
> doing that since users don't like to see configuration options totally
> irrelevant for the architecture they are building for. So may be take a
> middle path and do 'depends on ARCH_ARM'?

I will add dependency only on ARCH_ARM and submit another version.

Thanks
Avinash

> 
> Thanks,
> Sekhar
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

RE: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

[Philip, Avinash]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2407 bytes --]

On Thu, Mar 14, 2013 at 17:13:08, Nori, Sekhar wrote:
> On 3/14/2013 4:02 PM, Philip Avinash wrote:
> > ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> > support for da850.
> > 
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Rob Landley <rob@landley.net>
> > Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> > ---
> > :100644 100644 131e8c1... fcbd3c1... M	Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > :100644 100644 22e96e2... e0d96c8... M	drivers/pwm/pwm-tiecap.c
> >  .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
> >  drivers/pwm/pwm-tiecap.c                           |    1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > index 131e8c1..fcbd3c1 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > @@ -1,7 +1,7 @@
> >  TI SOC ECAP based APWM controller
> >  
> >  Required properties:
> > -- compatible: Must be "ti,am33xx-ecap"
> > +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >  - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
> >    First cell specifies the per-chip index of the PWM to use, the second
> >    cell is the period in nanoseconds and bit 0 in the third cell is used to
> > diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> > index 22e96e2..e0d96c8 100644
> > --- a/drivers/pwm/pwm-tiecap.c
> > +++ b/drivers/pwm/pwm-tiecap.c
> > @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >  
> >  static const struct of_device_id ecap_of_match[] = {
> >  	{ .compatible	= "ti,am33xx-ecap" },
> > +	{ .compatible	= "ti,da850-ecap" },
> >  	{},
> 
> You add a new compatible, but don't really show any changes in driver in
> this series. So why can't we simply use ti,am33xx-ecap on DA850 too?

Ok it can happily live with ti,am33xx-ecap. Hence this patch and next [1]patch
can be dropped.

1. [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC

Thanks
Avinash
> 
> Thanks,
> Sekhar
> 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2195 bytes --]

On Thu, Mar 14, 2013 at 12:54:08PM +0000, Philip, Avinash wrote:
> On Thu, Mar 14, 2013 at 17:09:04, Nori, Sekhar wrote:
> > On 3/14/2013 4:02 PM, Philip Avinash wrote:
> > > Add EHRPWM and ECAP support build support for DAVINCI_DA850 platforms.
> > > 
> > > Also, since DAVINCI platforms doesn't support TI-PWM-Subsystem module,
> > > remove the select option for CONFIG_PWM_TIPWMSS.
> > > 
> > > Also, update CONFIG_PWM_TIPWMSS compiler directive appropriately in
> > > pwm-tipwmss.h to fix the below compiler error upon removal of
> > > CONFIG_PWM_TIPWMSS for Davinci platforms.
> > > 
> > > 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_probe':
> > > 	drivers/pwm/pwm-tiecap.c:263:4: error: 'PWMSS_ECAPCLK_EN' undeclared
> > > 	(first use in this function)
> > > 	drivers/pwm/pwm-tiecap.c:263:4: note: each undeclared identifier
> > > 	is reported only once for each function it appears in
> > > 	drivers/pwm/pwm-tiecap.c:264:17: error: 'PWMSS_ECAPCLK_EN_ACK'
> > > 	undeclared (first use in this function)
> > > 	drivers/pwm/pwm-tiecap.c: In function 'ecap_pwm_remove':
> > > 	drivers/pwm/pwm-tiecap.c:291:49: error: 'PWMSS_ECAPCLK_STOP_REQ'
> > > 	undeclared (first use in this function)
> > > 	make[2]: *** [drivers/pwm/pwm-tiecap.o] Error 1
> > > 	make[1]: *** [drivers/pwm] Error 2
> > > 	make: *** [drivers] Error 2
> > > 
> > > Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> > 
> > >  config  PWM_TIECAP
> > >  	tristate "ECAP PWM support"
> > > -	depends on SOC_AM33XX
> > > -	select PWM_TIPWMSS
> > > +	depends on SOC_AM33XX || ARCH_DAVINCI_DA850
> > 
> > Having such narrow dependencies is wrong. The same device is present on
> > DaVinci DA830 too. A depends on should not be required at all since the
> > driver should build on all architectures. But I have seen resistance to
> > doing that since users don't like to see configuration options totally
> > irrelevant for the architecture they are building for. So may be take a
> > middle path and do 'depends on ARCH_ARM'?
> 
> I will add dependency only on ARCH_ARM and submit another version.

Perhaps SOC_AM33XX || ARCH_DAVINCI_DA8XX would be an alternative?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

[Peter Korsgaard]

>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:

 >> Required properties:
 >> -- compatible: Must be "ti,am33xx-ecap"
 >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
 >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
 >> First cell specifies the per-chip index of the PWM to use, the second
 >> cell is the period in nanoseconds and bit 0 in the third cell is used to
 >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
 >> index 22e96e2..e0d96c8 100644
 >> --- a/drivers/pwm/pwm-tiecap.c
 >> +++ b/drivers/pwm/pwm-tiecap.c
 >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
 >> 
 >> static const struct of_device_id ecap_of_match[] = {
 >> { .compatible	= "ti,am33xx-ecap" },
 >> +	{ .compatible	= "ti,da850-ecap" },
 >> {},

 Sekhar> You add a new compatible, but don't really show any changes in
 Sekhar> driver in this series. So why can't we simply use
 Sekhar> ti,am33xx-ecap on DA850 too?

Indeed, if the hardware block is identical the dts should simply list:

compatible = "ti,da850-ecap", "ti,am33xx-ecap"

And the driver only bind to ti,am33xx-ecap (unless there ever needs to
be a da850 specific workarounde.

-- 
Bye, Peter Korsgaard

Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

[Sekhar Nori]

On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
>>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:
> 
>  >> Required properties:
>  >> -- compatible: Must be "ti,am33xx-ecap"
>  >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
>  >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
>  >> First cell specifies the per-chip index of the PWM to use, the second
>  >> cell is the period in nanoseconds and bit 0 in the third cell is used to
>  >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
>  >> index 22e96e2..e0d96c8 100644
>  >> --- a/drivers/pwm/pwm-tiecap.c
>  >> +++ b/drivers/pwm/pwm-tiecap.c
>  >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
>  >> 
>  >> static const struct of_device_id ecap_of_match[] = {
>  >> { .compatible	= "ti,am33xx-ecap" },
>  >> +	{ .compatible	= "ti,da850-ecap" },
>  >> {},
> 
>  Sekhar> You add a new compatible, but don't really show any changes in
>  Sekhar> driver in this series. So why can't we simply use
>  Sekhar> ti,am33xx-ecap on DA850 too?
> 
> Indeed, if the hardware block is identical the dts should simply list:
> 
> compatible = "ti,da850-ecap", "ti,am33xx-ecap"
> 
> And the driver only bind to ti,am33xx-ecap (unless there ever needs to
> be a da850 specific workarounde.

Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!

~Sekhar