* [PATCH 1/2] pinctrl: generic: Make 'conf_items' static
@ 2013-03-15 4:53 Sachin Kamat
2013-03-15 4:53 ` [PATCH 2/2] pinctrl: generic: Fix checkpatch errors Sachin Kamat
2013-03-27 21:48 ` [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-03-15 4:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
'conf_items' is used only in this file. Silences the below
sparse warning:
drivers/pinctrl/pinconf-generic.c:37:24: warning:
symbol 'conf_items' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinconf-generic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 9c43685..791e6a3 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -34,7 +34,7 @@ struct pin_config_item {
#define PCONFDUMP(a, b, c) { .param = a, .display = b, .format = c }
-struct pin_config_item conf_items[] = {
+static struct pin_config_item conf_items[] = {
PCONFDUMP(PIN_CONFIG_BIAS_DISABLE, "input bias disabled", NULL),
PCONFDUMP(PIN_CONFIG_BIAS_HIGH_IMPEDANCE, "input bias high impedance", NULL),
PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", NULL),
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] pinctrl: generic: Fix checkpatch errors
2013-03-15 4:53 [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Sachin Kamat
@ 2013-03-15 4:53 ` Sachin Kamat
2013-03-27 21:49 ` Linus Walleij
2013-03-27 21:48 ` [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-03-15 4:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
Fixes the following type of checkpatch errors:
ERROR: space required before the open parenthesis '('
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinconf-generic.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 791e6a3..2ad5a8d 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -60,7 +60,7 @@ void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev,
if (!ops->is_generic)
return;
- for(i = 0; i < ARRAY_SIZE(conf_items); i++) {
+ for (i = 0; i < ARRAY_SIZE(conf_items); i++) {
unsigned long config;
int ret;
@@ -95,7 +95,7 @@ void pinconf_generic_dump_group(struct pinctrl_dev *pctldev,
if (!ops->is_generic)
return;
- for(i = 0; i < ARRAY_SIZE(conf_items); i++) {
+ for (i = 0; i < ARRAY_SIZE(conf_items); i++) {
unsigned long config;
int ret;
@@ -126,7 +126,7 @@ void pinconf_generic_dump_config(struct pinctrl_dev *pctldev,
{
int i;
- for(i = 0; i < ARRAY_SIZE(conf_items); i++) {
+ for (i = 0; i < ARRAY_SIZE(conf_items); i++) {
if (pinconf_to_config_param(config) != conf_items[i].param)
continue;
seq_printf(s, "%s: 0x%x", conf_items[i].display,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] pinctrl: generic: Make 'conf_items' static
2013-03-15 4:53 [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Sachin Kamat
2013-03-15 4:53 ` [PATCH 2/2] pinctrl: generic: Fix checkpatch errors Sachin Kamat
@ 2013-03-27 21:48 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-03-27 21:48 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Fri, Mar 15, 2013 at 5:53 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> 'conf_items' is used only in this file. Silences the below
> sparse warning:
> drivers/pinctrl/pinconf-generic.c:37:24: warning:
> symbol 'conf_items' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Nice catch! Nice sparseing!
Patch applied!
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] pinctrl: generic: Fix checkpatch errors
2013-03-15 4:53 ` [PATCH 2/2] pinctrl: generic: Fix checkpatch errors Sachin Kamat
@ 2013-03-27 21:49 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-03-27 21:49 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Fri, Mar 15, 2013 at 5:53 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following type of checkpatch errors:
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied!
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-27 21:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-15 4:53 [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Sachin Kamat
2013-03-15 4:53 ` [PATCH 2/2] pinctrl: generic: Fix checkpatch errors Sachin Kamat
2013-03-27 21:49 ` Linus Walleij
2013-03-27 21:48 ` [PATCH 1/2] pinctrl: generic: Make 'conf_items' static Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).