* [PATCH] mfd: remove twelve unused Kconfig symbols
@ 2013-03-19 22:38 Paul Bolle
[not found] ` <20130320082427.GB28775@opensource.wolfsonmicro.com>
0 siblings, 1 reply; 4+ messages in thread
From: Paul Bolle @ 2013-03-19 22:38 UTC (permalink / raw)
To: Samuel Ortiz, Mark Brown; +Cc: linux-kernel
Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
custom wm8350 cache implementation") removed all their (actual) users.
Remove these symbols too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Eyeball tested. (With a lot of help from "git grep", that is.)
1) I did not sent this to the ARM maintainers!
arch/arm/mach-imx/Kconfig | 2 --
arch/arm/mach-s3c64xx/Kconfig | 3 ---
drivers/mfd/Kconfig | 48 -------------------------------------------
3 files changed, 53 deletions(-)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 4c9c6f9..6d9ae09 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -481,8 +481,6 @@ config MACH_MX31ADS_WM1133_EV1
depends on MACH_MX31ADS
depends on MFD_WM8350_I2C
depends on REGULATOR_WM8350 = y
- select MFD_WM8350_CONFIG_MODE_0
- select MFD_WM8352_CONFIG_MODE_0
help
Include support for the Wolfson Microelectronics 1133-EV1 PMU
and audio module for the MX31ADS platform.
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 131c862..041da51 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -198,10 +198,7 @@ endchoice
config SMDK6410_WM1190_EV1
bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
depends on MACH_SMDK6410
- select MFD_WM8350_CONFIG_MODE_0
- select MFD_WM8350_CONFIG_MODE_3
select MFD_WM8350_I2C
- select MFD_WM8352_CONFIG_MODE_0
select REGULATOR
select REGULATOR_WM8350
select SAMSUNG_GPIO_EXTRA64
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c346941..ebb1bed 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -687,54 +687,6 @@ config MFD_WM8350
bool
depends on GENERIC_HARDIRQS
-config MFD_WM8350_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
config MFD_WM8350_I2C
bool "Support Wolfson Microelectronics WM8350 with I2C"
select MFD_WM8350
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] mfd: remove twelve unused Kconfig symbols
[not found] ` <20130320082427.GB28775@opensource.wolfsonmicro.com>
@ 2013-03-20 9:09 ` Paul Bolle
2013-03-25 1:08 ` Kukjin Kim
2013-04-09 8:14 ` Samuel Ortiz
0 siblings, 2 replies; 4+ messages in thread
From: Paul Bolle @ 2013-03-20 9:09 UTC (permalink / raw)
To: Sascha Hauer, Russell King, Ben Dooks, Kukjin Kim, Samuel Ortiz
Cc: Mark Brown, linux-arm-kernel, linux-samsung-soc, linux-kernel
Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
custom wm8350 cache implementation") removed all their (actual) users.
Remove these symbols too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
0) This version adds Mark's ACK. It is now also sent to the ARM
maintainers, as Mark suggested.
1) Still only eyeball tested.
arch/arm/mach-imx/Kconfig | 2 --
arch/arm/mach-s3c64xx/Kconfig | 3 ---
drivers/mfd/Kconfig | 48 -------------------------------------------
3 files changed, 53 deletions(-)
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 4c9c6f9..6d9ae09 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -481,8 +481,6 @@ config MACH_MX31ADS_WM1133_EV1
depends on MACH_MX31ADS
depends on MFD_WM8350_I2C
depends on REGULATOR_WM8350 = y
- select MFD_WM8350_CONFIG_MODE_0
- select MFD_WM8352_CONFIG_MODE_0
help
Include support for the Wolfson Microelectronics 1133-EV1 PMU
and audio module for the MX31ADS platform.
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 131c862..041da51 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -198,10 +198,7 @@ endchoice
config SMDK6410_WM1190_EV1
bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
depends on MACH_SMDK6410
- select MFD_WM8350_CONFIG_MODE_0
- select MFD_WM8350_CONFIG_MODE_3
select MFD_WM8350_I2C
- select MFD_WM8352_CONFIG_MODE_0
select REGULATOR
select REGULATOR_WM8350
select SAMSUNG_GPIO_EXTRA64
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c346941..ebb1bed 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -687,54 +687,6 @@ config MFD_WM8350
bool
depends on GENERIC_HARDIRQS
-config MFD_WM8350_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8350_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8351_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_0
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_1
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_2
- bool
- depends on MFD_WM8350
-
-config MFD_WM8352_CONFIG_MODE_3
- bool
- depends on MFD_WM8350
-
config MFD_WM8350_I2C
bool "Support Wolfson Microelectronics WM8350 with I2C"
select MFD_WM8350
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v2] mfd: remove twelve unused Kconfig symbols
2013-03-20 9:09 ` [PATCH v2] " Paul Bolle
@ 2013-03-25 1:08 ` Kukjin Kim
2013-04-09 8:14 ` Samuel Ortiz
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-03-25 1:08 UTC (permalink / raw)
To: 'Paul Bolle', 'Sascha Hauer',
'Russell King', 'Ben Dooks',
'Samuel Ortiz'
Cc: 'Mark Brown', linux-arm-kernel, linux-samsung-soc, linux-kernel
Paul Bolle wrote:
>
> Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
> unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
> custom wm8350 cache implementation") removed all their (actual) users.
> Remove these symbols too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
> ---
> 0) This version adds Mark's ACK. It is now also sent to the ARM
> maintainers, as Mark suggested.
>
> 1) Still only eyeball tested.
>
> arch/arm/mach-imx/Kconfig | 2 --
> arch/arm/mach-s3c64xx/Kconfig | 3 ---
> drivers/mfd/Kconfig | 48 -----------------------------------------
> --
> 3 files changed, 53 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 4c9c6f9..6d9ae09 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -481,8 +481,6 @@ config MACH_MX31ADS_WM1133_EV1
> depends on MACH_MX31ADS
> depends on MFD_WM8350_I2C
> depends on REGULATOR_WM8350 = y
> - select MFD_WM8350_CONFIG_MODE_0
> - select MFD_WM8352_CONFIG_MODE_0
> help
> Include support for the Wolfson Microelectronics 1133-EV1 PMU
> and audio module for the MX31ADS platform.
> diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
> index 131c862..041da51 100644
> --- a/arch/arm/mach-s3c64xx/Kconfig
> +++ b/arch/arm/mach-s3c64xx/Kconfig
> @@ -198,10 +198,7 @@ endchoice
> config SMDK6410_WM1190_EV1
> bool "Support Wolfson Microelectronics 1190-EV1 PMIC card"
> depends on MACH_SMDK6410
> - select MFD_WM8350_CONFIG_MODE_0
> - select MFD_WM8350_CONFIG_MODE_3
> select MFD_WM8350_I2C
> - select MFD_WM8352_CONFIG_MODE_0
> select REGULATOR
> select REGULATOR_WM8350
> select SAMSUNG_GPIO_EXTRA64
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c346941..ebb1bed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -687,54 +687,6 @@ config MFD_WM8350
> bool
> depends on GENERIC_HARDIRQS
>
> -config MFD_WM8350_CONFIG_MODE_0
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_1
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_2
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8350_CONFIG_MODE_3
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_0
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_1
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_2
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8351_CONFIG_MODE_3
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_0
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_1
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_2
> - bool
> - depends on MFD_WM8350
> -
> -config MFD_WM8352_CONFIG_MODE_3
> - bool
> - depends on MFD_WM8350
> -
> config MFD_WM8350_I2C
> bool "Support Wolfson Microelectronics WM8350 with I2C"
> select MFD_WM8350
> --
> 1.7.11.7
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mfd: remove twelve unused Kconfig symbols
2013-03-20 9:09 ` [PATCH v2] " Paul Bolle
2013-03-25 1:08 ` Kukjin Kim
@ 2013-04-09 8:14 ` Samuel Ortiz
1 sibling, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2013-04-09 8:14 UTC (permalink / raw)
To: Paul Bolle
Cc: Sascha Hauer, Russell King, Ben Dooks, Kukjin Kim, Mark Brown,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Hi Paul,
On Wed, Mar 20, 2013 at 10:09:39AM +0100, Paul Bolle wrote:
> Twelve Kconfig symbols, all related to WM8350, WM8351, and WM8352, are
> unused. Commit 19d57ed5a308472a02e773f33c03ad4cb2ec6a9 ("mfd: Remove
> custom wm8350 cache implementation") removed all their (actual) users.
> Remove these symbols too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> 0) This version adds Mark's ACK. It is now also sent to the ARM
> maintainers, as Mark suggested.
>
> 1) Still only eyeball tested.
>
> arch/arm/mach-imx/Kconfig | 2 --
> arch/arm/mach-s3c64xx/Kconfig | 3 ---
> drivers/mfd/Kconfig | 48 -------------------------------------------
> 3 files changed, 53 deletions(-)
Applied to my mfd-next tree, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-09 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-19 22:38 [PATCH] mfd: remove twelve unused Kconfig symbols Paul Bolle
[not found] ` <20130320082427.GB28775@opensource.wolfsonmicro.com>
2013-03-20 9:09 ` [PATCH v2] " Paul Bolle
2013-03-25 1:08 ` Kukjin Kim
2013-04-09 8:14 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).