linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ashish Jangam <ashish.jangam@kpitcummins.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Axel Lin <axel.lin@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-kernel@vger.kernel.org>,
	David Dajun Chen <dchen@diasemi.com>
Subject: Re: [patch v1] mfd: da9055 change irq state to default
Date: Wed, 27 Mar 2013 13:00:32 +0530	[thread overview]
Message-ID: <1364369432.13582.0.camel@dhruva> (raw)
In-Reply-To: <1363597958.4228.7.camel@dhruva>

On Mon, 2013-03-18 at 14:42 +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low.
> Because the default PMIC irq state of DA9055 got changed from high to low.
> This change should not affect any of the existing users since all of them
> use active low state.
> 
> This patch has been tested on smdkv6410.
> 
> Signed-off-by: Ashish <ashish.jangam@kpitcummins.com>
> 
> ---
>  drivers/mfd/da9055-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index f56a1a9..49cb23d 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
>  		da9055->irq_base = pdata->irq_base;
>  
>  	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> -				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> +				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>  				  da9055->irq_base, &da9055_regmap_irq_chip,
>  				  &da9055->irq_data);
>  	if (ret < 0)
If there are no comments then can this patch get merged.



  reply	other threads:[~2013-03-27  7:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18  9:12 [patch v1] mfd: da9055 change irq state to default Ashish Jangam
2013-03-27  7:30 ` Ashish Jangam [this message]
2013-04-09  8:10 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364369432.13582.0.camel@dhruva \
    --to=ashish.jangam@kpitcummins.com \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dchen@diasemi.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).