linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Fei <fei.li@intel.com>
To: ohad@wizery.com, rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, fei.li@intel.com
Subject: [PATCH 5/5 V2] hwspinlock/core: call pm_runtime_put in pm_runtime_get_sync failed case
Date: Fri, 05 Apr 2013 21:20:36 +0800	[thread overview]
Message-ID: <1365168036.14760.4.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> (raw)
In-Reply-To: <1362038529.6212.22.camel@fli24-HP-Compaq-8100-Elite-CMT-PC>


Even in failed case of pm_runtime_get_sync, the usage_count
is incremented. In order to keep the usage_count with correct
value and runtime power management to behave correctly, call
pm_runtime_put(_sync) in such case.

In __hwspin_lock_request, module_put is also called before
return in pm_runtime_get_sync failed case.

Signed-off-by Liu Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Li Fei <fei.li@intel.com>
---
 drivers/hwspinlock/hwspinlock_core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c
index db713c0..461a0d7 100644
--- a/drivers/hwspinlock/hwspinlock_core.c
+++ b/drivers/hwspinlock/hwspinlock_core.c
@@ -416,6 +416,8 @@ static int __hwspin_lock_request(struct hwspinlock *hwlock)
 	ret = pm_runtime_get_sync(dev);
 	if (ret < 0) {
 		dev_err(dev, "%s: can't power on device\n", __func__);
+		pm_runtime_put_noidle(dev);
+		module_put(dev->driver->owner);
 		return ret;
 	}
 
-- 
1.7.4.1




  parent reply	other threads:[~2013-04-05 13:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28  7:37 [PATCH 1/5] regmap: irq: call pm_runtime_put in pm_runtime_get_sync failed case Li Fei
2013-02-28  7:44 ` [PATCH 2/5] mmc: core: call pm_runtime_put_sync " Li Fei
2013-02-28  7:51   ` [PATCH 3/5] wl1251: " Li Fei
2013-02-28  7:57     ` [PATCH 4/5] usb: " Li Fei
2013-02-28  8:02       ` [PATCH 5/5] hwspinlock/core: call pm_runtime_put " Li Fei
2013-04-05  6:27         ` Ohad Ben-Cohen
2013-04-05 11:39           ` Rafael J. Wysocki
2013-04-05 11:42             ` Rafael J. Wysocki
2013-04-05 13:13               ` Li, Fei
2013-04-05 13:20         ` Li Fei [this message]
2013-04-05 14:46           ` [PATCH 5/5 V2] " Ohad Ben-Cohen
2013-02-28  8:37       ` [PATCH 4/5] usb: call pm_runtime_put_sync " Lan Tianyu
2013-02-28  9:00         ` Li, Fei
2013-02-28 15:14         ` Alan Stern
2013-02-28  9:06       ` [PATCH 4/5 V2] " Li Fei
2013-02-28 15:17         ` Alan Stern
2013-03-01  0:38           ` Liu, Chuansheng
2013-03-01  0:50             ` Rafael J. Wysocki
2013-03-01  0:59               ` Liu, Chuansheng
2013-03-01  2:18                 ` Rafael J. Wysocki
2013-03-01  2:07         ` Liu, Chuansheng
2013-03-01  2:22           ` Rafael J. Wysocki
2013-03-01  2:23             ` Liu, Chuansheng
2013-03-01  2:57         ` [PATCH 4/5 V3] usb: call pm_runtime_put_noidle " Li Fei
2013-03-01  2:59         ` Li Fei
2013-02-28  8:18     ` [PATCH 3/5] wl1251: call pm_runtime_put_sync " Luciano Coelho
2013-03-05  8:51     ` Luciano Coelho
2013-04-07 10:39   ` [PATCH 2/5] mmc: core: " Ohad Ben-Cohen
2013-04-08  1:36     ` Li, Fei
2013-04-08  1:36   ` [PATCH 2/5 V2] mmc: core: call pm_runtime_put_noidle " Li Fei
2013-04-08 12:48     ` Ohad Ben-Cohen
2013-04-12 18:15       ` Chris Ball
2013-03-01  6:55 ` [PATCH 1/5] regmap: irq: call pm_runtime_put " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365168036.14760.4.camel@fli24-HP-Compaq-8100-Elite-CMT-PC \
    --to=fei.li@intel.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).