From: Alan Stern <stern@rowland.harvard.edu>
To: Li Fei <fei.li@intel.com>
Cc: gregkh@linuxfoundation.org, <tianyu.lan@intel.com>,
<sarah.a.sharp@linux.intel.com>, <rjw@sisk.pl>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chuansheng.liu@intel.com>
Subject: Re: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case
Date: Thu, 28 Feb 2013 10:17:02 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1302281015330.1352-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1362042384.6212.25.camel@fli24-HP-Compaq-8100-Elite-CMT-PC>
On Thu, 28 Feb 2013, Li Fei wrote:
>
> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value and runtime power management to behave correctly, call
> pm_runtime_put(_sync) in such case.
>
> Signed-off-by Liu Chuansheng <chuansheng.liu@intel.com>
> Signed-off-by: Li Fei <fei.li@intel.com>
> ---
> drivers/usb/core/hub.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 5480352..f72dede 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -3148,12 +3148,13 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
>
> if (port_dev->did_runtime_put) {
> status = pm_runtime_get_sync(&port_dev->dev);
> - port_dev->did_runtime_put = false;
> if (status < 0) {
> dev_dbg(&udev->dev, "can't resume usb port, status %d\n",
> status);
> + pm_runtime_put_sync(&port_dev->dev);
> return status;
> }
> + port_dev->did_runtime_put = false;
> }
I don't see much point in this. After a failed resume, the port's
runtime PM status is undefined. Whether or not you do a
pm_runtime_put_sync won't make any difference.
Alan Stern
next prev parent reply other threads:[~2013-02-28 15:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 7:37 [PATCH 1/5] regmap: irq: call pm_runtime_put in pm_runtime_get_sync failed case Li Fei
2013-02-28 7:44 ` [PATCH 2/5] mmc: core: call pm_runtime_put_sync " Li Fei
2013-02-28 7:51 ` [PATCH 3/5] wl1251: " Li Fei
2013-02-28 7:57 ` [PATCH 4/5] usb: " Li Fei
2013-02-28 8:02 ` [PATCH 5/5] hwspinlock/core: call pm_runtime_put " Li Fei
2013-04-05 6:27 ` Ohad Ben-Cohen
2013-04-05 11:39 ` Rafael J. Wysocki
2013-04-05 11:42 ` Rafael J. Wysocki
2013-04-05 13:13 ` Li, Fei
2013-04-05 13:20 ` [PATCH 5/5 V2] " Li Fei
2013-04-05 14:46 ` Ohad Ben-Cohen
2013-02-28 8:37 ` [PATCH 4/5] usb: call pm_runtime_put_sync " Lan Tianyu
2013-02-28 9:00 ` Li, Fei
2013-02-28 15:14 ` Alan Stern
2013-02-28 9:06 ` [PATCH 4/5 V2] " Li Fei
2013-02-28 15:17 ` Alan Stern [this message]
2013-03-01 0:38 ` Liu, Chuansheng
2013-03-01 0:50 ` Rafael J. Wysocki
2013-03-01 0:59 ` Liu, Chuansheng
2013-03-01 2:18 ` Rafael J. Wysocki
2013-03-01 2:07 ` Liu, Chuansheng
2013-03-01 2:22 ` Rafael J. Wysocki
2013-03-01 2:23 ` Liu, Chuansheng
2013-03-01 2:57 ` [PATCH 4/5 V3] usb: call pm_runtime_put_noidle " Li Fei
2013-03-01 2:59 ` Li Fei
2013-02-28 8:18 ` [PATCH 3/5] wl1251: call pm_runtime_put_sync " Luciano Coelho
2013-03-05 8:51 ` Luciano Coelho
2013-04-07 10:39 ` [PATCH 2/5] mmc: core: " Ohad Ben-Cohen
2013-04-08 1:36 ` Li, Fei
2013-04-08 1:36 ` [PATCH 2/5 V2] mmc: core: call pm_runtime_put_noidle " Li Fei
2013-04-08 12:48 ` Ohad Ben-Cohen
2013-04-12 18:15 ` Chris Ball
2013-03-01 6:55 ` [PATCH 1/5] regmap: irq: call pm_runtime_put " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1302281015330.1352-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=chuansheng.liu@intel.com \
--cc=fei.li@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sarah.a.sharp@linux.intel.com \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).