* linux-next: build failure after merge of the mfd tree @ 2013-04-08 4:21 Stephen Rothwell 2013-04-08 4:45 ` Alexander Shiyan 0 siblings, 1 reply; 9+ messages in thread From: Stephen Rothwell @ 2013-04-08 4:21 UTC (permalink / raw) To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Alexander Shiyan [-- Attachment #1: Type: text/plain, Size: 529 bytes --] Hi Samuel, After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). I have used the mfd tree from next-20130405 for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-08 4:21 linux-next: build failure after merge of the mfd tree Stephen Rothwell @ 2013-04-08 4:45 ` Alexander Shiyan 2013-04-08 9:22 ` Samuel Ortiz 0 siblings, 1 reply; 9+ messages in thread From: Alexander Shiyan @ 2013-04-08 4:45 UTC (permalink / raw) To: Stephen Rothwell; +Cc: Samuel Ortiz, linux-next, linux-kernel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 783 bytes --] Hello. > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > I have used the mfd tree from next-20130405 for today. This means that we do not have empty declarations for the of_xx functions in linux/of.h for !CONFIG_OF. OK to declare these functions or any other opinions? --- ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-08 4:45 ` Alexander Shiyan @ 2013-04-08 9:22 ` Samuel Ortiz 2013-04-08 16:27 ` Re[2]: " Alexander Shiyan 0 siblings, 1 reply; 9+ messages in thread From: Samuel Ortiz @ 2013-04-08 9:22 UTC (permalink / raw) To: Alexander Shiyan; +Cc: Stephen Rothwell, linux-next, linux-kernel Hi Alexander, On Mon, Apr 08, 2013 at 08:45:51AM +0400, Alexander Shiyan wrote: > Hello. > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > I have used the mfd tree from next-20130405 for today. > > This means that we do not have empty declarations for the > of_xx functions in linux/of.h for !CONFIG_OF. > OK to declare these functions or any other opinions? Ok with me, but you'd need to get Grant and Rob's ACK. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re[2]: linux-next: build failure after merge of the mfd tree 2013-04-08 9:22 ` Samuel Ortiz @ 2013-04-08 16:27 ` Alexander Shiyan 2013-04-09 7:20 ` Samuel Ortiz 0 siblings, 1 reply; 9+ messages in thread From: Alexander Shiyan @ 2013-04-08 16:27 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Stephen Rothwell, linux-next, linux-kernel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1978 bytes --] > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > > failed like this: > > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > > > I have used the mfd tree from next-20130405 for today. > > > > This means that we do not have empty declarations for the > > of_xx functions in linux/of.h for !CONFIG_OF. > > OK to declare these functions or any other opinions? > Ok with me, but you'd need to get Grant and Rob's ACK. I've revised my initial opinion and write ââa quick patch for fix this issue. >From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001 From: Alexander Shiyan <shc_work@mail.ru> Date: Mon, 8 Apr 2013 19:13:10 +0400 Subject: [PATCH] regulator: anatop: Make select dependency from HAVE_IMX_ANATOP symbol This patch make selection of anatop-regulator from HAVE_IMX_ANATOP kernel symbol. This fixes build kernel with syscon driver but without oftree support. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index a5d97ea..078932d 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -133,7 +133,7 @@ config REGULATOR_FAN53555 config REGULATOR_ANATOP tristate "Freescale i.MX on-chip ANATOP LDO regulators" - depends on MFD_SYSCON + depends on HAVE_IMX_ANATOP help Say y here to support Freescale i.MX on-chip ANATOP LDOs regulators. It is recommended that this option be -- 1.8.1.5 --- ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-08 16:27 ` Re[2]: " Alexander Shiyan @ 2013-04-09 7:20 ` Samuel Ortiz 2013-04-09 15:47 ` Re[2]: " Alexander Shiyan 0 siblings, 1 reply; 9+ messages in thread From: Samuel Ortiz @ 2013-04-09 7:20 UTC (permalink / raw) To: Alexander Shiyan; +Cc: Stephen Rothwell, linux-next, linux-kernel Hi Alexander, On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > > > failed like this: > > > > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > > > > > I have used the mfd tree from next-20130405 for today. > > > > > > This means that we do not have empty declarations for the > > > of_xx functions in linux/of.h for !CONFIG_OF. > > > OK to declare these functions or any other opinions? > > Ok with me, but you'd need to get Grant and Rob's ACK. > > I've revised my initial opinion and write a quick patch for fix this issue. > > From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001 > From: Alexander Shiyan <shc_work@mail.ru> > Date: Mon, 8 Apr 2013 19:13:10 +0400 > Subject: [PATCH] regulator: anatop: Make select dependency from > HAVE_IMX_ANATOP symbol > > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP > kernel symbol. This fixes build kernel with syscon driver but without > oftree support. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/regulator/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index a5d97ea..078932d 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -133,7 +133,7 @@ config REGULATOR_FAN53555 > > config REGULATOR_ANATOP > tristate "Freescale i.MX on-chip ANATOP LDO regulators" > - depends on MFD_SYSCON > + depends on HAVE_IMX_ANATOP This does look like a band-aid solution to me. Yes, it will fix the crash, but you're restricting this code to a much smaller architecture set. AFAIK linux-next is not tested on that arch, for example. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re[2]: linux-next: build failure after merge of the mfd tree 2013-04-09 7:20 ` Samuel Ortiz @ 2013-04-09 15:47 ` Alexander Shiyan 2013-04-09 16:12 ` Samuel Ortiz 0 siblings, 1 reply; 9+ messages in thread From: Alexander Shiyan @ 2013-04-09 15:47 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Stephen Rothwell, linux-next, linux-kernel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=utf-8, Size: 2618 bytes --] > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: > > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > > > > failed like this: > > > > > > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > > > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > > > > > > > I have used the mfd tree from next-20130405 for today. > > > > > > > > This means that we do not have empty declarations for the > > > > of_xx functions in linux/of.h for !CONFIG_OF. > > > > OK to declare these functions or any other opinions? > > > Ok with me, but you'd need to get Grant and Rob's ACK. ... > > Subject: [PATCH] regulator: anatop: Make select dependency from > > HAVE_IMX_ANATOP symbol > > > > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP > > kernel symbol. This fixes build kernel with syscon driver but without > > oftree support. ... > This does look like a band-aid solution to me. Yes, it will fix the crash, but > you're restricting this code to a much smaller architecture set. AFAIK > linux-next is not tested on that arch, for example. OK, the second solution: >From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001 From: Alexander Shiyan <shc_work@mail.ru> Date: Tue, 9 Apr 2013 19:41:27 +0400 Subject: [PATCH] of: add stub of_get_parent for non-OF builds Fixes build error on x86_64 allmodconfig, introduced by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- include/linux/of.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index a0f1292..9f5923f 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from, return NULL; } +static inline struct device_node *of_get_parent(const struct device_node *node) +{ + return NULL; +} + static inline bool of_have_populated_dt(void) { return false; -- 1.8.1.5 --- ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-09 15:47 ` Re[2]: " Alexander Shiyan @ 2013-04-09 16:12 ` Samuel Ortiz 2013-04-09 16:50 ` Rob Herring 0 siblings, 1 reply; 9+ messages in thread From: Samuel Ortiz @ 2013-04-09 16:12 UTC (permalink / raw) To: Alexander Shiyan; +Cc: Stephen Rothwell, linux-next, linux-kernel Hi Alexander, On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote: > > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: > > > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > > > > > failed like this: > > > > > > > > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > > > > > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > > > > > > > > > I have used the mfd tree from next-20130405 for today. > > > > > > > > > > This means that we do not have empty declarations for the > > > > > of_xx functions in linux/of.h for !CONFIG_OF. > > > > > OK to declare these functions or any other opinions? > > > > Ok with me, but you'd need to get Grant and Rob's ACK. > ... > > > Subject: [PATCH] regulator: anatop: Make select dependency from > > > HAVE_IMX_ANATOP symbol > > > > > > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP > > > kernel symbol. This fixes build kernel with syscon driver but without > > > oftree support. > ... > > This does look like a band-aid solution to me. Yes, it will fix the crash, but > > you're restricting this code to a much smaller architecture set. AFAIK > > linux-next is not tested on that arch, for example. > > OK, the second solution: > > From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001 > From: Alexander Shiyan <shc_work@mail.ru> > Date: Tue, 9 Apr 2013 19:41:27 +0400 > Subject: [PATCH] of: add stub of_get_parent for non-OF builds > > Fixes build error on x86_64 allmodconfig, introduced by commit > 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > include/linux/of.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/of.h b/include/linux/of.h > index a0f1292..9f5923f 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from, > return NULL; > } > > +static inline struct device_node *of_get_parent(const struct device_node *node) > +{ > + return NULL; > +} > + That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for it before merging it. Please look at MAINTAINERS and cc them on this thread. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-09 16:12 ` Samuel Ortiz @ 2013-04-09 16:50 ` Rob Herring 2013-04-09 20:51 ` Samuel Ortiz 0 siblings, 1 reply; 9+ messages in thread From: Rob Herring @ 2013-04-09 16:50 UTC (permalink / raw) To: Samuel Ortiz; +Cc: Alexander Shiyan, Stephen Rothwell, linux-next, linux-kernel On Tue, Apr 9, 2013 at 11:12 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > Hi Alexander, > > On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote: >> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: [...] >> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001 >> From: Alexander Shiyan <shc_work@mail.ru> >> Date: Tue, 9 Apr 2013 19:41:27 +0400 >> Subject: [PATCH] of: add stub of_get_parent for non-OF builds >> >> Fixes build error on x86_64 allmodconfig, introduced by commit >> 5ab3a89a741f ("mfd: syscon: Add non-DT support"). >> >> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': >> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] >> >> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> >> --- >> include/linux/of.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/linux/of.h b/include/linux/of.h >> index a0f1292..9f5923f 100644 >> --- a/include/linux/of.h >> +++ b/include/linux/of.h >> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from, >> return NULL; >> } >> >> +static inline struct device_node *of_get_parent(const struct device_node *node) >> +{ >> + return NULL; >> +} >> + > That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for > it before merging it. Please look at MAINTAINERS and cc them on this thread. Acked-by: Rob Herring <rob.herring@calxeda.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: linux-next: build failure after merge of the mfd tree 2013-04-09 16:50 ` Rob Herring @ 2013-04-09 20:51 ` Samuel Ortiz 0 siblings, 0 replies; 9+ messages in thread From: Samuel Ortiz @ 2013-04-09 20:51 UTC (permalink / raw) To: Rob Herring; +Cc: Alexander Shiyan, Stephen Rothwell, linux-next, linux-kernel Hi Rob, On Tue, Apr 09, 2013 at 11:50:30AM -0500, Rob Herring wrote: > On Tue, Apr 9, 2013 at 11:12 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > > > > On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote: > >> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: > > [...] > > >> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001 > >> From: Alexander Shiyan <shc_work@mail.ru> > >> Date: Tue, 9 Apr 2013 19:41:27 +0400 > >> Subject: [PATCH] of: add stub of_get_parent for non-OF builds > >> > >> Fixes build error on x86_64 allmodconfig, introduced by commit > >> 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > >> > >> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > >> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > >> > >> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > >> --- > >> include/linux/of.h | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/include/linux/of.h b/include/linux/of.h > >> index a0f1292..9f5923f 100644 > >> --- a/include/linux/of.h > >> +++ b/include/linux/of.h > >> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from, > >> return NULL; > >> } > >> > >> +static inline struct device_node *of_get_parent(const struct device_node *node) > >> +{ > >> + return NULL; > >> +} > >> + > > That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for > > it before merging it. Please look at MAINTAINERS and cc them on this thread. > > Acked-by: Rob Herring <rob.herring@calxeda.com> Thanks, I am pushing this patch through the mfd-next tree. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-09 20:51 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-04-08 4:21 linux-next: build failure after merge of the mfd tree Stephen Rothwell 2013-04-08 4:45 ` Alexander Shiyan 2013-04-08 9:22 ` Samuel Ortiz 2013-04-08 16:27 ` Re[2]: " Alexander Shiyan 2013-04-09 7:20 ` Samuel Ortiz 2013-04-09 15:47 ` Re[2]: " Alexander Shiyan 2013-04-09 16:12 ` Samuel Ortiz 2013-04-09 16:50 ` Rob Herring 2013-04-09 20:51 ` Samuel Ortiz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).