From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH] checkpatch: Warn on comparisons to true and false
Date: Wed, 10 Apr 2013 18:07:17 -0700 [thread overview]
Message-ID: <1365642437.2036.5.camel@joe-AO722> (raw)
In-Reply-To: <20130410155751.7ecc6738d616fb8771991ce1@linux-foundation.org>
On Wed, 2013-04-10 at 15:57 -0700, Andrew Morton wrote:
> On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches <joe@perches.com> wrote:
> > Comparisons of A to true and false are better written
> > as A and !A.
> > Bleat a message on use.
> hm. I'm counting around 1,100 instances of "== true" and "== false".
And about all of them in are staging, where I think they
really should be fixed.
$ find . -maxdepth 2 -type d \
while read file ; do \
echo "$(git grep -E '(==|\!=)\s*(true|false)' $file | wc -l) $file"; \
done | sort -rn | head -10
1375 .
1298 ./drivers
1055 ./drivers/staging
63 ./drivers/net
59 ./drivers/gpu
24 ./net
20 ./drivers/media
17 ./net/nfc
13 ./fs
11 ./drivers/usb
> That's a lot of people to shout at.
Not really.
> Is it really worthwhile?
I think so.
next prev parent reply other threads:[~2013-04-11 1:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 3:17 [PATCH] checkpatch: Warn on comparisons to true and false Joe Perches
2013-04-10 9:33 ` Andy Whitcroft
2013-04-10 11:27 ` Joe Perches
2013-04-10 12:41 ` Andy Whitcroft
2013-04-10 22:57 ` Andrew Morton
2013-04-11 1:07 ` Joe Perches [this message]
2013-04-11 2:14 ` Dave Jones
2013-04-11 3:47 ` Joe Perches
2013-04-11 8:19 ` Dan Carpenter
2013-04-11 8:29 ` Joe Perches
2013-04-11 11:56 ` Bjørn Mork
2013-04-11 14:25 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365642437.2036.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).