[PATCH 3.8-stable] thermal: return an error on failure to register thermal

[PATCH 3.8-stable] thermal: return an error on failure to register thermal

[Jonghwan Choi]

3.8-stable review patch.  If anyone has any objections, please let me know.

------------------

From: "Richard Guy Briggs <rbriggs@redhat.com>"

commit da28d966f6aa942ae836d09729f76a1647932309 upstream.

The return code from the registration of the thermal class is used to
unallocate resources, but this failure isn't passed back to the caller of
thermal_init.  Return this failure back to the caller.

This bug was introduced in changeset 4cb18728 which overwrote the return
code
when the variable was re-used to catch the return code of the registration
of
the genetlink thermal socket family.

Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/thermal/thermal_sys.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
index 6472e7e..1a19a2f 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -1875,6 +1875,7 @@ static int __init thermal_init(void)
 		idr_destroy(&thermal_cdev_idr);
 		mutex_destroy(&thermal_idr_lock);
 		mutex_destroy(&thermal_list_lock);
+		return result;
 	}
 	result = genetlink_init();
 	return result;
-- 
1.7.9.5

Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal

[Luis Henriques]

On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch.  If anyone has any objections, please let me know.

I believe this is applicable to all the other stable kernels.

Cheers,
--
Luis

> 
> ------------------
> 
> From: "Richard Guy Briggs <rbriggs@redhat.com>"
> 
> commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> 
> The return code from the registration of the thermal class is used to
> unallocate resources, but this failure isn't passed back to the caller of
> thermal_init.  Return this failure back to the caller.
> 
> This bug was introduced in changeset 4cb18728 which overwrote the return
> code
> when the variable was re-used to catch the return code of the registration
> of
> the genetlink thermal socket family.
> 
> Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/thermal/thermal_sys.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index 6472e7e..1a19a2f 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -1875,6 +1875,7 @@ static int __init thermal_init(void)
>  		idr_destroy(&thermal_cdev_idr);
>  		mutex_destroy(&thermal_idr_lock);
>  		mutex_destroy(&thermal_list_lock);
> +		return result;
>  	}
>  	result = genetlink_init();
>  	return result;
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal

[Greg KH]

On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch.  If anyone has any objections, please let me know.

Ok, I object, given that I told you to change the format of the message
you send out.  Please look at how others on the stable@ mailing list
send "should this patch be applied" messages, and copy how that is done.

> ------------------
> 
> From: "Richard Guy Briggs <rbriggs@redhat.com>"
> 
> commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> 
> The return code from the registration of the thermal class is used to
> unallocate resources, but this failure isn't passed back to the caller of
> thermal_init.  Return this failure back to the caller.
> 
> This bug was introduced in changeset 4cb18728 which overwrote the return
> code
> when the variable was re-used to catch the return code of the registration
> of
> the genetlink thermal socket family.

You linewrapped the patch message, careful, you might mess up the patch
itself as well :(

> Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

You aren't signing off on it as well?  Why not?

thanks,

greg k-h

Re: [PATCH 3.8-stable] thermal: return an error on failure to register thermal

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

On Wed, 2013-04-03 at 15:47 +0100, Luis Henriques wrote:
> On Wed, Apr 03, 2013 at 09:38:55AM +0900, Jonghwan Choi wrote:
> > 3.8-stable review patch.  If anyone has any objections, please let me know.
> 
> I believe this is applicable to all the other stable kernels.

Queued up for 3.2, thanks.

Ben.

> Cheers,
> --
> Luis
> 
> > 
> > ------------------
> > 
> > From: "Richard Guy Briggs <rbriggs@redhat.com>"
> > 
> > commit da28d966f6aa942ae836d09729f76a1647932309 upstream.
> > 
> > The return code from the registration of the thermal class is used to
> > unallocate resources, but this failure isn't passed back to the caller of
> > thermal_init.  Return this failure back to the caller.
> > 
> > This bug was introduced in changeset 4cb18728 which overwrote the return
> > code
> > when the variable was re-used to catch the return code of the registration
> > of
> > the genetlink thermal socket family.
> > 
> > Signed-off-by: Richard Guy Briggs <rbriggs@redhat.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> >  drivers/thermal/thermal_sys.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> > index 6472e7e..1a19a2f 100644
> > --- a/drivers/thermal/thermal_sys.c
> > +++ b/drivers/thermal/thermal_sys.c
> > @@ -1875,6 +1875,7 @@ static int __init thermal_init(void)
> >  		idr_destroy(&thermal_cdev_idr);
> >  		mutex_destroy(&thermal_idr_lock);
> >  		mutex_destroy(&thermal_list_lock);
> > +		return result;
> >  	}
> >  	result = genetlink_init();
> >  	return result;
> > -- 
> > 1.7.9.5
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe stable" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]