* [PATCH] gpio: stmpe: Staticize non-exported symbols
@ 2013-05-10 9:32 Axel Lin
2013-05-10 14:29 ` Lee Jones
2013-05-30 16:49 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-05-10 9:32 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: Lee Jones, Rabin Vincent, linux-kernel
Both stmpe_gpio_irq_map() and stmpe_gpio_irq_unmap() are not referenced
outside of this file, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-stmpe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
index 3ce5bc3..987da1d 100644
--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -271,8 +271,8 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
return IRQ_HANDLED;
}
-int stmpe_gpio_irq_map(struct irq_domain *d, unsigned int virq,
- irq_hw_number_t hwirq)
+static int stmpe_gpio_irq_map(struct irq_domain *d, unsigned int virq,
+ irq_hw_number_t hwirq)
{
struct stmpe_gpio *stmpe_gpio = d->host_data;
@@ -292,7 +292,7 @@ int stmpe_gpio_irq_map(struct irq_domain *d, unsigned int virq,
return 0;
}
-void stmpe_gpio_irq_unmap(struct irq_domain *d, unsigned int virq)
+static void stmpe_gpio_irq_unmap(struct irq_domain *d, unsigned int virq)
{
#ifdef CONFIG_ARM
set_irq_flags(virq, 0);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: stmpe: Staticize non-exported symbols
2013-05-10 9:32 [PATCH] gpio: stmpe: Staticize non-exported symbols Axel Lin
@ 2013-05-10 14:29 ` Lee Jones
2013-05-30 16:49 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-05-10 14:29 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Linus Walleij, Rabin Vincent, linux-kernel
On Fri, 10 May 2013, Axel Lin wrote:
> Both stmpe_gpio_irq_map() and stmpe_gpio_irq_unmap() are not referenced
> outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-stmpe.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: stmpe: Staticize non-exported symbols
2013-05-10 9:32 [PATCH] gpio: stmpe: Staticize non-exported symbols Axel Lin
2013-05-10 14:29 ` Lee Jones
@ 2013-05-30 16:49 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-05-30 16:49 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Lee Jones, Rabin Vincent, linux-kernel
On Fri, May 10, 2013 at 11:32 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Both stmpe_gpio_irq_map() and stmpe_gpio_irq_unmap() are not referenced
> outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Lee's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 9:32 [PATCH] gpio: stmpe: Staticize non-exported symbols Axel Lin
2013-05-10 14:29 ` Lee Jones
2013-05-30 16:49 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).