From: Joe Perches <joe@perches.com>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] BusLogic: Message logging neatening
Date: Fri, 17 May 2013 13:35:23 -0700 [thread overview]
Message-ID: <1368822923.2194.95.camel@joe-AO722> (raw)
In-Reply-To: <1368821880.24376.0.camel@concerto>
On Fri, 2013-05-17 at 14:18 -0600, Khalid Aziz wrote:
> On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote:
> > If you're going through the trouble to fix this CamelCase stuff
> > and make it work on 64 bit, how about a little more cleanup?
>
> Sounds good to me.
btw, for the BusLogic code:
There seem to be places where addresses are cast to u32.
I don't know the code at all, but that could likely
cause problems with 64 bit addresses.
$ git grep "(u32)" drivers/scsi/BusLogic.c
drivers/scsi/BusLogic.c: ccb->dma_handle = (u32) blkp + offset;
drivers/scsi/BusLogic.c: fpinfo->base_addr = (u32) adapter->io_addr;
drivers/scsi/BusLogic.c: extmbox_req.base_mbox_addr = (u32) adapter->mbox_space_handle;
next prev parent reply other threads:[~2013-05-17 20:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 1:44 [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
2013-05-17 1:44 ` [PATCH v2 1/2] scsi: Fix style issues in buslogic driver Khalid Aziz
2013-05-17 1:44 ` [PATCH v2 2/2] scsi: 64-bit port of " Khalid Aziz
2013-06-24 21:07 ` [PATCH RESEND " Dave Jones
2013-06-24 21:16 ` Khalid Aziz
2013-06-27 1:34 ` James Bottomley
2013-05-17 4:58 ` [PATCH 0/3] BusLogic: Message logging neatening Joe Perches
2013-05-17 4:58 ` [PATCH 1/3] BusLogic: Add __printf verification, fix fallout Joe Perches
2013-05-17 20:18 ` Khalid Aziz
2013-05-17 4:58 ` [PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments Joe Perches
2013-05-17 20:19 ` Khalid Aziz
2013-05-17 4:58 ` [PATCH 3/3] BusLogic: Use more conventional argument order for logging Joe Perches
2013-05-17 20:19 ` Khalid Aziz
2013-05-17 20:18 ` [PATCH 0/3] BusLogic: Message logging neatening Khalid Aziz
2013-05-17 20:35 ` Joe Perches [this message]
2013-05-17 20:59 ` Khalid Aziz
2013-06-14 15:07 ` [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
2013-06-24 20:25 [PATCH RESEND " Khalid Aziz
2013-06-24 20:55 ` James Bottomley
2013-06-24 21:17 ` Khalid Aziz
2013-06-24 21:45 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368822923.2194.95.camel@joe-AO722 \
--to=joe@perches.com \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).