From: Dave Jones <davej@redhat.com>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Khalid Aziz <khalid@gonehiking.org>
Subject: Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver
Date: Mon, 24 Jun 2013 17:07:47 -0400 [thread overview]
Message-ID: <20130624210747.GA19721@redhat.com> (raw)
In-Reply-To: <97daf2d29ceb78bdef3ddf6358dc634de35d0345.1368754556.git.khalid.aziz@oracle.com>
On Mon, Jun 24, 2013 at 02:26:00PM -0600, Khalid Aziz wrote:
> @@ -821,7 +821,7 @@ struct blogic_ccb {
> unsigned char cdblen; /* Byte 2 */
> unsigned char sense_datalen; /* Byte 3 */
> u32 datalen; /* Bytes 4-7 */
> - u32 data; /* Bytes 8-11 */
> + void *data; /* Bytes 8-11 */
The comment (and subsequent ones for this struct) are now wrong on 64-bit.
More of a concern though is that above this struct is this...
/*
Define the 32 Bit Mode Command Control Block (CCB) structure. The first 40
bytes are defined by and common to both the MultiMaster Firmware and the
FlashPoint SCCB Manager.
Is it safe to change this if the firmware/3rd party sw is expecting it to be a u32 ?
Dave
next prev parent reply other threads:[~2013-06-24 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 1:44 [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
2013-05-17 1:44 ` [PATCH v2 1/2] scsi: Fix style issues in buslogic driver Khalid Aziz
2013-05-17 1:44 ` [PATCH v2 2/2] scsi: 64-bit port of " Khalid Aziz
2013-06-24 21:07 ` Dave Jones [this message]
2013-06-24 21:16 ` [PATCH RESEND " Khalid Aziz
2013-06-27 1:34 ` James Bottomley
2013-05-17 4:58 ` [PATCH 0/3] BusLogic: Message logging neatening Joe Perches
2013-05-17 4:58 ` [PATCH 1/3] BusLogic: Add __printf verification, fix fallout Joe Perches
2013-05-17 20:18 ` Khalid Aziz
2013-05-17 4:58 ` [PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments Joe Perches
2013-05-17 20:19 ` Khalid Aziz
2013-05-17 4:58 ` [PATCH 3/3] BusLogic: Use more conventional argument order for logging Joe Perches
2013-05-17 20:19 ` Khalid Aziz
2013-05-17 20:18 ` [PATCH 0/3] BusLogic: Message logging neatening Khalid Aziz
2013-05-17 20:35 ` Joe Perches
2013-05-17 20:59 ` Khalid Aziz
2013-06-14 15:07 ` [PATCH v2 0/2] scsi: Port buslogic driver to 64 bits Khalid Aziz
2013-06-24 20:25 [PATCH RESEND " Khalid Aziz
2013-06-24 20:55 ` James Bottomley
2013-06-24 21:17 ` Khalid Aziz
2013-06-24 21:45 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624210747.GA19721@redhat.com \
--to=davej@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=khalid.aziz@oracle.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).