* [PATCH 0/2] staging/asus_oled fixed style issues
@ 2013-06-05 10:50 Matthias Schid
2013-06-05 10:50 ` [PATCH 1/2] staging/asus_oled fixed alignment in defines Matthias Schid
2013-06-05 10:50 ` [PATCH 2/2] staging/asus_oled fixed linebreak style issue Matthias Schid
0 siblings, 2 replies; 5+ messages in thread
From: Matthias Schid @ 2013-06-05 10:50 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, sjakub, jonbrett.dev, cruz, joe, devel,
linux-kernel, steffhip, simon.puels, Matthias Schid
fixed alignment issue and a linebreak issue reported
by checkpatch.pl in asus_oled
Matthias Schid (2):
staging/asus_oled fixed alignment in defines
staging/asus_oled fixed linebreak style issue
drivers/staging/asus_oled/asus_oled.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging/asus_oled fixed alignment in defines
2013-06-05 10:50 [PATCH 0/2] staging/asus_oled fixed style issues Matthias Schid
@ 2013-06-05 10:50 ` Matthias Schid
2013-06-05 10:50 ` [PATCH 2/2] staging/asus_oled fixed linebreak style issue Matthias Schid
1 sibling, 0 replies; 5+ messages in thread
From: Matthias Schid @ 2013-06-05 10:50 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, sjakub, jonbrett.dev, cruz, joe, devel,
linux-kernel, steffhip, simon.puels, Matthias Schid
replaced spaces in incorrect alignment in defines with tabs
Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 4598a2f..173fb9a 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -50,9 +50,9 @@
#define ASUS_OLED_DISP_HEIGHT 32
#define ASUS_OLED_PACKET_BUF_SIZE 256
-#define USB_VENDOR_ID_ASUS 0x0b05
-#define USB_DEVICE_ID_ASUS_LCM 0x1726
-#define USB_DEVICE_ID_ASUS_LCM2 0x175b
+#define USB_VENDOR_ID_ASUS 0x0b05
+#define USB_DEVICE_ID_ASUS_LCM 0x1726
+#define USB_DEVICE_ID_ASUS_LCM2 0x175b
MODULE_AUTHOR("Jakub Schmidtke, sjakub@gmail.com");
MODULE_DESCRIPTION("Asus OLED Driver");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging/asus_oled fixed linebreak style issue
2013-06-05 10:50 [PATCH 0/2] staging/asus_oled fixed style issues Matthias Schid
2013-06-05 10:50 ` [PATCH 1/2] staging/asus_oled fixed alignment in defines Matthias Schid
@ 2013-06-05 10:50 ` Matthias Schid
2013-06-05 11:15 ` Dan Carpenter
1 sibling, 1 reply; 5+ messages in thread
From: Matthias Schid @ 2013-06-05 10:50 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, sjakub, jonbrett.dev, cruz, joe, devel,
linux-kernel, steffhip, simon.puels, Matthias Schid
fixed a linebreak within an error message string coding style
issue reported by checkpatch.pl
Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 173fb9a..a7cd65a 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
}
if (i >= odev->buf_size) {
- dev_err(odev->dev, "Buffer overflow! Report a bug:"
- "offs: %d >= %d i: %d (x: %d y: %d)\n",
+ dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %d >= %d i: %d (x: %d y: %d)\n",
(int) odev->buf_offs, (int) odev->buf_size,
(int) i, (int) x, (int) y);
return -EIO;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] staging/asus_oled fixed linebreak style issue
2013-06-05 10:50 ` [PATCH 2/2] staging/asus_oled fixed linebreak style issue Matthias Schid
@ 2013-06-05 11:15 ` Dan Carpenter
2013-06-05 12:04 ` [PATCH 2/2] staging/asus_oled fixed linebreak and printk issue Matthias Schid
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2013-06-05 11:15 UTC (permalink / raw)
To: Matthias Schid
Cc: gregkh, devel, cruz, jonbrett.dev, linux-kernel, linux-kernel,
sjakub, joe, steffhip, simon.puels
On Wed, Jun 05, 2013 at 12:50:45PM +0200, Matthias Schid wrote:
> fixed a linebreak within an error message string coding style
> issue reported by checkpatch.pl
>
> Signed-off-by: Matthias Schid <aircrach115@gmail.com>
> Signed-off-by: Stefan Huber <steffhip@googlemail.com>
> Signed-off-by: Simon Puels <simon.puels@gmail.com>
> ---
> drivers/staging/asus_oled/asus_oled.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 173fb9a..a7cd65a 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
> }
>
> if (i >= odev->buf_size) {
> - dev_err(odev->dev, "Buffer overflow! Report a bug:"
> - "offs: %d >= %d i: %d (x: %d y: %d)\n",
> + dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %d >= %d i: %d (x: %d y: %d)\n",
> (int) odev->buf_offs, (int) odev->buf_size,
> (int) i, (int) x, (int) y);
This could be improved:
dev_err(odev->dev,
"Buffer overflow! Report a bug: offs: %zu >= %d i: %zu (x: %zu y: %zu)\n",
odev->buf_offs, odev->buf_size, i, x, y);
Printk fromats are documented in Documentation/printk-formats.txt.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging/asus_oled fixed linebreak and printk issue
2013-06-05 11:15 ` Dan Carpenter
@ 2013-06-05 12:04 ` Matthias Schid
0 siblings, 0 replies; 5+ messages in thread
From: Matthias Schid @ 2013-06-05 12:04 UTC (permalink / raw)
To: gregkh
Cc: linux-kernel, sjakub, jonbrett.dev, cruz, joe, devel,
linux-kernel, steffhip, simon.puels, Matthias Schid
fixed a linebreak within an error message string coding style
issue reported by checkpatch.pl and dev_err format parameters
Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
drivers/staging/asus_oled/asus_oled.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 173fb9a..9fe13d0 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -383,10 +383,8 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
}
if (i >= odev->buf_size) {
- dev_err(odev->dev, "Buffer overflow! Report a bug:"
- "offs: %d >= %d i: %d (x: %d y: %d)\n",
- (int) odev->buf_offs, (int) odev->buf_size,
- (int) i, (int) x, (int) y);
+ dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %zu >= %zu i: %zu (x: %zu y: %zu)\n",
+ odev->buf_offs, odev->buf_size, i, x, y);
return -EIO;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-05 12:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 10:50 [PATCH 0/2] staging/asus_oled fixed style issues Matthias Schid
2013-06-05 10:50 ` [PATCH 1/2] staging/asus_oled fixed alignment in defines Matthias Schid
2013-06-05 10:50 ` [PATCH 2/2] staging/asus_oled fixed linebreak style issue Matthias Schid
2013-06-05 11:15 ` Dan Carpenter
2013-06-05 12:04 ` [PATCH 2/2] staging/asus_oled fixed linebreak and printk issue Matthias Schid
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).