linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <grant.likely@linaro.org>, <tony@atomide.com>, <balbi@ti.com>,
	<kishon@ti.com>, <arnd@arndb.de>, <swarren@nvidia.com>,
	<sylvester.nawrocki@gmail.com>, <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-usb@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<akpm@linux-foundation.org>
Cc: <rob.herring@calxeda.com>, <rob@landley.net>, <b-cousson@ti.com>,
	<linux@arm.linux.org.uk>, <benoit.cousson@linaro.org>,
	<mchehab@redhat.com>, <cesarb@cesarb.net>, <davem@davemloft.net>,
	<rnayak@ti.com>, <shawn.guo@linaro.org>,
	<santosh.shilimkar@ti.com>, <devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <nsekhar@ti.com>
Subject: [PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
Date: Thu, 13 Jun 2013 14:13:58 +0530	[thread overview]
Message-ID: <1371113039-5784-9-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1371113039-5784-1-git-send-email-kishon@ti.com>

Now that omap-usb2 is adapted to the new generic PHY framework,
*set_suspend* ops can be removed from omap-usb2 driver.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/usb/phy/phy-omap-usb2.c |   24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c
index 3c275e7..bd2e4ca 100644
--- a/drivers/usb/phy/phy-omap-usb2.c
+++ b/drivers/usb/phy/phy-omap-usb2.c
@@ -97,29 +97,6 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,
 	return 0;
 }
 
-static int omap_usb2_suspend(struct usb_phy *x, int suspend)
-{
-	u32 ret;
-	struct omap_usb *phy = phy_to_omapusb(x);
-
-	if (suspend && !phy->is_suspended) {
-		omap_control_usb_phy_power(phy->control_dev, 0);
-		pm_runtime_put_sync(phy->dev);
-		phy->is_suspended = 1;
-	} else if (!suspend && phy->is_suspended) {
-		ret = pm_runtime_get_sync(phy->dev);
-		if (ret < 0) {
-			dev_err(phy->dev, "get_sync failed with err %d\n",
-									ret);
-			return ret;
-		}
-		omap_control_usb_phy_power(phy->control_dev, 1);
-		phy->is_suspended = 0;
-	}
-
-	return 0;
-}
-
 static int omap_usb_power_off(struct phy *x)
 {
 	struct omap_usb *phy = dev_get_drvdata(&x->dev);
@@ -167,7 +144,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 
 	phy->phy.dev		= phy->dev;
 	phy->phy.label		= "omap-usb2";
-	phy->phy.set_suspend	= omap_usb2_suspend;
 	phy->phy.otg		= otg;
 	phy->phy.type		= USB_PHY_TYPE_USB2;
 
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-13  8:48 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  8:43 [PATCH v7 0/9] Generic PHY Framework Kishon Vijay Abraham I
2013-06-13  8:43 ` [PATCH v7 1/9] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-06-18  9:38   ` Felipe Balbi
2013-06-18 21:22   ` Sylwester Nawrocki
2013-06-24  6:37     ` Kishon Vijay Abraham I
2013-06-19 15:49   ` Sylwester Nawrocki
2013-06-20  5:28     ` Kishon Vijay Abraham I
2013-06-13  8:43 ` [PATCH v7 2/9] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-06-18  9:40   ` Felipe Balbi
2013-06-18  9:49     ` Kishon Vijay Abraham I
2013-06-18  9:50       ` Felipe Balbi
2013-06-18  9:56         ` Kishon Vijay Abraham I
2013-06-18 10:00           ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 3/9] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-06-18  9:42   ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall Kishon Vijay Abraham I
2013-06-18  9:43   ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-06-18  9:44   ` Felipe Balbi
2013-06-18 10:04     ` Kishon Vijay Abraham I
2013-06-18 10:27       ` Felipe Balbi
2013-06-18 11:13         ` Kishon Vijay Abraham I
2013-06-18 12:35           ` Felipe Balbi
2013-06-18 14:55             ` Kishon Vijay Abraham I
2013-06-18 14:57               ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 6/9] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-06-18  9:45   ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-06-18  9:47   ` Felipe Balbi
2013-06-24  5:31     ` Kishon Vijay Abraham I
2013-06-24  6:37       ` Felipe Balbi
2013-06-13  8:43 ` Kishon Vijay Abraham I [this message]
2013-06-18  9:47   ` [PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-06-18  9:47   ` Felipe Balbi
2013-06-17 10:16 ` [PATCH v7 0/9] Generic PHY Framework Sylwester Nawrocki
2013-06-18  9:49   ` Felipe Balbi
2013-06-24 19:27     ` Sylwester Nawrocki
2013-06-24 19:34       ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371113039-5784-9-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=benoit.cousson@linaro.org \
    --cc=cesarb@cesarb.net \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mchehab@redhat.com \
    --cc=nsekhar@ti.com \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=shawn.guo@linaro.org \
    --cc=swarren@nvidia.com \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).