From: Kishon Vijay Abraham I <kishon@ti.com>
To: <balbi@ti.com>
Cc: <grant.likely@linaro.org>, <tony@atomide.com>, <arnd@arndb.de>,
<swarren@nvidia.com>, <sylvester.nawrocki@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<akpm@linux-foundation.org>, <rob.herring@calxeda.com>,
<rob@landley.net>, <b-cousson@ti.com>, <linux@arm.linux.org.uk>,
<benoit.cousson@linaro.org>, <mchehab@redhat.com>,
<cesarb@cesarb.net>, <davem@davemloft.net>, <rnayak@ti.com>,
<shawn.guo@linaro.org>, <santosh.shilimkar@ti.com>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <nsekhar@ti.com>
Subject: Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework
Date: Tue, 18 Jun 2013 15:26:23 +0530 [thread overview]
Message-ID: <51C02EC7.7060908@ti.com> (raw)
In-Reply-To: <20130618095040.GZ5461@arwen.pp.htv.fi>
Hi,
On Tuesday 18 June 2013 03:20 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jun 18, 2013 at 03:19:03PM +0530, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote:
>>>> @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev)
>>>> otg->start_srp = omap_usb_start_srp;
>>>> otg->phy = &phy->phy;
>>>>
>>>> + pm_runtime_enable(phy->dev);
>>>
>>> enabling pm_runtime here has the potential to cause a real big problem.
>>> How have you tested this patch ?
>>
>> performed boot and enumeration testing. What issue do you expect here?
>
> hint: look at drvdata usage around the driver. Where is it initialized ?
> Where is it used ?
hmm.. since runtime_get calls weren't made very early, I think I dint
see any issues. Thanks for pointing this.
Thanks
Kishon
next prev parent reply other threads:[~2013-06-18 9:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 8:43 [PATCH v7 0/9] Generic PHY Framework Kishon Vijay Abraham I
2013-06-13 8:43 ` [PATCH v7 1/9] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-06-18 9:38 ` Felipe Balbi
2013-06-18 21:22 ` Sylwester Nawrocki
2013-06-24 6:37 ` Kishon Vijay Abraham I
2013-06-19 15:49 ` Sylwester Nawrocki
2013-06-20 5:28 ` Kishon Vijay Abraham I
2013-06-13 8:43 ` [PATCH v7 2/9] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-06-18 9:40 ` Felipe Balbi
2013-06-18 9:49 ` Kishon Vijay Abraham I
2013-06-18 9:50 ` Felipe Balbi
2013-06-18 9:56 ` Kishon Vijay Abraham I [this message]
2013-06-18 10:00 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 3/9] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-06-18 9:42 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall Kishon Vijay Abraham I
2013-06-18 9:43 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-06-18 9:44 ` Felipe Balbi
2013-06-18 10:04 ` Kishon Vijay Abraham I
2013-06-18 10:27 ` Felipe Balbi
2013-06-18 11:13 ` Kishon Vijay Abraham I
2013-06-18 12:35 ` Felipe Balbi
2013-06-18 14:55 ` Kishon Vijay Abraham I
2013-06-18 14:57 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 6/9] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-06-18 9:45 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-06-18 9:47 ` Felipe Balbi
2013-06-24 5:31 ` Kishon Vijay Abraham I
2013-06-24 6:37 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-06-18 9:47 ` Felipe Balbi
2013-06-13 8:43 ` [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-06-18 9:47 ` Felipe Balbi
2013-06-17 10:16 ` [PATCH v7 0/9] Generic PHY Framework Sylwester Nawrocki
2013-06-18 9:49 ` Felipe Balbi
2013-06-24 19:27 ` Sylwester Nawrocki
2013-06-24 19:34 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C02EC7.7060908@ti.com \
--to=kishon@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@redhat.com \
--cc=nsekhar@ti.com \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@nvidia.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).