From: Ben Hutchings <ben@decadent.org.uk>
To: Xiong Zhou <jencce.kernel@gmail.com>
Cc: matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
jim.epost@gmail.com
Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig
Date: Tue, 18 Jun 2013 14:04:40 +0100 [thread overview]
Message-ID: <1371560680.3495.121.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1306181705530.28460@M2420>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
> From: Xiong Zhou <jencce.kernel@gmail.com>
>
> Fix randconfig build failure for Amilo x86 platform driver.
> AMILO_RFKILL requires SERIO_I8042 being available.
>
> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
Acked-by: Ben Hutchings <ben@decadent.org.uk>
But I thought somehow sent this same fix a while back...
Ben.
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8577261..37645b9 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
> config AMILO_RFKILL
> tristate "Fujitsu-Siemens Amilo rfkill support"
> depends on RFKILL
> + depends on SERIO_I8042
> ---help---
> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
> laptops.
--
Ben Hutchings
Humans are not rational beings; they are rationalising beings.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-06-18 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 9:21 [PATCH]amilo-rfkill: add depends on i8042 in Kconfig Xiong Zhou
2013-06-18 13:04 ` Ben Hutchings [this message]
2013-06-18 15:00 ` Randy Dunlap
2013-06-19 1:09 ` Xiong Zhou
2013-06-27 16:40 ` Randy Dunlap
2013-07-12 3:46 ` Xiong Zhou
2013-08-20 11:05 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371560680.3495.121.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=jencce.kernel@gmail.com \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).