From: Xiong Zhou <jencce.kernel@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ben Hutchings <ben@decadent.org.uk>,
matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org,
Linux-Next <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jim Davis <jim.epost@gmail.com>, Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig
Date: Fri, 12 Jul 2013 11:46:30 +0800 [thread overview]
Message-ID: <CADJHv_sSn9oU-xg5qgoHRKDeyHRCqy8VuPJW5_punHd45inzsA@mail.gmail.com> (raw)
In-Reply-To: <51CC6B09.5080809@infradead.org>
2013/6/28 Randy Dunlap <rdunlap@infradead.org>:
> On 06/18/13 18:09, Xiong Zhou wrote:
>> 2013/6/18 Randy Dunlap <rdunlap@infradead.org>:
>>> On 06/18/13 06:04, Ben Hutchings wrote:
>>>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
>>>>> From: Xiong Zhou <jencce.kernel@gmail.com>
>>>>>
>>>>> Fix randconfig build failure for Amilo x86 platform driver.
>>>>> AMILO_RFKILL requires SERIO_I8042 being available.
>>>>>
>>>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
>>>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
>>>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>>>>>
>>>>> Reported-by: Jim Davis <jim.epost@gmail.com>
>>>>> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
>>>>
>>>> Acked-by: Ben Hutchings <ben@decadent.org.uk>
>>>>
>>>> But I thought somehow sent this same fix a while back...
>>>
>>> Yes, I reported it and sent a patch for it that you acked...
>>> I guess my patch was never picked up.
>>>
>>
>> ... Better someone pick this up.
>>
>
> This build error is still occurring in linux-next (20130627).
> I first reported it and posted a patch for it on May-15 2013.
>
> Please merge either patch...
>
> Is anybody out there?
>
>
>>
>>>>
>>>> Ben.
>>>>
>>>>> ---
>>>>> drivers/platform/x86/Kconfig | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>>>> index 8577261..37645b9 100644
>>>>> --- a/drivers/platform/x86/Kconfig
>>>>> +++ b/drivers/platform/x86/Kconfig
>>>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
>>>>> config AMILO_RFKILL
>>>>> tristate "Fujitsu-Siemens Amilo rfkill support"
>>>>> depends on RFKILL
>>>>> + depends on SERIO_I8042
>>>>> ---help---
>>>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
>>>>> laptops.
>>>>
>>>
>>>
>>> --
>>> ~Randy
>> --
>
>
> --
> ~Randy
cc Jiri Kosina <trivial@kernel.org>
next prev parent reply other threads:[~2013-07-12 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 9:21 [PATCH]amilo-rfkill: add depends on i8042 in Kconfig Xiong Zhou
2013-06-18 13:04 ` Ben Hutchings
2013-06-18 15:00 ` Randy Dunlap
2013-06-19 1:09 ` Xiong Zhou
2013-06-27 16:40 ` Randy Dunlap
2013-07-12 3:46 ` Xiong Zhou [this message]
2013-08-20 11:05 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADJHv_sSn9oU-xg5qgoHRKDeyHRCqy8VuPJW5_punHd45inzsA@mail.gmail.com \
--to=jencce.kernel@gmail.com \
--cc=ben@decadent.org.uk \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).