* [PATCH 1/1] arm: add bandgap DT entry for OMAP5
@ 2013-06-19 2:36 Eduardo Valentin
2013-06-19 10:36 ` Benoit Cousson
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Valentin @ 2013-06-19 2:36 UTC (permalink / raw)
To: benoit.cousson
Cc: Eduardo Valentin, Benoît Cousson, Tony Lindgren,
Russell King, linux-omap, devicetree-discuss, linux-arm-kernel,
linux-kernel, J Keerthy
Add bandgap device DT entry for OMAP5 dtsi.
Cc: "Benoît Cousson" <b-cousson@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
arch/arm/boot/dts/omap5.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
---
Benoit,
Sorry for this very late request, but can you please consider
these patches for 3.11 still?
I completely forgot to send these on my "Enable TI SoC thermal driver" series.
All best,
Eduardo
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 2ad63c4..5ede6e1 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -615,5 +615,13 @@
interrupts = <0 80 0x4>;
ti,hwmods = "wd_timer2";
};
+ bandgap {
+ reg = <0x4a0021e0 0xc
+ 0x4a00232c 0xc
+ 0x4a002380 0x2c
+ 0x4a0023C0 0x3c>;
+ interrupts = <0 126 4>; /* talert */
+ compatible = "ti,omap5430-bandgap";
+ };
};
};
--
1.8.2.1.342.gfa7285d
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: add bandgap DT entry for OMAP5
2013-06-19 2:36 [PATCH 1/1] arm: add bandgap DT entry for OMAP5 Eduardo Valentin
@ 2013-06-19 10:36 ` Benoit Cousson
2013-06-19 12:12 ` Eduardo Valentin
0 siblings, 1 reply; 3+ messages in thread
From: Benoit Cousson @ 2013-06-19 10:36 UTC (permalink / raw)
To: Eduardo Valentin
Cc: benoit.cousson, Tony Lindgren, Russell King, linux-omap,
devicetree-discuss, linux-arm-kernel, linux-kernel, J Keerthy
Hi Eduardo,
On 06/18/2013 09:36 PM, Eduardo Valentin wrote:
> Add bandgap device DT entry for OMAP5 dtsi.
>
> Cc: "Benoît Cousson" <b-cousson@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-omap@vger.kernel.org
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
> ---
>
> Benoit,
>
> Sorry for this very late request, but can you please consider
> these patches for 3.11 still?
>
> I completely forgot to send these on my "Enable TI SoC thermal driver" series.
>
> All best,
>
> Eduardo
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 2ad63c4..5ede6e1 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -615,5 +615,13 @@
> interrupts = <0 80 0x4>;
> ti,hwmods = "wd_timer2";
> };
missing blank line
> + bandgap {
You must use the first address in that case. Otherwise DT will affect a random number and provide a non-standard device name. That does not really matter in theory, but it will looks ugly in the /sys/devices list.
> + reg = <0x4a0021e0 0xc
> + 0x4a00232c 0xc
> + 0x4a002380 0x2c
> + 0x4a0023C0 0x3c>;
> + interrupts = <0 126 4>; /* talert */
Not well aligned and should use the macros.
> + compatible = "ti,omap5430-bandgap";
> + };
> };
> };
>
I did the update for you :-)
Here is the version I've just applied.
Benoit
>From f0160bb93467e22f2f8bc77591dcd7e35cdee999 Mon Sep 17 00:00:00 2001
From: Eduardo Valentin <eduardo.valentin@ti.com>
Date: Tue, 18 Jun 2013 22:36:38 -0400
Subject: [PATCH] ARM: dts: Add bandgap DT entry for OMAP5
Add bandgap device DT entry for OMAP5 dtsi.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: J Keerthy <j-keerthy@ti.com>
Signed-off-by: Benoit Cousson <benoit.cousson@linaro.org>
---
arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index accab62..47693c9 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -696,5 +696,14 @@
interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
};
};
+
+ bandgap@4a0021e0 {
+ reg = <0x4a0021e0 0xc
+ 0x4a00232c 0xc
+ 0x4a002380 0x2c
+ 0x4a0023C0 0x3c>;
+ interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
+ compatible = "ti,omap5430-bandgap";
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: add bandgap DT entry for OMAP5
2013-06-19 10:36 ` Benoit Cousson
@ 2013-06-19 12:12 ` Eduardo Valentin
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Valentin @ 2013-06-19 12:12 UTC (permalink / raw)
To: Benoit Cousson
Cc: Eduardo Valentin, benoit.cousson, Tony Lindgren, Russell King,
linux-omap, devicetree-discuss, linux-arm-kernel, linux-kernel,
J Keerthy
[-- Attachment #1: Type: text/plain, Size: 3194 bytes --]
On 19-06-2013 06:36, Benoit Cousson wrote:
> Hi Eduardo,
>
> On 06/18/2013 09:36 PM, Eduardo Valentin wrote:
>> Add bandgap device DT entry for OMAP5 dtsi.
>>
>> Cc: "Benoît Cousson" <b-cousson@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: linux-omap@vger.kernel.org
>> Cc: devicetree-discuss@lists.ozlabs.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
>> Signed-off-by: J Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm/boot/dts/omap5.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> ---
>>
>> Benoit,
>>
>> Sorry for this very late request, but can you please consider
>> these patches for 3.11 still?
>>
>> I completely forgot to send these on my "Enable TI SoC thermal driver" series.
>>
>> All best,
>>
>> Eduardo
>>
>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>> index 2ad63c4..5ede6e1 100644
>> --- a/arch/arm/boot/dts/omap5.dtsi
>> +++ b/arch/arm/boot/dts/omap5.dtsi
>> @@ -615,5 +615,13 @@
>> interrupts = <0 80 0x4>;
>> ti,hwmods = "wd_timer2";
>> };
>
> missing blank line
>
>> + bandgap {
>
> You must use the first address in that case. Otherwise DT will affect a random number and provide a non-standard device name. That does not really matter in theory, but it will looks ugly in the /sys/devices list.
>
>> + reg = <0x4a0021e0 0xc
>> + 0x4a00232c 0xc
>> + 0x4a002380 0x2c
>> + 0x4a0023C0 0x3c>;
>> + interrupts = <0 126 4>; /* talert */
>
> Not well aligned and should use the macros.
>
>> + compatible = "ti,omap5430-bandgap";
>> + };
>> };
>> };
>>
>
> I did the update for you :-)
>
> Here is the version I've just applied.
>
> Benoit
>
>
>>From f0160bb93467e22f2f8bc77591dcd7e35cdee999 Mon Sep 17 00:00:00 2001
> From: Eduardo Valentin <eduardo.valentin@ti.com>
> Date: Tue, 18 Jun 2013 22:36:38 -0400
> Subject: [PATCH] ARM: dts: Add bandgap DT entry for OMAP5
>
> Add bandgap device DT entry for OMAP5 dtsi.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> Signed-off-by: Benoit Cousson <benoit.cousson@linaro.org>
> ---
> arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index accab62..47693c9 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -696,5 +696,14 @@
> interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
> };
> };
> +
> + bandgap@4a0021e0 {
> + reg = <0x4a0021e0 0xc
> + 0x4a00232c 0xc
> + 0x4a002380 0x2c
> + 0x4a0023C0 0x3c>;
> + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
> + compatible = "ti,omap5430-bandgap";
> + };
> };
> };
>
Looks good to me.
Tks Benoit!
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-19 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-19 2:36 [PATCH 1/1] arm: add bandgap DT entry for OMAP5 Eduardo Valentin
2013-06-19 10:36 ` Benoit Cousson
2013-06-19 12:12 ` Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).