[PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

[PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

[J Keerthy]

The Patch adds TPS659038 PMIC support in the palmas mfd driver.
The TPS659038 has almost the same registers as of the earlier
supported variants of PALMAS family such as the TWL6035.

The critical differences between TPS659038 and TWL6035 being:

1) TPS659038 has nothing related to battery charging and back up battery stuff.
2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
3) TPS659038 does not have Battery detection and anything related to battery.
4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
   when compared to TWL6035.

Signed-off-by: J Keerthy <j-keerthy@ti.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/mfd/palmas.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index ad2edd6..8b20055 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -233,12 +233,17 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c,
 }
 
 static unsigned int palmas_features = PALMAS_PMIC_FEATURE_SMPS10_BOOST;
+static unsigned int tps659038_features;
 
 static const struct of_device_id of_palmas_match_tbl[] = {
 	{
 		.compatible = "ti,palmas",
 		.data = &palmas_features,
 	},
+	{
+		.compatible = "ti,tps659038",
+		.data = &tps659038_features,
+	},
 	{ },
 };
 
-- 
1.7.5.4

RE: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

[J, KEERTHY]

Hello Samuel,

> -----Original Message-----
> From: J, KEERTHY
> Sent: Thursday, June 20, 2013 4:35 PM
> To: linux-omap@vger.kernel.org; sameo@linux.intel.com
> Cc: broonie@kernel.org; J, KEERTHY; ldewangan@nvidia.com;
> grant.likely@secretlab.ca; swarren@nvidia.com; linux-
> kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree-
> discuss@lists.ozlabs.org; gg@slimlogic.co.uk
> Subject: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support
> 
> The Patch adds TPS659038 PMIC support in the palmas mfd driver.
> The TPS659038 has almost the same registers as of the earlier supported
> variants of PALMAS family such as the TWL6035.
> 
> The critical differences between TPS659038 and TWL6035 being:
> 
> 1) TPS659038 has nothing related to battery charging and back up
> battery stuff.
> 2) TPS659038 does not have does not have SMPS10(Boost) step up
> convertor.
> 3) TPS659038 does not have Battery detection and anything related to
> battery.
> 4) SD card detection, Battery presence detection, Vibrator, USB OTG are
> missing
>    when compared to TWL6035.
> 

Could you please pull this patch?

> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
>  drivers/mfd/palmas.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c index
> ad2edd6..8b20055 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -233,12 +233,17 @@ static void palmas_dt_to_pdata(struct i2c_client
> *i2c,  }
> 
>  static unsigned int palmas_features =
> PALMAS_PMIC_FEATURE_SMPS10_BOOST;
> +static unsigned int tps659038_features;
> 
>  static const struct of_device_id of_palmas_match_tbl[] = {
>  	{
>  		.compatible = "ti,palmas",
>  		.data = &palmas_features,
>  	},
> +	{
> +		.compatible = "ti,tps659038",
> +		.data = &tps659038_features,
> +	},
>  	{ },
>  };
> 
> --
> 1.7.5.4

Regards,
Keerthy

Re: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

[Samuel Ortiz]

Hi,

On Thu, Jun 20, 2013 at 04:35:16PM +0530, J Keerthy wrote:
> The Patch adds TPS659038 PMIC support in the palmas mfd driver.
> The TPS659038 has almost the same registers as of the earlier
> supported variants of PALMAS family such as the TWL6035.
> 
> The critical differences between TPS659038 and TWL6035 being:
> 
> 1) TPS659038 has nothing related to battery charging and back up battery stuff.
> 2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
> 3) TPS659038 does not have Battery detection and anything related to battery.
> 4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
>    when compared to TWL6035.
> 
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
>  drivers/mfd/palmas.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
Applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

RE: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

[J, KEERTHY]

> -----Original Message-----
> From: Samuel Ortiz [mailto:sameo@linux.intel.com]
> Sent: Monday, June 24, 2013 5:13 PM
> To: J, KEERTHY
> Cc: linux-omap@vger.kernel.org; broonie@kernel.org;
> ldewangan@nvidia.com; grant.likely@secretlab.ca; swarren@nvidia.com;
> linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree-
> discuss@lists.ozlabs.org; gg@slimlogic.co.uk
> Subject: Re: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support
> 
> Hi,
> 
> On Thu, Jun 20, 2013 at 04:35:16PM +0530, J Keerthy wrote:
> > The Patch adds TPS659038 PMIC support in the palmas mfd driver.
> > The TPS659038 has almost the same registers as of the earlier
> > supported variants of PALMAS family such as the TWL6035.
> >
> > The critical differences between TPS659038 and TWL6035 being:
> >
> > 1) TPS659038 has nothing related to battery charging and back up
> battery stuff.
> > 2) TPS659038 does not have does not have SMPS10(Boost) step up
> convertor.
> > 3) TPS659038 does not have Battery detection and anything related to
> battery.
> > 4) SD card detection, Battery presence detection, Vibrator, USB OTG
> are missing
> >    when compared to TWL6035.
> >
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> > ---
> >  drivers/mfd/palmas.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> Applied, thanks.

Thanks Samuel.

> 
> Cheers,
> Samuel.
> 
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/

[PATCH 2/4] mfd: Palmas: Add TPS659038 PMIC support

[J Keerthy]

The Patch adds TPS659038 PMIC support in the palmas mfd driver.
The TPS659038 has almost the same registers as of the earlier
supported variants of PALMAS family such as the TWL6035.

The critical differences between TPS659038 and TWL6035 being:

1) TPS659038 has nothing related to battery charging and back up battery stuff.
2) TPS659038 does not have does not have SMPS10(Boost) step up convertor.
3) TPS659038 does not have Battery detection and anything related to battery.
4) SD card detection, Battery presence detection, Vibrator, USB OTG are missing
   when compared to TWL6035.

Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
 Documentation/devicetree/bindings/mfd/palmas.txt |    2 ++
 drivers/mfd/palmas.c                             |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
index 7bcd59c..89cb773 100644
--- a/Documentation/devicetree/bindings/mfd/palmas.txt
+++ b/Documentation/devicetree/bindings/mfd/palmas.txt
@@ -5,6 +5,7 @@ twl6035 (palmas)
 twl6037 (palmas)
 tps65913 (palmas)
 tps65914 (palmas)
+tps659038
 
 Required properties:
 - compatible : Should be from the list
@@ -14,6 +15,7 @@ Required properties:
   ti,tps65913
   ti,tps65914
   ti,tps80036
+  ti,tps659038
 and also the generic series names
   ti,palmas
 - interrupt-controller : palmas has its own internal IRQs
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index d06ce62..261beb5 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -233,11 +233,17 @@ static void palmas_dt_to_pdata(struct i2c_client *i2c,
 
 static unsigned int palmas_features = PALMAS_PMIC_FEATURE_INTERRUPT;
 
+static unsigned int tps659038_features;
+
 static const struct of_device_id of_palmas_match_tbl[] = {
 	{
 		.compatible = "ti,palmas",
 		.data = &palmas_features,
 	},
+	{
+		.compatible = "ti,tps659038",
+		.data = &tps659038_features,
+	},
 	{ },
 };
 
-- 
1.7.5.4