* [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries
@ 2013-06-20 8:54 Hanjun Guo
2013-06-20 19:52 ` Rafael J. Wysocki
2013-06-21 4:30 ` Rob Landley
0 siblings, 2 replies; 5+ messages in thread
From: Hanjun Guo @ 2013-06-20 8:54 UTC (permalink / raw)
To: Rob Landley
Cc: Rusty Russell, Srivatsa Vaddagiri, linux-acpi, linux-doc,
linux-kernel, patches, linaro-kernel, Hanjun Guo
More than 256 entries in ACPI MADT is supported from ACPI 3.0 Specification,
So the outdated description for MADT entries should be removed.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
Documentation/cpu-hotplug.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
index 9f40135..2e36e40 100644
--- a/Documentation/cpu-hotplug.txt
+++ b/Documentation/cpu-hotplug.txt
@@ -370,9 +370,6 @@ A: There is no clear spec defined way from ACPI that can give us that
CPUs in MADT as hotpluggable CPUS. In the case there are no disabled CPUS
we assume 1/2 the number of CPUs currently present can be hotplugged.
- Caveat: Today's ACPI MADT can only provide 256 entries since the apicid field
- in MADT is only 8 bits.
-
User Space Notification
Hotplug support for devices is common in Linux today. Its being used today to
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries
2013-06-20 8:54 [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries Hanjun Guo
@ 2013-06-20 19:52 ` Rafael J. Wysocki
2013-06-21 2:16 ` Hanjun Guo
2013-06-21 4:30 ` Rob Landley
1 sibling, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2013-06-20 19:52 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rob Landley, Rusty Russell, Srivatsa Vaddagiri, linux-acpi,
linux-doc, linux-kernel, patches, linaro-kernel
On Thursday, June 20, 2013 04:54:42 PM Hanjun Guo wrote:
> More than 256 entries in ACPI MADT is supported from ACPI 3.0 Specification,
> So the outdated description for MADT entries should be removed.
Well, it kind of is still valid for systems pre-dating ACPI 3.0, isn't it?
So perhaps instead of simply removing that information it would be better to
rephrase it?
Thanks,
Rafael
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> Documentation/cpu-hotplug.txt | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
> index 9f40135..2e36e40 100644
> --- a/Documentation/cpu-hotplug.txt
> +++ b/Documentation/cpu-hotplug.txt
> @@ -370,9 +370,6 @@ A: There is no clear spec defined way from ACPI that can give us that
> CPUs in MADT as hotpluggable CPUS. In the case there are no disabled CPUS
> we assume 1/2 the number of CPUs currently present can be hotplugged.
>
> - Caveat: Today's ACPI MADT can only provide 256 entries since the apicid field
> - in MADT is only 8 bits.
> -
> User Space Notification
>
> Hotplug support for devices is common in Linux today. Its being used today to
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries
2013-06-20 19:52 ` Rafael J. Wysocki
@ 2013-06-21 2:16 ` Hanjun Guo
0 siblings, 0 replies; 5+ messages in thread
From: Hanjun Guo @ 2013-06-21 2:16 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rob Landley, Rusty Russell, Srivatsa Vaddagiri, linux-acpi,
linux-doc, linux-kernel, patches, linaro-kernel
On 2013-6-21 3:52, Rafael J. Wysocki wrote:
> On Thursday, June 20, 2013 04:54:42 PM Hanjun Guo wrote:
>> More than 256 entries in ACPI MADT is supported from ACPI 3.0 Specification,
>> So the outdated description for MADT entries should be removed.
>
> Well, it kind of is still valid for systems pre-dating ACPI 3.0, isn't it?
Yes, it is.
>
> So perhaps instead of simply removing that information it would be better to
> rephrase it?
Good idea, I will update my patch and send out soon.
Thanks
Hanjun
>
> Thanks,
> Rafael
>
>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>> Documentation/cpu-hotplug.txt | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/Documentation/cpu-hotplug.txt b/Documentation/cpu-hotplug.txt
>> index 9f40135..2e36e40 100644
>> --- a/Documentation/cpu-hotplug.txt
>> +++ b/Documentation/cpu-hotplug.txt
>> @@ -370,9 +370,6 @@ A: There is no clear spec defined way from ACPI that can give us that
>> CPUs in MADT as hotpluggable CPUS. In the case there are no disabled CPUS
>> we assume 1/2 the number of CPUs currently present can be hotplugged.
>>
>> - Caveat: Today's ACPI MADT can only provide 256 entries since the apicid field
>> - in MADT is only 8 bits.
>> -
>> User Space Notification
>>
>> Hotplug support for devices is common in Linux today. Its being used today to
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries
2013-06-20 8:54 [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries Hanjun Guo
2013-06-20 19:52 ` Rafael J. Wysocki
@ 2013-06-21 4:30 ` Rob Landley
2013-06-26 9:21 ` Jiri Kosina
1 sibling, 1 reply; 5+ messages in thread
From: Rob Landley @ 2013-06-21 4:30 UTC (permalink / raw)
To: Hanjun Guo
Cc: Rusty Russell, Srivatsa Vaddagiri, linux-acpi, linux-doc,
linux-kernel, patches, linaro-kernel, Hanjun Guo, trivial
On 06/20/2013 03:54:42 AM, Hanjun Guo wrote:
> More than 256 entries in ACPI MADT is supported from ACPI 3.0
> Specification,
> So the outdated description for MADT entries should be removed.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> Documentation/cpu-hotplug.txt | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Rob Landley <rob@landley.net>
> diff --git a/Documentation/cpu-hotplug.txt
> b/Documentation/cpu-hotplug.txt
> index 9f40135..2e36e40 100644
> --- a/Documentation/cpu-hotplug.txt
> +++ b/Documentation/cpu-hotplug.txt
> @@ -370,9 +370,6 @@ A: There is no clear spec defined way from ACPI
> that can give us that
> CPUs in MADT as hotpluggable CPUS. In the case there are no
> disabled CPUS
> we assume 1/2 the number of CPUs currently present can be
> hotplugged.
>
> - Caveat: Today's ACPI MADT can only provide 256 entries since the
> apicid field
> - in MADT is only 8 bits.
> -
> User Space Notification
>
> Hotplug support for devices is common in Linux today. Its being used
> today to
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries
2013-06-21 4:30 ` Rob Landley
@ 2013-06-26 9:21 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2013-06-26 9:21 UTC (permalink / raw)
To: Rob Landley
Cc: Hanjun Guo, Rusty Russell, Srivatsa Vaddagiri, linux-acpi,
linux-doc, linux-kernel, patches, linaro-kernel
On Thu, 20 Jun 2013, Rob Landley wrote:
> On 06/20/2013 03:54:42 AM, Hanjun Guo wrote:
> > More than 256 entries in ACPI MADT is supported from ACPI 3.0 Specification,
> > So the outdated description for MADT entries should be removed.
> >
> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> > ---
> > Documentation/cpu-hotplug.txt | 3 ---
> > 1 file changed, 3 deletions(-)
>
> Acked-by: Rob Landley <rob@landley.net>
I am not taking this one, as I think the information should be kept there
to reflect the state on systems that are not 3.0-compliant.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-26 9:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-20 8:54 [PATCH] Documentation / cpu hotplug: remove outdated description for MADT entries Hanjun Guo
2013-06-20 19:52 ` Rafael J. Wysocki
2013-06-21 2:16 ` Hanjun Guo
2013-06-21 4:30 ` Rob Landley
2013-06-26 9:21 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).