From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date: Mon, 05 Dec 2016 15:37:39 +0000 [thread overview]
Message-ID: <13727.1480952259@warthog.procyon.org.uk> (raw)
In-Reply-To: <20161204160504.GG1555@ZenIV.linux.org.uk>
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > I understand wanting to avoid extra arguments, but you are asking for
> > trouble with that sort of calling conventions. Verifying that all call
> > chains have these fields initialized is bloody unpleasant and it *is*
> > going to break, especially since the rules are "you need to initialize it
> > for vfs_xgetattr(), but not for vfs_getattr()" - the names are similar
> > enough for confusion, and that's not the only such pair.
>
> BTW, after some grepping: you seem to leave ecryptfs_getattr() as-is, which
> means that flags it had been passed by caller in *stat are not seen by
> underlying fs. Looks fishy...
I have patches for some other filesystems as well, but I'm trying to nail the
core down before whipping those back into shape.
David
next prev parent reply other threads:[~2016-12-05 15:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:55 [RFC][PATCH 0/4] Enhanced file stat system call [ver #3] David Howells
2016-11-23 0:55 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available " David Howells
2016-11-23 8:37 ` Michael Kerrisk (man-pages)
2016-11-23 22:42 ` Andreas Dilger
2016-11-23 22:57 ` Andreas Dilger
2016-11-24 8:13 ` Michael Kerrisk (man-pages)
2016-11-24 2:08 ` Andreas Dilger
2016-11-24 7:27 ` David Howells
2016-12-04 4:00 ` Al Viro
2016-12-04 4:38 ` Al Viro
2016-12-04 16:05 ` Al Viro
2016-12-04 17:33 ` Al Viro
2016-12-05 14:49 ` Miklos Szeredi
2016-12-05 15:37 ` David Howells [this message]
2016-11-23 0:55 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes " David Howells
2016-11-23 17:59 ` Andreas Dilger
2016-11-23 0:56 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-23 0:56 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-24 2:06 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13727.1480952259@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).