From: Andreas Dilger <adilger@dilger.ca>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] statx: AFS: Return enhanced file attributes [ver #3]
Date: Wed, 23 Nov 2016 19:06:30 -0700 [thread overview]
Message-ID: <347478EC-7A98-40C0-97EB-2677B6BE1654@dilger.ca> (raw)
In-Reply-To: <147986257312.19139.10417237189956494459.stgit@warthog.procyon.org.uk>
[-- Attachment #1: Type: text/plain, Size: 3537 bytes --]
On Nov 22, 2016, at 5:56 PM, David Howells <dhowells@redhat.com> wrote:
>
> Return enhanced file attributes from the AFS filesystem. This includes the
> following:
>
> (1) STATX_ATTR_AUTOMOUNT will be set on automount directories by virtue of
> S_AUTOMOUNT being set on the inode. These are referrals to other
> volumes or other cells.
>
> STATX_ATIME, STATX_CTIME and STATX_BLOCKS are cleared as AFS does not
> support them.
>
> Example output:
>
> [root@andromeda ~]# ./samples/statx/test-statx /afs
> statx(/afs) = 0
> results=7ef
This decodes to everything except STATX_GID being set:
STATX_TYPE 0x00000001U
STATX_MODE 0x00000002U
STATX_NLINK 0x00000004U
STATX_UID 0x00000008U
!STATX_GID 0x00000010U
STATX_ATIME 0x00000020U
STATX_MTIME 0x00000040U
STATX_CTIME 0x00000080U
STATX_INO 0x00000100U
STATX_SIZE 0x00000200U
STATX_BLOCKS 0x00000400U
> Size: 2048 Blocks: 0 IO Block: 4096 directory
> Device: 00:25 Inode: 1 Links: 2
> Access: (0777/drwxrwxrwx) Uid: 0 Gid: 0
> Access: 2006-05-07 00:21:15.000000000+0100
> Modify: 2006-05-07 00:21:15.000000000+0100
> Change: 2006-05-07 00:21:15.000000000+0100
> IO-blocksize: blksize=4096
This is printing Access and Change times, but you write above that
STATX_ATIME, STATX_CTIME, and STATX_BLOCKS are unset for AFS, so they
shouldn't be printed? Since "results" appear to indicate those flags
are set, and looking at the dump_statx() code appears that they are
checked, it seems this patch isn't doing what you want to clear flags?
Also, it seems that "Gid: 0" is printed even though it is not set in stx_mask? Possibly this example is old?
Cheers, Andreas
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> fs/afs/inode.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/fs/afs/inode.c b/fs/afs/inode.c
> index 86cc7264c21c..99662045b6fb 100644
> --- a/fs/afs/inode.c
> +++ b/fs/afs/inode.c
> @@ -72,9 +72,9 @@ static int afs_inode_map_status(struct afs_vnode *vnode, struct key *key)
> inode->i_uid = vnode->status.owner;
> inode->i_gid = GLOBAL_ROOT_GID;
> inode->i_size = vnode->status.size;
> - inode->i_ctime.tv_sec = vnode->status.mtime_server;
> - inode->i_ctime.tv_nsec = 0;
> - inode->i_atime = inode->i_mtime = inode->i_ctime;
> + inode->i_mtime.tv_sec = vnode->status.mtime_server;
> + inode->i_mtime.tv_nsec = 0;
> + inode->i_atime = inode->i_ctime = inode->i_mtime;
> inode->i_blocks = 0;
> inode->i_generation = vnode->fid.unique;
> inode->i_version = vnode->status.data_version;
> @@ -375,8 +375,7 @@ int afs_validate(struct afs_vnode *vnode, struct key *key)
> /*
> * read the attributes of an inode
> */
> -int afs_getattr(struct vfsmount *mnt, struct dentry *dentry,
> - struct kstat *stat)
> +int afs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat)
> {
> struct inode *inode;
>
> @@ -385,6 +384,8 @@ int afs_getattr(struct vfsmount *mnt, struct dentry *dentry,
> _enter("{ ino=%lu v=%u }", inode->i_ino, inode->i_generation);
>
> generic_fillattr(inode, stat);
> +
> + stat->result_mask &= ~(STATX_ATIME | STATX_CTIME | STATX_BLOCKS);
> return 0;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2016-11-24 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:55 [RFC][PATCH 0/4] Enhanced file stat system call [ver #3] David Howells
2016-11-23 0:55 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available " David Howells
2016-11-23 8:37 ` Michael Kerrisk (man-pages)
2016-11-23 22:42 ` Andreas Dilger
2016-11-23 22:57 ` Andreas Dilger
2016-11-24 8:13 ` Michael Kerrisk (man-pages)
2016-11-24 2:08 ` Andreas Dilger
2016-11-24 7:27 ` David Howells
2016-12-04 4:00 ` Al Viro
2016-12-04 4:38 ` Al Viro
2016-12-04 16:05 ` Al Viro
2016-12-04 17:33 ` Al Viro
2016-12-05 14:49 ` Miklos Szeredi
2016-12-05 15:37 ` David Howells
2016-11-23 0:55 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes " David Howells
2016-11-23 17:59 ` Andreas Dilger
2016-11-23 0:56 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-23 0:56 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-24 2:06 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=347478EC-7A98-40C0-97EB-2677B6BE1654@dilger.ca \
--to=adilger@dilger.ca \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).