* [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
@ 2013-07-09 15:36 Stephen Boyd
2013-07-24 18:56 ` Stephen Boyd
0 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2013-07-09 15:36 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, linux-arm-kernel
If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.
CPU 0 CPU 1
----- -----
spin_lock(my_lock)
smp_send_stop()
<send IPI> handle_IPI()
disable_preemption/irqs
while(1);
<PREEMPT>
spin_lock(my_lock) <--- Waits forever
We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that this task runs to
completion.
Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Resending this patch now that the context has changed.
arch/arm/kernel/process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 7f1efcd..8bc12d7 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -206,6 +206,7 @@ void machine_shutdown(void)
*/
void machine_halt(void)
{
+ preempt_disable();
smp_send_stop();
local_irq_disable();
@@ -220,6 +221,7 @@ void machine_halt(void)
*/
void machine_power_off(void)
{
+ preempt_disable();
smp_send_stop();
if (pm_power_off)
@@ -239,6 +241,7 @@ void machine_power_off(void)
*/
void machine_restart(char *cmd)
{
+ preempt_disable();
smp_send_stop();
arm_pm_restart(reboot_mode, cmd);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
2013-07-09 15:36 [PATCH] ARM: Fix deadlock scenario with smp_send_stop() Stephen Boyd
@ 2013-07-24 18:56 ` Stephen Boyd
2013-07-24 20:21 ` Russell King - ARM Linux
0 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2013-07-24 18:56 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, linux-arm-kernel
On 07/09, Stephen Boyd wrote:
> If one process calls sys_reboot and that process then stops other
> CPUs while those CPUs are within a spin_lock() region we can
> potentially encounter a deadlock scenario like below.
>
> CPU 0 CPU 1
> ----- -----
> spin_lock(my_lock)
> smp_send_stop()
> <send IPI> handle_IPI()
> disable_preemption/irqs
> while(1);
> <PREEMPT>
> spin_lock(my_lock) <--- Waits forever
>
> We shouldn't attempt to run any other tasks after we send a stop
> IPI to a CPU so disable preemption so that this task runs to
> completion.
>
> Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> Resending this patch now that the context has changed.
Ping? Shall I put this in the patch tracker?
>
> arch/arm/kernel/process.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 7f1efcd..8bc12d7 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -206,6 +206,7 @@ void machine_shutdown(void)
> */
> void machine_halt(void)
> {
> + preempt_disable();
> smp_send_stop();
>
> local_irq_disable();
> @@ -220,6 +221,7 @@ void machine_halt(void)
> */
> void machine_power_off(void)
> {
> + preempt_disable();
> smp_send_stop();
>
> if (pm_power_off)
> @@ -239,6 +241,7 @@ void machine_power_off(void)
> */
> void machine_restart(char *cmd)
> {
> + preempt_disable();
> smp_send_stop();
>
> arm_pm_restart(reboot_mode, cmd);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
2013-07-24 18:56 ` Stephen Boyd
@ 2013-07-24 20:21 ` Russell King - ARM Linux
2013-07-24 20:29 ` Stephen Boyd
2013-07-24 20:36 ` [PATCH v2] " Stephen Boyd
0 siblings, 2 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2013-07-24 20:21 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, linux-arm-kernel
On Wed, Jul 24, 2013 at 11:56:18AM -0700, Stephen Boyd wrote:
> On 07/09, Stephen Boyd wrote:
> > If one process calls sys_reboot and that process then stops other
> > CPUs while those CPUs are within a spin_lock() region we can
> > potentially encounter a deadlock scenario like below.
> >
> > CPU 0 CPU 1
> > ----- -----
> > spin_lock(my_lock)
> > smp_send_stop()
> > <send IPI> handle_IPI()
> > disable_preemption/irqs
> > while(1);
> > <PREEMPT>
> > spin_lock(my_lock) <--- Waits forever
> >
> > We shouldn't attempt to run any other tasks after we send a stop
> > IPI to a CPU so disable preemption so that this task runs to
> > completion.
> >
> > Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >
> > Resending this patch now that the context has changed.
>
> Ping? Shall I put this in the patch tracker?
Well, looking at x86, they use local_irq_disable() before sending the
stop, so I think we should do the same for cross-arch consistency.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
2013-07-24 20:21 ` Russell King - ARM Linux
@ 2013-07-24 20:29 ` Stephen Boyd
2013-07-24 20:36 ` [PATCH v2] " Stephen Boyd
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-07-24 20:29 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, linux-arm-kernel
On 07/24/13 13:21, Russell King - ARM Linux wrote:
> On Wed, Jul 24, 2013 at 11:56:18AM -0700, Stephen Boyd wrote:
>> On 07/09, Stephen Boyd wrote:
>>> If one process calls sys_reboot and that process then stops other
>>> CPUs while those CPUs are within a spin_lock() region we can
>>> potentially encounter a deadlock scenario like below.
>>>
>>> CPU 0 CPU 1
>>> ----- -----
>>> spin_lock(my_lock)
>>> smp_send_stop()
>>> <send IPI> handle_IPI()
>>> disable_preemption/irqs
>>> while(1);
>>> <PREEMPT>
>>> spin_lock(my_lock) <--- Waits forever
>>>
>>> We shouldn't attempt to run any other tasks after we send a stop
>>> IPI to a CPU so disable preemption so that this task runs to
>>> completion.
>>>
>>> Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
>>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>>> ---
>>>
>>> Resending this patch now that the context has changed.
>> Ping? Shall I put this in the patch tracker?
> Well, looking at x86, they use local_irq_disable() before sending the
> stop, so I think we should do the same for cross-arch consistency.
Fair enough. I'll send v2 with that.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ARM: Fix deadlock scenario with smp_send_stop()
2013-07-24 20:21 ` Russell King - ARM Linux
2013-07-24 20:29 ` Stephen Boyd
@ 2013-07-24 20:36 ` Stephen Boyd
2013-07-30 22:12 ` Stephen Boyd
1 sibling, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2013-07-24 20:36 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, linux-arm-kernel
If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.
CPU 0 CPU 1
----- -----
spin_lock(my_lock)
smp_send_stop()
<send IPI> handle_IPI()
disable_preemption/irqs
while(1);
<PREEMPT>
spin_lock(my_lock) <--- Waits forever
We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that this task runs to
completion. We use local_irq_disable() here for cross-arch
consistency with x86.
Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Changes since v1:
- Use local_irq_disable() instead of preempt_disable()
arch/arm/kernel/process.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index d3ca4f6..08b47eb 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -197,6 +197,7 @@ void machine_shutdown(void)
*/
void machine_halt(void)
{
+ local_irq_disable();
smp_send_stop();
local_irq_disable();
@@ -211,6 +212,7 @@ void machine_halt(void)
*/
void machine_power_off(void)
{
+ local_irq_disable();
smp_send_stop();
if (pm_power_off)
@@ -230,6 +232,7 @@ void machine_power_off(void)
*/
void machine_restart(char *cmd)
{
+ local_irq_disable();
smp_send_stop();
arm_pm_restart(reboot_mode, cmd);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] ARM: Fix deadlock scenario with smp_send_stop()
2013-07-24 20:36 ` [PATCH v2] " Stephen Boyd
@ 2013-07-30 22:12 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2013-07-30 22:12 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, linux-arm-kernel
On 07/24/13 13:36, Stephen Boyd wrote:
> If one process calls sys_reboot and that process then stops other
> CPUs while those CPUs are within a spin_lock() region we can
> potentially encounter a deadlock scenario like below.
>
> CPU 0 CPU 1
> ----- -----
> spin_lock(my_lock)
> smp_send_stop()
> <send IPI> handle_IPI()
> disable_preemption/irqs
> while(1);
> <PREEMPT>
> spin_lock(my_lock) <--- Waits forever
>
> We shouldn't attempt to run any other tasks after we send a stop
> IPI to a CPU so disable preemption so that this task runs to
> completion. We use local_irq_disable() here for cross-arch
> consistency with x86.
>
> Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Ok I threw this into the patch tracker because there were no more comments.
> Changes since v1:
> - Use local_irq_disable() instead of preempt_disable()
>
> arch/arm/kernel/process.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index d3ca4f6..08b47eb 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -197,6 +197,7 @@ void machine_shutdown(void)
> */
> void machine_halt(void)
> {
> + local_irq_disable();
> smp_send_stop();
>
> local_irq_disable();
> @@ -211,6 +212,7 @@ void machine_halt(void)
> */
> void machine_power_off(void)
> {
> + local_irq_disable();
> smp_send_stop();
>
> if (pm_power_off)
> @@ -230,6 +232,7 @@ void machine_power_off(void)
> */
> void machine_restart(char *cmd)
> {
> + local_irq_disable();
> smp_send_stop();
>
> arm_pm_restart(reboot_mode, cmd);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
@ 2012-09-05 21:01 Stephen Boyd
2012-09-11 18:08 ` Stephen Boyd
0 siblings, 1 reply; 8+ messages in thread
From: Stephen Boyd @ 2012-09-05 21:01 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, linux-arm-kernel
If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.
CPU 0 CPU 1
----- -----
spin_lock(my_lock)
smp_send_stop()
send_IPI handle_IPI()
disable_preemption/irqs
while(1);
<PREEMPT>
spin_lock(my_lock) <--- Waits forever
We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that the reboot task runs to
completion.
Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Unfortunately this won't fix the other problem I mentioned two weeks
ago where smp_send_stop races with other CPUs calling cpu_up().
arch/arm/kernel/process.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 693b744..663a7a8 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -239,6 +239,7 @@ __setup("reboot=", reboot_setup);
void machine_shutdown(void)
{
+ preempt_disable();
#ifdef CONFIG_SMP
smp_send_stop();
#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: Fix deadlock scenario with smp_send_stop()
2012-09-05 21:01 [PATCH] " Stephen Boyd
@ 2012-09-11 18:08 ` Stephen Boyd
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2012-09-11 18:08 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, linux-arm-kernel
On 09/05/12 14:01, Stephen Boyd wrote:
> If one process calls sys_reboot and that process then stops other
> CPUs while those CPUs are within a spin_lock() region we can
> potentially encounter a deadlock scenario like below.
>
> CPU 0 CPU 1
> ----- -----
> spin_lock(my_lock)
> smp_send_stop()
> send_IPI handle_IPI()
> disable_preemption/irqs
> while(1);
> <PREEMPT>
> spin_lock(my_lock) <--- Waits forever
>
> We shouldn't attempt to run any other tasks after we send a stop
> IPI to a CPU so disable preemption so that the reboot task runs to
> completion.
>
> Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> Unfortunately this won't fix the other problem I mentioned two weeks
> ago where smp_send_stop races with other CPUs calling cpu_up().
Any comments?
>
> arch/arm/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 693b744..663a7a8 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -239,6 +239,7 @@ __setup("reboot=", reboot_setup);
>
> void machine_shutdown(void)
> {
> + preempt_disable();
> #ifdef CONFIG_SMP
> smp_send_stop();
> #endif
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-30 22:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-09 15:36 [PATCH] ARM: Fix deadlock scenario with smp_send_stop() Stephen Boyd
2013-07-24 18:56 ` Stephen Boyd
2013-07-24 20:21 ` Russell King - ARM Linux
2013-07-24 20:29 ` Stephen Boyd
2013-07-24 20:36 ` [PATCH v2] " Stephen Boyd
2013-07-30 22:12 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2012-09-05 21:01 [PATCH] " Stephen Boyd
2012-09-11 18:08 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).